From: Andrew Morton <akpm@linux-foundation.org>
To: Hao Ge <hao.ge@linux.dev>
Cc: Suren Baghdasaryan <surenb@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Abhishek Bapat <abhishekbapat@google.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] alloc_tag: fix undetected compressed tag overflow when profiling is disabled
Date: Tue, 4 Aug 2026 16:42:35 -0700 [thread overview]
Message-ID: <20260804164235.69c9473cf00ac70cd2e7ed4a@linux-foundation.org> (raw)
In-Reply-To: <20260804064408.105033-1-hao.ge@linux.dev>
On Tue, 4 Aug 2026 14:44:08 +0800 Hao Ge <hao.ge@linux.dev> wrote:
> In reserve_module_tags(), the tag overflow check is gated on
> mem_alloc_profiling_enabled():
>
> if (mem_alloc_profiling_enabled() && !tags_addressable())
>
> If profiling is toggled off at runtime and a module is loaded whose
> tags exceed the compressed-mode limit, shutdown_mem_profiling() is
> skipped. vm_module_tags_populate() still maps memory for the tags and
> the module loads successfully, but the total tag count now exceeds what
> NR_UNUSED_PAGEFLAG_BITS can address.
>
> Once profiling is re-enabled, ref_to_idx() computes each tag's index
> as its position in the alloc_tag array. update_page_tag_ref() masks
> it to alloc_tag_ref_mask before storing in page->flags. Indices
> beyond the mask are truncated and idx_to_ref() resolves them to wrong
> tags.
With bad effects, one assumes.
When fixing a bug please always include a complete description of the
userspace-visible runtime effects of that bug.
> mem_alloc_profiling_enabled() and mem_profiling_compressed are
> independent. Once compressed mode is established at boot, it stays
> active regardless of runtime toggles of mem_profiling.
>
> We therefore remove the mem_alloc_profiling_enabled() guard.
It appears that AI review has found a pre-existing error-path cleanup
issue:
https://sashiko.dev/#/patchset/20260804064408.105033-1-hao.ge@linux.dev
prev parent reply other threads:[~2026-08-04 23:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 6:44 [PATCH] alloc_tag: fix undetected compressed tag overflow when profiling is disabled Hao Ge
2026-08-04 23:42 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260804164235.69c9473cf00ac70cd2e7ed4a@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=abhishekbapat@google.com \
--cc=hao.ge@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=stable@vger.kernel.org \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.