From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9500A3EB0FA; Tue, 4 Aug 2026 18:37:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785868675; cv=none; b=n/LnL/BnY3P35FpL618sFEL0ZsRmyZbDQ3G+HsyCaqDgMlOz7IZ3gtLQ0qlynmH5mrKhjlxu9/fUGn1kaAY0Qyrce9ckKPOpKCESKUE2xGI8w9fuh9sEqxpeZAkRtDvfQ+wUjUSysD3mf4Jyz5zoe+Z17MNkhWX0cxWry/dWOSw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785868675; c=relaxed/simple; bh=07cBacEHSGLAxN3NJZwdLIVfQa/OQXOqaKqYUGKOKZE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Lf8n0dsNOUhEeA5EaqHSWg28RjxaAFbZZovQffrLs+dQieM//j5sJbrIJdk+c+5I/rrXJfkPsbm2opW9y9SdE5I7z34NA2cNm0OxIMCJPVfn6axyPCLexJHb2ZZbxcVjM2SN1pVX7gktLuhFrb4h0kKTcrrx5sgOAkMoHkC07u8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hp6rw9ri; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hp6rw9ri" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E667A1F000E9; Tue, 4 Aug 2026 18:37:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785868674; bh=ehEaXeyHsLmTxWK7M3YlgnXecFCsvwQ93NjgKqgcras=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=hp6rw9rizyKhIpvcVktLWi5HXvQ43+URj/96MqC/d6VpvipumAblyalS02HPyiNQ4 GzV7jGX0AtHAfEpB80iiBXIHiUXDbI8QQPLD1BEfbdO9uOyojdPHa9k1CZ8a+B6RPN AOBX9+l2BbKq/L1nXUv/cpgVq83P4204ulINDCB/U5N1mcUYYZjNUybxC5/u3aFMqH g/TaV2sSxtDpl9Uzhazk0F0X8pna/Cm05hUe2YeCRHdCWjd5y5ywbqssoA1TwEqD+y Jurd8kjKsAC90UmXeVdAsZOHZ9rV1GQrtRJgzNveyUq/LTUycW9SN1YU43paaP2zZP TMPtGi8b0HoBQ== Date: Tue, 4 Aug 2026 18:37:52 +0000 From: Eric Biggers To: Christoph Hellwig Cc: Andrey Albershteyn , linux-xfs@vger.kernel.org, fsverity@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-btrfs@vger.kernel.org, djwong@kernel.org Subject: Re: [PATCH v14 05/21] fsverity: improve flushing performance of fsverity_fill_zerohash Message-ID: <20260804183752.GC2904385@google.com> References: <20260803200820.393203-1-aalbersh@kernel.org> <20260803200820.393203-6-aalbersh@kernel.org> <20260804174223.GB14046@lst.de> Precedence: bulk X-Mailing-List: fsverity@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260804174223.GB14046@lst.de> On Tue, Aug 04, 2026 at 07:42:23PM +0200, Christoph Hellwig wrote: > On Mon, Aug 03, 2026 at 10:07:55PM +0200, Andrey Albershteyn wrote: > > The current version calls flush_dcache_folio(), in memcpy_to_folio(), to > > flush whole folio on every digest (which is 128 for 4k) on the HIGHMEM > > systems. Open code folio mapping and flushing to copy all digests at > > once. > > This looks correct, although to me optimizing for this feels like > premature optimizations not worth the ugly code unless we have numbers > to justify it. > > If Eric wants it: > > Reviewed-by: Christoph Hellwig > > > + if (folio_test_partial_kmap(folio) && > > + off > PAGE_SIZE - offset_in_page(offset)) > > + off = PAGE_SIZE - offset_in_page(offset); > > + for (; to < (vaddr + off); to += vi->tree_params.digest_size) > > Style nitpick: no need for braces when comparing with simple > integer arithmetics like this. > > > + for (off = offset; off < (offset + len); > > Same here. Well I didn't ask for it per se, but I pointed it out and asked whether anyone will care about the combination of XFS && FS_VERITY && HIGHMEM. Based on Darrick's email it seems the answer may be no? If it's kept as-is, adding a comment mentioning that it doesn't need to be optimized for HIGHMEM would help preempt any questions about it. - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04A2FC55822 for ; Tue, 4 Aug 2026 18:38:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:References: Message-ID:To:Date:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IbA9763Z46myLURagfN0Qj+tQ0n4VRvX90diE1vhRsQ=; b=g9X8xgexEf6o7gXAnctWF5tT3d mvZcu++pxWT3PIbi8dVhnhxNCAAf+v2Nje1fNO+YBlkSOKXHByohSXU+8TBEtLCOL09Pl52bvcFOc QZknrewNhqPQExMAHhco0UXz4rkbRAXwzmkt5s0vAQN3BvlwlGvQ8WaTh+BW0/+gF92E=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wrK1b-0002A2-3j; Tue, 04 Aug 2026 18:38:03 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wrK1Z-00029w-Rv for linux-f2fs-devel@lists.sourceforge.net; Tue, 04 Aug 2026 18:38:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ehEaXeyHsLmTxWK7M3YlgnXecFCsvwQ93NjgKqgcras=; b=GNcS/pihk0PSKUvQCJIM9YmgXs 2obCTJLFnyAZ6CoW9EuTB3Yitwy3q2k1b0QAQHq/rIPOerl5OxJg6W5CBpqn5VUWQw882zt1V3fVp F32g5JU85Ra+z6yvorhYzlzA4x5mFKkwMGNfEa6hH9qF952Okta/gr8KBLG+G39AcPv0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ehEaXeyHsLmTxWK7M3YlgnXecFCsvwQ93NjgKqgcras=; b=emiuGjFlmP2oT5kxE2kxJMSTkJ kGP+MrfCqeAZixOQZntH/g0xJ4PZBzXy7HvXWFa65BLLd3On8al/xpmm9qBROuH4sFShM1SvKDSbt 2YGeembkeXHhvFhIn3v3UDrPc6vWJU3+V0Mqt7dgCvhu3ogpIMoxGMM5IU3vsdawhFIg=; Received: from tor.source.kernel.org ([172.105.4.254]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wrK1b-0001Nh-Mq for linux-f2fs-devel@lists.sourceforge.net; Tue, 04 Aug 2026 18:38:02 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 8CA3960AA7; Tue, 4 Aug 2026 18:37:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E667A1F000E9; Tue, 4 Aug 2026 18:37:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785868674; bh=ehEaXeyHsLmTxWK7M3YlgnXecFCsvwQ93NjgKqgcras=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=hp6rw9rizyKhIpvcVktLWi5HXvQ43+URj/96MqC/d6VpvipumAblyalS02HPyiNQ4 GzV7jGX0AtHAfEpB80iiBXIHiUXDbI8QQPLD1BEfbdO9uOyojdPHa9k1CZ8a+B6RPN AOBX9+l2BbKq/L1nXUv/cpgVq83P4204ulINDCB/U5N1mcUYYZjNUybxC5/u3aFMqH g/TaV2sSxtDpl9Uzhazk0F0X8pna/Cm05hUe2YeCRHdCWjd5y5ywbqssoA1TwEqD+y Jurd8kjKsAC90UmXeVdAsZOHZ9rV1GQrtRJgzNveyUq/LTUycW9SN1YU43paaP2zZP TMPtGi8b0HoBQ== Date: Tue, 4 Aug 2026 18:37:52 +0000 To: Christoph Hellwig Message-ID: <20260804183752.GC2904385@google.com> References: <20260803200820.393203-1-aalbersh@kernel.org> <20260803200820.393203-6-aalbersh@kernel.org> <20260804174223.GB14046@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260804174223.GB14046@lst.de> X-Headers-End: 1wrK1b-0001Nh-Mq Subject: Re: [f2fs-dev] [PATCH v14 05/21] fsverity: improve flushing performance of fsverity_fill_zerohash X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eric Biggers via Linux-f2fs-devel Reply-To: Eric Biggers Cc: fsverity@lists.linux.dev, Andrey Albershteyn , djwong@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Tue, Aug 04, 2026 at 07:42:23PM +0200, Christoph Hellwig wrote: > On Mon, Aug 03, 2026 at 10:07:55PM +0200, Andrey Albershteyn wrote: > > The current version calls flush_dcache_folio(), in memcpy_to_folio(), to > > flush whole folio on every digest (which is 128 for 4k) on the HIGHMEM > > systems. Open code folio mapping and flushing to copy all digests at > > once. > > This looks correct, although to me optimizing for this feels like > premature optimizations not worth the ugly code unless we have numbers > to justify it. > > If Eric wants it: > > Reviewed-by: Christoph Hellwig > > > + if (folio_test_partial_kmap(folio) && > > + off > PAGE_SIZE - offset_in_page(offset)) > > + off = PAGE_SIZE - offset_in_page(offset); > > + for (; to < (vaddr + off); to += vi->tree_params.digest_size) > > Style nitpick: no need for braces when comparing with simple > integer arithmetics like this. > > > + for (off = offset; off < (offset + len); > > Same here. Well I didn't ask for it per se, but I pointed it out and asked whether anyone will care about the combination of XFS && FS_VERITY && HIGHMEM. Based on Darrick's email it seems the answer may be no? If it's kept as-is, adding a comment mentioning that it doesn't need to be optimized for HIGHMEM would help preempt any questions about it. - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel