From: sashiko-bot@kernel.org
To: "Douglas Anderson" <dianders@chromium.org>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH] dt-bindings: mailbox: Delete old 'mailbox.txt' bindings file
Date: Tue, 04 Aug 2026 20:44:48 +0000 [thread overview]
Message-ID: <20260804204450.03CC61F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260804133801.1.I8b3ff71c528133e7d6f81fe926fa39e6451d63fd@changeid>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Deleting `mailbox.txt` without updating references to it in other binding files leaves dangling, broken documentation references.
--
--- Patch [1]: [PATCH] dt-bindings: mailbox: Delete old 'mailbox.txt' bindings file ---
commit 1b70b3f250d6bcf306aca223e0e91c9fb8a20cc2
Author: Douglas Anderson <dianders@chromium.org>
dt-bindings: mailbox: Delete old 'mailbox.txt' bindings file
This commit deletes the old mailbox.txt device-tree bindings file. The
documentation contained in the file has been moved to the dt-schema
repository.
Link: https://lore.kernel.org/r/20260722140214.GA548057-robh@kernel.org [1]
Link: https://lore.kernel.org/r/dc7a2041-50a4-482e-9930-566bb3fd1e72@kernel.org [2]
Link: https://lore.kernel.org/r/CAL_JsqKVjQ2m-dzMUENQry-f_YE9QrYSOKoH9CPj1gjj8XkPRA@mail.gmail.com [3]
Link: https://github.com/devicetree-org/dt-schema/pull/202 [4]
> diff --git a/Documentation/devicetree/bindings/mailbox/mailbox.txt b/Documentation/devicetree/bindings/mailbox/mailbox.txt
> deleted file mode 100644
> index af8ecee2ac687..0000000000000
> --- a/Documentation/devicetree/bindings/mailbox/mailbox.txt
> +++ /dev/null
> @@ -1,60 +0,0 @@
> -* Generic Mailbox Controller and client driver bindings
[Severity: Low]
Does deleting this file leave dangling documentation links in other bindings
that still reference it?
For example, there are explicit references to mailbox.txt in:
- Documentation/devicetree/bindings/mailbox/ti,omap-mailbox.yaml
- Documentation/devicetree/bindings/power/reset/xlnx,zynqmp-power.yaml
- Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml
- Documentation/devicetree/bindings/firmware/nvidia,tegra186-bpmp.yaml
- Documentation/devicetree/bindings/mailbox/allwinner,sun6i-a31-msgbox.yaml
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260804133801.1.I8b3ff71c528133e7d6f81fe926fa39e6451d63fd@changeid?part=1
next prev parent reply other threads:[~2026-08-04 20:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 20:38 [PATCH] dt-bindings: mailbox: Delete old 'mailbox.txt' bindings file Douglas Anderson
2026-08-04 20:44 ` sashiko-bot [this message]
2026-08-04 20:49 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260804204450.03CC61F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.