From: sashiko-bot@kernel.org
To: "Ethan Plant" <plant.ethan@gmail.com>
Cc: ojeda@kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH] rust: pci: Mark Device refcount methods inline
Date: Tue, 04 Aug 2026 23:25:31 +0000 [thread overview]
Message-ID: <20260804232532.2C4C41F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260804-inline-wrappers-v1-1-16916db867e5@gmail.com>
> From: Ethan Plant <plant.ethan@gmail.com>
>
> When building the kernel, the following Rust symbols are generated:
> $ nm vmlinux | grep ' _R' | rustfilt | grep -E 'pci::Device.*(inc_ref|dec_ref)'
> ... T <kernel::pci::Device as kernel::sync::aref::AlwaysRefCounted>::dec_ref
> ... T <kernel::pci::Device as kernel::sync::aref::AlwaysRefCounted>::inc_ref
>
> These Rust symbols are trivial wrappers around pci_dev_put() and
> pci_dev_get(), respectively. It doesn't make sense to go through a
> trivial wrapper for these functions, so mark them inline.
>
> Suggested-by: Alice Ryhl <aliceryhl@google.com>
> Link: https://github.com/Rust-for-Linux/linux/issues/1145
> Signed-off-by: Ethan Plant <plant.ethan@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260804-inline-wrappers-v1-1-16916db867e5@gmail.com?part=1
next prev parent reply other threads:[~2026-08-04 23:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 23:24 [PATCH] rust: pci: Mark Device refcount methods inline Ethan Plant via B4 Relay
2026-08-04 23:24 ` Ethan Plant
2026-08-04 23:25 ` sashiko-bot [this message]
2026-08-05 7:52 ` Alice Ryhl
2026-08-06 21:31 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260804232532.2C4C41F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=plant.ethan@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.