All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Pecio <michal.pecio@gmail.com>
To: Rong Zhang <i@rong.moe>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Icenowy Zheng <uwu@icenowy.me>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ALSA: usb-audio: Do not expose sticky mixers
Date: Tue, 4 Aug 2026 23:55:15 +0200	[thread overview]
Message-ID: <20260804235515.7346606e.michal.pecio@gmail.com> (raw)
In-Reply-To: <20260411-uac-sticky-mixer-v1-3-29d62717befd@rong.moe>

On Sat, 11 Apr 2026 01:49:04 +0800, Rong Zhang wrote:
> Some devices' mixers are sticky, which accept SET_CUR but do absolutely
> nothing. Registering these mixers confuses userspace and results in
> ineffective volume control.
> 
> Check if a mixer is sticky by setting the volume to the maximum or
> minimum value and checking for effectiveness afterward. Prevent the
> mixer from being registered if it turns out to be sticky.
> 
> Quirky device sample:
> 
>   usb 7-1: New USB device found, idVendor=0e0b, idProduct=fa01, bcdDevice= 1.00
>   usb 7-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
>   usb 7-1: Product: Feaulle Rainbow
>   usb 7-1: Manufacturer: Generic
>   usb 7-1: SerialNumber: 20210726905926
>   (Mic Capture Volume)
> 
> Signed-off-by: Rong Zhang <i@rong.moe>

This appears to break (yet another) device, as reported below.
Not 100% sure because both affected users ran away to -lts and
appear to be of the "won't compile kernel patches" variety.

https://bbs.archlinux.org/viewtopic.php?id=314220

My $.02 - was there no way to deal with this in userspace,
or to make it opt-in rather than opt-out?

Regards,
Michal

  reply	other threads:[~2026-08-04 21:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-10 17:49 [PATCH 0/3] ALSA: usb-audio: Refactor mixer checks and add check for sticky mixers Rong Zhang
2026-04-10 17:49 ` [PATCH 1/3] ALSA: usb-audio: Add error checks against get_min_max*() Rong Zhang
2026-04-10 17:49 ` [PATCH 2/3] ALSA: usb-audio: Move volume control resolution check into a function Rong Zhang
2026-04-10 17:49 ` [PATCH 3/3] ALSA: usb-audio: Do not expose sticky mixers Rong Zhang
2026-08-04 21:55   ` Michal Pecio [this message]
2026-08-05 14:32     ` Rong Zhang
2026-08-05 15:32       ` Takashi Iwai
2026-08-05 16:52         ` Rong Zhang
2026-08-08 20:10       ` Michal Pecio
2026-08-08 20:24         ` Rong Zhang
2026-04-11  8:03 ` [PATCH 0/3] ALSA: usb-audio: Refactor mixer checks and add check for " Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260804235515.7346606e.michal.pecio@gmail.com \
    --to=michal.pecio@gmail.com \
    --cc=i@rong.moe \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=uwu@icenowy.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.