All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Shih-Yuan Lee <fourdollars@debian.org>, Mark Brown <broonie@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev, linux-spi@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Shih-Yuan Lee <fourdollars@debian.org>
Subject: Re: [PATCH v4 2/2] spi: pxa2xx: restore LPSS private register state on S3 resume
Date: Wed, 5 Aug 2026 02:35:59 +0200	[thread overview]
Message-ID: <202608050250.Walny9nd-lkp@intel.com> (raw)
In-Reply-To: <20260717163731.6782-3-fourdollars@debian.org>

Hi Shih-Yuan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on broonie-spi/for-next]
[also build test WARNING on linus/master v7.2-rc6 next-20260804]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Shih-Yuan-Lee/spi-pxa2xx-disable-DMA-and-fix-runtime-PM-for-Apple-MacBook8-1/20260804-222537
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
patch link:    https://lore.kernel.org/r/20260717163731.6782-3-fourdollars%40debian.org
patch subject: [PATCH v4 2/2] spi: pxa2xx: restore LPSS private register state on S3 resume
config: x86_64-rhel-9.4-bpf (https://download.01.org/0day-ci/archive/20260805/202608050250.Walny9nd-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260805/202608050250.Walny9nd-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202608050250.Walny9nd-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/spi/spi-pxa2xx.c: In function 'pxa2xx_spi_resume':
>> drivers/spi/spi-pxa2xx.c:1554:28: warning: unused variable 'ssp' [-Wunused-variable]
    1554 |         struct ssp_device *ssp = drv_data->ssp;
         |                            ^~~


vim +/ssp +1554 drivers/spi/spi-pxa2xx.c

e0c9905e87ac1b drivers/spi/pxa2xx_spi.c Stephen Street  2006-03-07  1550  
86d2593afeb94e drivers/spi/pxa2xx_spi.c Mike Rapoport   2009-07-21  1551  static int pxa2xx_spi_resume(struct device *dev)
e0c9905e87ac1b drivers/spi/pxa2xx_spi.c Stephen Street  2006-03-07  1552  {
86d2593afeb94e drivers/spi/pxa2xx_spi.c Mike Rapoport   2009-07-21  1553  	struct driver_data *drv_data = dev_get_drvdata(dev);
2f1a74e5a2de04 drivers/spi/pxa2xx_spi.c eric miao       2007-11-21 @1554  	struct ssp_device *ssp = drv_data->ssp;
bffc967e93c771 drivers/spi/spi-pxa2xx.c Jarkko Nikula   2016-09-07  1555  	int status;
e0c9905e87ac1b drivers/spi/pxa2xx_spi.c Stephen Street  2006-03-07  1556  
e0c9905e87ac1b drivers/spi/pxa2xx_spi.c Stephen Street  2006-03-07  1557  	/* Enable the SSP clock */
62bbc864d1946c drivers/spi/spi-pxa2xx.c Tobias Jordan   2018-04-30  1558  	if (!pm_runtime_suspended(dev)) {
74ff7000fd41ae drivers/spi/spi-pxa2xx.c Shih-Yuan Lee   2026-07-18  1559  		status = pxa2xx_spi_clk_enable(drv_data);
62bbc864d1946c drivers/spi/spi-pxa2xx.c Tobias Jordan   2018-04-30  1560  		if (status)
62bbc864d1946c drivers/spi/spi-pxa2xx.c Tobias Jordan   2018-04-30  1561  			return status;
62bbc864d1946c drivers/spi/spi-pxa2xx.c Tobias Jordan   2018-04-30  1562  	}
e0c9905e87ac1b drivers/spi/pxa2xx_spi.c Stephen Street  2006-03-07  1563  
74ff7000fd41ae drivers/spi/spi-pxa2xx.c Shih-Yuan Lee   2026-07-18  1564  	drv_data->suspended = false;
74ff7000fd41ae drivers/spi/spi-pxa2xx.c Shih-Yuan Lee   2026-07-18  1565  
e0c9905e87ac1b drivers/spi/pxa2xx_spi.c Stephen Street  2006-03-07  1566  	/* Start the queue running */
51eea52d26d493 drivers/spi/spi-pxa2xx.c Lubomir Rintel  2019-01-16  1567  	return spi_controller_resume(drv_data->controller);
e0c9905e87ac1b drivers/spi/pxa2xx_spi.c Stephen Street  2006-03-07  1568  }
7d94a505858841 drivers/spi/spi-pxa2xx.c Mika Westerberg 2013-01-22  1569  

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

      reply	other threads:[~2026-08-05  0:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-12 16:24 [PATCH 0/2] spi: pxa2xx: MacBook8,1 quirk and LPSS S3 resume fixes Shih-Yuan Lee
2026-07-12 16:24 ` [PATCH 1/2] spi: pxa2xx: disable DMA and fix runtime PM for Apple MacBook8,1 Shih-Yuan Lee
2026-07-12 16:24 ` [PATCH 2/2] spi: pxa2xx: restore LPSS private and IDMA registers on S3 resume Shih-Yuan Lee
2026-07-13 16:02   ` Mark Brown
2026-07-17 15:46 ` [PATCH v3 0/2] spi: pxa2xx: MacBook8,1 quirk and LPSS S3 resume state fixes Shih-Yuan Lee
2026-07-17 15:46   ` [PATCH v3 1/2] spi: pxa2xx: disable DMA and fix runtime PM for Apple MacBook8,1 Shih-Yuan Lee
2026-07-17 15:46   ` [PATCH v3 2/2] spi: pxa2xx: restore LPSS private register state on S3 resume Shih-Yuan Lee
2026-07-17 21:43   ` [PATCH v3 0/2] spi: pxa2xx: MacBook8,1 quirk and LPSS S3 resume state fixes Mark Brown
2026-07-17 23:47     ` Shih-Yuan Lee (FourDollars)
2026-07-17 16:37 ` [PATCH v4 " Shih-Yuan Lee
2026-07-17 16:37   ` [PATCH v4 1/2] spi: pxa2xx: disable DMA and fix runtime PM for Apple MacBook8,1 Shih-Yuan Lee
2026-07-17 16:37   ` [PATCH v4 2/2] spi: pxa2xx: restore LPSS private register state on S3 resume Shih-Yuan Lee
2026-08-05  0:35     ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202608050250.Walny9nd-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=broonie@kernel.org \
    --cc=fourdollars@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.