All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Ido Schimmel <idosch@nvidia.com>
Cc: Zhiling Zou <zhilinz@nebusec.ai>,
	netdev@vger.kernel.org, dsahern@kernel.org, davem@davemloft.net,
	edumazet@google.com, pabeni@redhat.com, horms@kernel.org,
	tom@herbertland.com, vega@nebusec.ai
Subject: Re: [PATCH net 1/1] ip6_tunnel: use skb_cow_head() in ip6_tnl_xmit()
Date: Wed, 5 Aug 2026 17:29:02 -0700	[thread overview]
Message-ID: <20260805172902.27c9bde0@kernel.org> (raw)
In-Reply-To: <20260805090721.GA1364862@shredder>

On Wed, 5 Aug 2026 12:07:21 +0300 Ido Schimmel wrote:
> __gre6_xmit() and ip6erspan_tunnel_xmit() already call skb_cow_head()
> before calling ip6_tnl_xmit().

Probably just me but can't they all be buggy?
PKTGEN likes to send shared skbs around in funny ways.
Can we get a good explanation in the commit msg or maybe let's
keep the check?

  reply	other threads:[~2026-08-06  0:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-03  5:34 [PATCH net 0/1] ip6_tunnel: use skb_cow_head() in ip6_tnl_xmit() Zhiling Zou
2026-08-03  5:34 ` [PATCH net 1/1] " Zhiling Zou
2026-08-05  9:07   ` Ido Schimmel
2026-08-06  0:29     ` Jakub Kicinski [this message]
2026-08-06  8:52       ` Ido Schimmel
2026-08-06  9:06         ` zhilin zou
2026-08-06 16:28           ` Paolo Abeni
2026-08-06 18:19             ` Ido Schimmel
2026-08-07  8:31               ` Paolo Abeni
2026-08-09  7:57                 ` Ido Schimmel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260805172902.27c9bde0@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=tom@herbertland.com \
    --cc=vega@nebusec.ai \
    --cc=zhilinz@nebusec.ai \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.