Re: [PATCH v7 2/3] dt-bindings: mmc: Add reset-card-at-resume property

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing schema dependency for 'reset-card-at-resume' property.
--

--- Patch [2]: [PATCH v7 2/3] dt-bindings: mmc: Add reset-card-at-resume property ---
commit 58ef61eea1643d1fd872cdd2532bc0149abeb166
Author: Kamal Dasu <kamal.dasu@broadcom.com>

dt-bindings: mmc: Add reset-card-at-resume property

On some platforms, firmware or other hardware accesses the card
during suspend/resume, before the kernel's own resume path has run,
leaving the card in a state the kernel can no longer assume it knows.
Add a flag property so such boards can tell the mmc core the card
needs to be reset before it can be used again.

> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller-common.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller-common.yaml
> index c18bf0d6a56ec..6929969ed5a2a 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-controller-common.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller-common.yaml
> @@ -293,6 +293,13 @@ properties:
>      description:
>        Preserves card power during a suspend/resume cycle.
>  
> +  reset-card-at-resume:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      The HW/FW may have accessed the card during suspend/resume,
> +      leaving it in an unknown state. Hence, before the card can be
> +      used, it must be reset.
> +

[Severity: Low]
Does this new property need to be added to the dependencies block at the bottom
of the file?

The commit message notes this flag "is expected to be paired with
keep-power-in-suspend", because a resume reset only makes sense if power is
preserved (otherwise power cycling forces a reset inherently). The v7 changelog
also states the driver now strictly requires this property alongside
keep-power-in-suspend for (e)MMC.

Without a schema dependency, device trees might incorrectly specify
reset-card-at-resume without the required keep-power-in-suspend property and
still pass dt_binding_check validation. Would it be better to enforce this
constraint in the schema?

dependencies:
  cd-debounce-delay-ms: [ cd-gpios ]
  fixed-emmc-driver-type: [ non-removable ]
  reset-card-at-resume: [ keep-power-in-suspend ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260805222500.2567801-1-kamal.dasu@broadcom.com?part=2