From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24A5DC55174 for ; Wed, 5 Aug 2026 23:11:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6347110F02B; Wed, 5 Aug 2026 23:10:54 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="cuy2go/F"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id AC8EC10F027; Wed, 5 Aug 2026 23:10:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1785971452; x=1817507452; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=NZLOXaen9jDVMjpnEaM9wnAKmSoircGZzGky2M1Tvb0=; b=cuy2go/FdFNe/1AvogMLA1XcPOkBbFum4m8zH76IMdPmvWu3ixSfq3RT 8I7ZLgWDGLH3gyHvxP2dAUy7ESVcdChZJ1OBNpQh/VQSHH1ycj5bfxbKc kHwZqi4jpMGCR0DgegnCrGnMcS1Yg+3LUS1Hf71xo7gHT1wkJIcXuBvf5 gsr7xQlqG0vt9Bp3QJbGfbGYj79Twf79QQnTgESnod80VQI1se3USuz8c OCpEUo1v8ZwCHwP6C4dEx5wLhn0+nOjKQPD1cgJuCmZdRkfxuAw8xc+7+ B4Bkafo0TR4LFlg7vPlM8A7fYpTmwr+t0JBjE3S9DaocziQsasra3HHIn w==; X-CSE-ConnectionGUID: FsecV284SReUdV0pG2m5zQ== X-CSE-MsgGUID: B5PqEziURPCgThdpizip9Q== X-IronPort-AV: E=McAfee;i="6800,10657,11866"; a="90376911" X-IronPort-AV: E=Sophos;i="6.25,207,1779174000"; d="scan'208";a="90376911" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Aug 2026 16:10:52 -0700 X-CSE-ConnectionGUID: Mu2CKANrRdOv2SSKNqnKZw== X-CSE-MsgGUID: W3bcdhw1So+UvqvPffSiGw== X-ExtLoop1: 1 Received: from gsse-cloud1.jf.intel.com ([10.54.39.91]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Aug 2026 16:10:51 -0700 From: Matthew Brost To: intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Usama Arif , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Balbir Singh , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Francois Dugast Subject: [PATCH v3 6/6] drm/pagemap: Add fault injection for higher-order RAM folio allocation Date: Wed, 5 Aug 2026 16:10:41 -0700 Message-Id: <20260805231041.3791771-7-matthew.brost@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260805231041.3791771-1-matthew.brost@intel.com> References: <20260805231041.3791771-1-matthew.brost@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Migrating a device-private THP back to system memory has two distinct paths in __migrate_device_pages(): the fast path where both source and destination carry MIGRATE_PFN_COMPOUND, and the fallback path where the destination could only be satisfied with order-0 folios and the source THP therefore has to be split via migrate_vma_split_unmapped_folio(). The fallback path only triggers under genuine memory pressure, which makes it both rare and awkward to reproduce, yet it is the path where the interesting refcounting happens (the CPU fault holds an extra reference on the device folio taken by do_huge_pmd_device_private()). Add a fault_attr, modelled on backup_fault_inject in ttm_pool.c, that forces the higher-order allocation in drm_pagemap_migrate_populate_ram_pfn() to fail so the existing order-0 fallback is taken deterministically. The attribute is exposed at /sys/kernel/debug/drm_pagemap_fault_inject and requires CONFIG_FAULT_INJECTION_DEBUG_FS. With CONFIG_FAULT_INJECTION disabled the helper compiles out to a constant false and the injection has no cost. Cc: Andrew Morton Cc: David Hildenbrand Cc: Lorenzo Stoakes Cc: Zi Yan Cc: Baolin Wang Cc: Liam R. Howlett Cc: Nico Pache Cc: Ryan Roberts Cc: Dev Jain Cc: Barry Song Cc: Lance Yang Cc: Usama Arif Cc: Joshua Hahn Cc: Rakie Kim Cc: Byungchul Park Cc: Gregory Price Cc: Ying Huang Cc: Alistair Popple Cc: Balbir Singh Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Simona Vetter Cc: Thomas Hellström Cc: Francois Dugast Cc: dri-devel@lists.freedesktop.org Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org Assisted-by: GitHub_Copilot:claude-opus-5 Signed-off-by: Matthew Brost --- drivers/gpu/drm/drm_pagemap.c | 36 ++++++++++++++++++++++++++++++++++- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_pagemap.c b/drivers/gpu/drm/drm_pagemap.c index 51c6f12e4256..6ae8c9aa36cc 100644 --- a/drivers/gpu/drm/drm_pagemap.c +++ b/drivers/gpu/drm/drm_pagemap.c @@ -3,6 +3,7 @@ * Copyright © 2024-2025 Intel Corporation */ +#include #include #include #include @@ -12,6 +13,27 @@ #include #include +#ifdef CONFIG_FAULT_INJECTION +#include +static DECLARE_FAULT_ATTR(migrate_to_ram_fault_inject); + +/* + * Force a higher-order destination folio allocation to fail in + * drm_pagemap_migrate_populate_ram_pfn(), exercising the order-0 fallback + * (and, in turn, the THP split path in __migrate_device_pages()) without + * having to drive the system into actual memory pressure. + */ +static bool drm_pagemap_fault_inject_folio(void) +{ + return should_fail(&migrate_to_ram_fault_inject, 1); +} +#else +static bool drm_pagemap_fault_inject_folio(void) +{ + return false; +} +#endif + /** * DOC: Overview * @@ -960,7 +982,9 @@ static int drm_pagemap_migrate_populate_ram_pfn(struct vm_area_struct *vas, if (order) gfp |= __GFP_NOWARN; - if (vas) + if (order && drm_pagemap_fault_inject_folio()) + folio = NULL; + else if (vas) folio = vma_alloc_folio(gfp, order, vas, addr); else folio = folio_alloc(gfp, order); @@ -1554,6 +1578,16 @@ void drm_pagemap_destroy(struct drm_pagemap *dpagemap, bool is_atomic_or_reclaim kfree(dpagemap); } +static int __init drm_pagemap_module_init(void) +{ +#if defined(CONFIG_DEBUG_FS) && defined(CONFIG_FAULT_INJECTION) + fault_create_debugfs_attr("drm_pagemap_fault_inject", NULL, + &migrate_to_ram_fault_inject); +#endif + return 0; +} +module_init(drm_pagemap_module_init); + static void drm_pagemap_exit(void) { flush_work(&drm_pagemap_work); -- 2.34.1