All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: rsbecker@nexbridge.com
Cc: git@vger.kernel.org
Subject: Re: Question on textconv
Date: Thu, 6 Aug 2026 00:10:52 -0400	[thread overview]
Message-ID: <20260806041052.GA1610686@coredump.intra.peff.net> (raw)
In-Reply-To: <020201dd24e3$89ad1220$9d073660$@nexbridge.com>

On Wed, Aug 05, 2026 at 10:05:52AM -0400, rsbecker@nexbridge.com wrote:

> Could we extend textconv to support %f (the original path) if specified in the
> textconv configuration? That would solve the ambiguity of what is being supplied.

In theory, yes. But there is one gotcha: there's a system for caching
textconv output in git-notes, and it uses only the original blob id as
the cache key.

So I'm not opposed to adding something like %f, as long as the patch to
do so handles the caching problem (even if it just refuses to cache,
that would be much better than returning possibly-wrong results).

That said, it sounds like you just want %f to work around a bug where
the content is not provided. Probably fixing the bug is a better path
forward. Looking at the working tree file to get the contents will not
always be correct (e.g., if you're diffing an old tree).

-Peff

      reply	other threads:[~2026-08-06  4:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-04 18:44 Question on textconv rsbecker
2026-08-04 20:52 ` D. Ben Knoble
2026-08-04 21:45   ` rsbecker
2026-08-05  4:50 ` Jeff King
2026-08-05 11:36   ` D. Ben Knoble
2026-08-05 14:05   ` rsbecker
2026-08-06  4:10     ` Jeff King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260806041052.GA1610686@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=rsbecker@nexbridge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.