From: sashiko-bot@kernel.org
To: "Xie Yuanbin" <xieyuanbin1@huawei.com>
Cc: linux-modules@vger.kernel.org
Subject: Re: [PATCH] ARM: unwind: modules: Fix the mismatch between .ARM.exidx* and .text
Date: Thu, 06 Aug 2026 04:22:09 +0000 [thread overview]
Message-ID: <20260806042210.3CC531F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260806041001.143888-1-xieyuanbin1@huawei.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Typo in the wildcard pattern `[0-9a-z-A-Z_]*` introduces an unintended literal hyphen and diverges from the `.text` pattern syntax.
--
--- Patch [1]: [PATCH] ARM: unwind: modules: Fix the mismatch between .ARM.exidx* and .text ---
commit 77bfa32ad8c348a1008e578b132ff69e6108ddd2
Author: Xie Yuanbin <xieyuanbin1@huawei.com>
ARM: unwind: modules: Fix the mismatch between .ARM.exidx* and .text
This commit modifies the module linker script for ARM to merge
.ARM.extab.text.* and .ARM.exidx.text.* sections. It addresses a stack
unwinding failure caused by newer compilers splitting sections.
> diff --git a/scripts/module.lds.S b/scripts/module.lds.S
> index d0f2004289576..0ccf0c205d005 100644
> --- a/scripts/module.lds.S
> +++ b/scripts/module.lds.S
> @@ -39,6 +39,10 @@ SECTIONS {
> .text 0 : {
> *(.text .text.[0-9a-zA-Z_]*)
> }
> +#if defined(CONFIG_ARM) && defined(CONFIG_ARM_UNWIND)
> + .ARM.extab : {*(.ARM.extab .ARM.extab.text.[0-9a-z-A-Z_]*) }
> + .ARM.exidx : {*(.ARM.exidx .ARM.exidx.text.[0-9a-z-A-Z_]*) }
[Severity: Low]
This isn't a bug, but there appears to be an extra hyphen in the wildcard
pattern between z and A. Could this be corrected to match the [0-9a-zA-Z_]*
pattern used in the .text section just above?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260806041001.143888-1-xieyuanbin1@huawei.com?part=1
next prev parent reply other threads:[~2026-08-06 4:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 4:10 [PATCH] ARM: unwind: modules: Fix the mismatch between .ARM.exidx* and .text Xie Yuanbin
2026-08-06 4:22 ` sashiko-bot [this message]
2026-08-06 9:40 ` Petr Pavlu
2026-08-06 9:58 ` Xie Yuanbin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260806042210.3CC531F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=xieyuanbin1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.