Re: [PATCH v2 1/3] dt-bindings: clock: qcom: Move x1e80100 TCSR to own binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The newly added binding for the x1e80100 TCSR defines provider capabilities (`#clock-cells` and `#reset-cells`) in the `properties` block but omits them from the `required` list.
--

--- Patch [1]: [PATCH v2 1/3] dt-bindings: clock: qcom: Move x1e80100 TCSR to own binding ---
commit 16b928cadee464be45b850ff14bcbce5380b441f
Author: Qiang Yu <qiang.yu@oss.qualcomm.com>

dt-bindings: clock: qcom: Move x1e80100 TCSR to own binding

The QREF block supplies reference clocks to PCIe/USB/UFS PHYs and requires
dedicated LDO supplies to operate. The digital control interface for QREF
resides in TCSR on x1e80100, so these supply properties are placed in the
TCSR node. Add a dedicated binding file for qcom,x1e80100-tcsr to document
these supply properties.

> diff --git a/Documentation/devicetree/bindings/clock/qcom,x1e80100-tcsr.yaml b/Documentation/devicetree/bindings/clock/qcom,x1e80100-tcsr.yaml
> new file mode 100644
> index 0000000000000..55182cf550e7d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,x1e80100-tcsr.yaml
[ ... ]
> +  '#clock-cells':
> +    const: 1
> +
> +  '#reset-cells':
> +    const: 1
[ ... ]
> +required:
> +  - compatible
> +  - clocks
> +  - vdda-qrefrpt0-0p9-supply

[Severity: Medium]
Should #clock-cells and #reset-cells be included in this required list?

Since the TCSR acts as a clock and reset provider, omitting the cell-count
properties from the required list allows incomplete device tree nodes to
silently pass schema validation. This can lead to runtime failures in drivers
that depend on the hardware as a provider.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260805-hamoa_tcsr_qref_0805-v2-0-4f1cfb1fcab2@oss.qualcomm.com?part=1