All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiebin Sun <jiebin.sun@intel.com>
To: namhyung@kernel.org
Cc: acme@kernel.org, mingo@redhat.com, peterz@infradead.org,
	adrian.hunter@intel.com, alexander.shishkin@linux.intel.com,
	irogers@google.com, james.clark@linaro.org, jolsa@kernel.org,
	mark.rutland@arm.com, dapeng1.mi@linux.intel.com,
	thomas.falcon@intel.com, tianyou.li@intel.com,
	wangyang.guo@intel.com, linux-perf-users@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 0/9] perf c2c: add a function view
Date: Thu,  6 Aug 2026 15:47:10 +0800	[thread overview]
Message-ID: <20260806074710.2847155-1-jiebin.sun@intel.com> (raw)
In-Reply-To: <anN-livkfPdXq7Uy@google.com>

Hi Namhyung,

Thanks for reporting this. I reproduced the Python import failure. Although
the loader reported c2c_fmt_free, checking with `ldd -r` showed four
unresolved symbols from c2c-function.o: c2c, c2c_fmt_equal, c2c_fmt_free,
and perf_c2c__browse_cacheline.

I considered moving the formatter callbacks to util/ as suggested. However,
that would still leave c2c, the command's global state, and
perf_c2c__browse_cacheline(), its existing TUI entry point, unresolved.

The issue comes from placing c2c-function.o in libperf-ui.a, which is linked
into python/perf.so under --whole-archive, while builtin-c2c.o is not part
of the Python module. Since the browser is specific to the c2c command, v7
links it directly into perf alongside builtin-c2c.o, under CONFIG_SLANG.

This is folded into the browser skeleton patch; the other eight patches are
unchanged. I clean-built every commit and ran `perf test -v 'import perf'`
at each step. I also verified the full series with and without SLANG.

The `--stdio` support and function-view test will follow on top of v7.

Thanks,
Jiebin

  reply	other threads:[~2026-08-06  7:40 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-03  3:52 [PATCH v6 0/9] perf c2c: add a function view Jiebin Sun
2026-08-03  3:52 ` [PATCH v6 1/9] perf c2c: extract shared data structures into c2c.h Jiebin Sun
2026-08-03  3:58   ` sashiko-bot
2026-08-03  3:52 ` [PATCH v6 2/9] perf c2c: add function view browser skeleton Jiebin Sun
2026-08-03  3:55   ` sashiko-bot
2026-08-03  3:52 ` [PATCH v6 3/9] perf c2c: add column rendering for function view Jiebin Sun
2026-08-03  3:52 ` [PATCH v6 4/9] perf c2c: add HPP list parsing for function view columns Jiebin Sun
2026-08-03  3:52 ` [PATCH v6 5/9] perf c2c: add function view stats merge and memory management Jiebin Sun
2026-08-03  4:01   ` sashiko-bot
2026-08-03  3:52 ` [PATCH v6 6/9] perf c2c: add function view hierarchy entry creation Jiebin Sun
2026-08-03  3:52 ` [PATCH v6 7/9] perf c2c: build and finalize the function view hierarchy Jiebin Sun
2026-08-03  3:52 ` [PATCH v6 8/9] perf c2c: add function view browser UI and cacheline detail Jiebin Sun
2026-08-03  3:52 ` [PATCH v6 9/9] perf c2c: document function view in perf-c2c man page Jiebin Sun
2026-08-04 17:15 ` [PATCH v6 0/9] perf c2c: add a function view Namhyung Kim
2026-08-05  6:12   ` Jiebin Sun
2026-08-05 18:19 ` Namhyung Kim
2026-08-06  7:47   ` Jiebin Sun [this message]
2026-08-07  6:19     ` Namhyung Kim
2026-08-10  5:34       ` Jiebin Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260806074710.2847155-1-jiebin.sun@intel.com \
    --to=jiebin.sun@intel.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=dapeng1.mi@linux.intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=thomas.falcon@intel.com \
    --cc=tianyou.li@intel.com \
    --cc=wangyang.guo@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.