Re: [PATCH v6 16/17] ARM: dts: microchip: sama7d65: add temperature sensor

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `thermal_sensor` node is added without a corresponding `thermal-zones` configuration, which will cause the generic ADC thermal driver to unconditionally fail to probe during boot.
--

--- Patch [16]: [PATCH v6 16/17] ARM: dts: microchip: sama7d65: add temperature sensor ---
commit 41e2fca5a3bc8d28e5d129ae6b0f55b6f1c9d640
Author: Varshini Rajendran <varshini.rajendran@microchip.com>

ARM: dts: microchip: sama7d65: add temperature sensor

This commit adds the generic-adc-thermal temperature sensor node for
the SAMA7D65.

> diff --git a/arch/arm/boot/dts/microchip/sama7d65.dtsi b/arch/arm/boot/dts/microchip/sama7d65.dtsi
> index a8b18ad0ef7f7..3aba73983c79a 100644
> --- a/arch/arm/boot/dts/microchip/sama7d65.dtsi
> +++ b/arch/arm/boot/dts/microchip/sama7d65.dtsi
> @@ -119,6 +119,13 @@ pmu {
>  		interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>;
>  	};
>  
> +	thermal_sensor: thermal-sensor {
> +		compatible = "generic-adc-thermal";
> +		#thermal-sensor-cells = <0>;
> +		io-channels = <&adc AT91_SAMA7G5_ADC_TEMP_CHANNEL>;
> +		io-channel-names = "sensor-channel";
> +	};
> +

[Severity: Medium]
Will this sensor fail to probe at boot due to a missing thermal zone
configuration?

During initialization, the generic-adc-thermal driver requires the sensor to
be bound to a thermal zone. It calls devm_thermal_of_zone_register() to scan
the device tree for a thermal-zones node that references this sensor.

Because neither sama7d65.dtsi nor its encompassing board files define a
thermal-zones block, devm_thermal_of_zone_register() evaluates to -ENODEV.
This error propagates to the driver's probe function (gadc_thermal_probe),
which emits a failure message and aborts the probe entirely.

Could a corresponding thermal-zones node be added to prevent this regression?

>  	soc {
>  		compatible = "simple-bus";
>  		ranges;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260806074024.531259-1-varshini.rajendran@microchip.com?part=16