From: Tian Yuchen <cat@malon.dev>
To: git@vger.kernel.org
Cc: Tian Yuchen <cat@malon.dev>,
Christian Couder <christian.couder@gmail.com>,
Ayush Chandekar <ayu.chandekar@gmail.com>,
Olamide Caleb Bello <belkid98@gmail.com>
Subject: [PATCH v2 1/3] environment: simplify repository config getters
Date: Thu, 6 Aug 2026 17:25:55 +0800 [thread overview]
Message-ID: <20260806092557.3951208-2-cat@malon.dev> (raw)
In-Reply-To: <20260806092557.3951208-1-cat@malon.dev>
Drop unnecessary parentheses and NULL checks in repository config
getters.
These getters are only used with non-NULL repositories, so the
extra checks do not match their current callers.
Mentored-by: Christian Couder <christian.couder@gmail.com>
Mentored-by: Ayush Chandekar <ayu.chandekar@gmail.com>
Mentored-by: Olamide Caleb Bello <belkid98@gmail.com>
Signed-off-by: Tian Yuchen <cat@malon.dev>
---
environment.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/environment.c b/environment.c
index 76ee65e62b..f5628b6758 100644
--- a/environment.c
+++ b/environment.c
@@ -119,23 +119,23 @@ int is_bare_repository(struct repository *repo)
int repo_protect_ntfs(struct repository *repo)
{
- return (repo && repo->initialized) ?
- repo_config_values(repo)->protect_ntfs :
- PROTECT_NTFS_DEFAULT;
+ return repo->initialized
+ ? repo_config_values(repo)->protect_ntfs
+ : PROTECT_NTFS_DEFAULT;
}
int repo_protect_hfs(struct repository *repo)
{
- return (repo && repo->initialized) ?
- repo_config_values(repo)->protect_hfs :
- PROTECT_HFS_DEFAULT;
+ return repo->initialized
+ ? repo_config_values(repo)->protect_hfs
+ : PROTECT_HFS_DEFAULT;
}
int repo_ignore_case(struct repository *repo)
{
- return (repo && repo->initialized) ?
- repo_config_values(repo)->ignore_case :
- 0;
+ return repo->initialized
+ ? repo_config_values(repo)->ignore_case
+ : 0;
}
int repo_trust_executable_bit(struct repository *repo)
--
2.43.0
next prev parent reply other threads:[~2026-08-06 9:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 11:53 [PATCH 0/3] environment: clean up repository config handling Tian Yuchen
2026-08-05 11:53 ` [PATCH 1/3] environment: simplify repository config getters Tian Yuchen
2026-08-05 21:49 ` Junio C Hamano
2026-08-05 11:53 ` [PATCH 2/3] environment: clarify repository config getter documentation Tian Yuchen
2026-08-05 21:38 ` Junio C Hamano
2026-08-06 8:49 ` Tian Yuchen
2026-08-05 11:53 ` [PATCH 3/3] environment: reorder variables in repo_config_values structure Tian Yuchen
2026-08-05 21:47 ` Junio C Hamano
2026-08-06 8:44 ` Tian Yuchen
2026-08-06 16:42 ` Junio C Hamano
2026-08-07 8:26 ` Tian Yuchen
2026-08-06 9:25 ` [PATCH v2 0/3] environment: clean up repository config handling Tian Yuchen
2026-08-06 9:25 ` Tian Yuchen [this message]
2026-08-06 16:50 ` [PATCH v2 1/3] environment: simplify repository config getters Junio C Hamano
2026-08-07 8:30 ` Tian Yuchen
2026-08-06 9:25 ` [PATCH v2 2/3] environment: clarify repository config getter documentation Tian Yuchen
2026-08-06 16:54 ` Junio C Hamano
2026-08-06 9:25 ` [PATCH v2 3/3] environment: remove inaccurate repo_config_values comments Tian Yuchen
2026-08-07 8:59 ` [PATCH v3 0/3] environment: clean up repository config handling Tian Yuchen
2026-08-07 8:59 ` [PATCH v3 1/3] environment: drop redundant NULL checks in config getters Tian Yuchen
2026-08-07 8:59 ` [PATCH v3 2/3] environment: clarify repository config getter documentation Tian Yuchen
2026-08-07 8:59 ` [PATCH v3 3/3] environment: remove inaccurate repo_config_values comments Tian Yuchen
2026-08-07 11:04 ` [PATCH v3 0/3] environment: clean up repository config handling Patrick Steinhardt
2026-08-07 21:11 ` Junio C Hamano
2026-08-10 5:50 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260806092557.3951208-2-cat@malon.dev \
--to=cat@malon.dev \
--cc=ayu.chandekar@gmail.com \
--cc=belkid98@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.