From: kernel test robot <lkp@intel.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: oe-kbuild-all@lists.linux.dev, Bjorn Andersson <andersson@kernel.org>
Subject: [linux-next:master 9585/13093] drivers/soc/qcom/smem_dramc.c:235:87: sparse: sparse: restricted __le32 degrades to integer
Date: Thu, 06 Aug 2026 15:40:35 +0800 [thread overview]
Message-ID: <202608061531.vrPqyyLQ-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 1701fda2f58e345c050f4309971bdc07cd6146ba
commit: 1d234eeafc56af8c9af6eee857f41a4310615e78 [9585/13093] soc: qcom: smem: Expose DDR data from SMEM
config: m68k-randconfig-r131-20260806 (https://download.01.org/0day-ci/archive/20260806/202608061531.vrPqyyLQ-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 8.5.0
sparse: v0.6.5-rc1
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260806/202608061531.vrPqyyLQ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202608061531.vrPqyyLQ-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> drivers/soc/qcom/smem_dramc.c:235:87: sparse: sparse: restricted __le32 degrades to integer
>> drivers/soc/qcom/smem_dramc.c:385:19: sparse: sparse: unsigned value that used to be signed checked against zero?
drivers/soc/qcom/smem_dramc.c:384:45: sparse: signed value source
vim +235 drivers/soc/qcom/smem_dramc.c
226
227 static void smem_dram_parse_v3_14freqs_data(struct smem_dram *dram, void *data)
228 {
229 struct ddr_details_v3_14freqs *details = data;
230
231 for (int i = 0; i < MAX_DDR_FREQ_NUM_V3 + 1; i++) {
232 struct ddr_freq_table *freq_entry = &details->ddr_freq_tbl.ddr_freq[i];
233
234 if (freq_entry->freq_khz && freq_entry->enabled)
> 235 dram->frequencies[dram->num_frequencies++] = 1000 * freq_entry->freq_khz;
236 }
237 }
238
239 static void smem_dram_parse_v4_data(struct smem_dram *dram, void *data)
240 {
241 struct ddr_details_v4 *details = data;
242
243 /* Rank 0 channel 0 entry holds the correct value */
244 dram->hbb = details->highest_bank_addr_bit[0][0];
245
246 for (int i = 0; i < MAX_DDR_FREQ_NUM_V3; i++) {
247 struct ddr_freq_table *freq_entry = &details->ddr_freq_tbl.ddr_freq[i];
248
249 if (freq_entry->freq_khz && freq_entry->enabled) {
250 u32 freq_khz = le32_to_cpu(freq_entry->freq_khz);
251 dram->frequencies[dram->num_frequencies++] = 1000 * freq_khz;
252 }
253 }
254 }
255
256 static void smem_dram_parse_v5_data(struct smem_dram *dram, void *data)
257 {
258 struct ddr_details_v5 *details = data;
259 struct ddr_regions_v5 *region = &details->ddr_regions;
260
261 dram->hbb = le32_to_cpu(region[0].highest_bank_addr_bit);
262
263 for (int i = 0; i < MAX_DDR_FREQ_NUM_V5; i++) {
264 struct ddr_freq_table *freq_entry = &details->ddr_freq_tbl.ddr_freq[i];
265
266 if (freq_entry->freq_khz && freq_entry->enabled) {
267 u32 freq_khz = le32_to_cpu(freq_entry->freq_khz);
268 dram->frequencies[dram->num_frequencies++] = 1000 * freq_khz;
269 }
270 }
271 }
272
273 static void smem_dram_parse_v7_data(struct smem_dram *dram, void *data)
274 {
275 struct ddr_details_v7 *details = data;
276 struct ddr_regions_v5 *region = &details->ddr_regions;
277
278 dram->hbb = le32_to_cpu(region[0].highest_bank_addr_bit);
279
280 for (int i = 0; i < MAX_DDR_FREQ_NUM_V5; i++) {
281 struct ddr_freq_table *freq_entry = &details->ddr_freq_tbl.ddr_freq[i];
282
283 if (freq_entry->freq_khz && freq_entry->enabled) {
284 u32 freq_khz = le32_to_cpu(freq_entry->freq_khz);
285 dram->frequencies[dram->num_frequencies++] = 1000 * freq_khz;
286 }
287 }
288 }
289
290 /* The structure contains no version field, so we have to perform some guesswork.. */
291 static int smem_dram_infer_struct_version(size_t size)
292 {
293 /* Some early versions provided less bytes of less useful data */
294 if (size < sizeof(struct ddr_details_v3))
295 return -EINVAL;
296
297 if (size == sizeof(struct ddr_details_v3))
298 return INFO_V3;
299
300 if (size == sizeof(struct ddr_details_v3_14freqs))
301 return INFO_V3_WITH_14_FREQS;
302
303 if (size == sizeof(struct ddr_details_v4))
304 return INFO_V4;
305
306 if (size == sizeof(struct ddr_details_v5) +
307 4 * sizeof(struct ddr_region_v5))
308 return INFO_V5;
309
310 if (size == sizeof(struct ddr_details_v5) +
311 4 * sizeof(struct ddr_region_v5) +
312 sizeof(struct ddr_xbl2quantum_smem_data) +
313 sizeof(struct shub_freq_plan_entry))
314 return INFO_V5;
315
316 if (size == sizeof(struct ddr_details_v5) +
317 6 * sizeof(struct ddr_region_v5))
318 return INFO_V5_WITH_6_REGIONS;
319
320 if (size == sizeof(struct ddr_details_v5) +
321 6 * sizeof(struct ddr_region_v5) +
322 sizeof(struct ddr_xbl2quantum_smem_data) +
323 sizeof(struct shub_freq_plan_entry))
324 return INFO_V5_WITH_6_REGIONS;
325
326 if (size == sizeof(struct ddr_details_v5) +
327 6 * sizeof(struct ddr_region_v5) +
328 sizeof(struct ddr_misc_info_v6) +
329 sizeof(struct shub_freq_plan_entry))
330 return INFO_V6;
331
332 if (size == sizeof(struct ddr_details_v7) +
333 4 * sizeof(struct ddr_region_v5) +
334 sizeof(struct ddr_misc_info_v6) +
335 sizeof(struct shub_freq_plan_entry))
336 return INFO_V7;
337
338 if (size == sizeof(struct ddr_details_v7) +
339 6 * sizeof(struct ddr_region_v5) +
340 sizeof(struct ddr_misc_info_v6) +
341 sizeof(struct shub_freq_plan_entry))
342 return INFO_V7_WITH_6_REGIONS;
343
344 return INFO_UNKNOWN;
345 }
346
347 static int smem_dram_frequencies_show(struct seq_file *s, void *unused)
348 {
349 struct smem_dram *dram = s->private;
350
351 for (int i = 0; i < dram->num_frequencies; i++)
352 seq_printf(s, "%lu\n", dram->frequencies[i]);
353
354 return 0;
355 }
356 DEFINE_SHOW_ATTRIBUTE(smem_dram_frequencies);
357
358 static int smem_hbb_show(struct seq_file *s, void *unused)
359 {
360 struct smem_dram *dram = s->private;
361
362 if (!dram->hbb)
363 return -EINVAL;
364
365 seq_printf(s, "%d\n", dram->hbb);
366
367 return 0;
368 }
369 DEFINE_SHOW_ATTRIBUTE(smem_hbb);
370
371 struct dentry *smem_dram_parse(struct qcom_smem *smem, struct device *dev)
372 {
373 struct dentry *debugfs_dir;
374 enum ddr_info_version ver;
375 struct smem_dram *dram;
376 size_t actual_size;
377 void *data;
378
379 /* No need to check qcom_smem_is_available(), this func is called by the SMEM driver */
380 data = __qcom_smem_get(smem, QCOM_SMEM_HOST_ANY, SMEM_DDR_INFO_ID, &actual_size);
381 if (IS_ERR_OR_NULL(data))
382 return ERR_PTR(-ENODATA);
383
384 ver = smem_dram_infer_struct_version(actual_size);
> 385 if (ver < 0) {
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2026-08-06 7:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202608061531.vrPqyyLQ-lkp@intel.com \
--to=lkp@intel.com \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.