From: Dinh Nguyen <dinguyen@kernel.org>
To: bp@alien8.de, tony.luck@intel.com
Cc: dinguyen@kernel.org, rounakdas2025@gmail.com,
niravkumar.l.rabara@altera.com, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/1] EDAC/altera: Guard against NULL of_node
Date: Thu, 6 Aug 2026 11:10:54 -0500 [thread overview]
Message-ID: <20260806161055.1520446-1-dinguyen@kernel.org> (raw)
Hi EDAC maintainers,
I wanted to explain the reason why I think this patch doesn't need a
Fixes tag. The way the Altera EDAC is written there are many instances
of the driver referencing the of_node, which is why they are flagged in
many sashiko reviews.
This patch checks for those NULL of_node in the probe functions using
dev_of_node() so we don't have to guard the of_node in all the other
functions.
The reason we don't need the Fixes tag is because this system is
supposed to run with CONFIG_OF enabled. The system would fail way
before it gets to this driver if an of_node is not found. Thus I don't
see a need for a Fixes tag but the guard should be in place for
completeness.
Thanks,
Dinh Nguyen (1):
EDAC/altera: Guard against NULL of_node pointer dereference
drivers/edac/altera_edac.c | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
--
2.42.0.411.g813d9a9188
next reply other threads:[~2026-08-06 16:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 16:10 Dinh Nguyen [this message]
2026-08-06 16:10 ` [PATCH 1/1] EDAC/altera: Guard against NULL of_node pointer dereference Dinh Nguyen
2026-08-06 18:16 ` [PATCH 0/1] EDAC/altera: Guard against NULL of_node Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260806161055.1520446-1-dinguyen@kernel.org \
--to=dinguyen@kernel.org \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=niravkumar.l.rabara@altera.com \
--cc=rounakdas2025@gmail.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.