From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56A43C5AC67 for ; Fri, 7 Aug 2026 02:45:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D786D10E30F; Fri, 7 Aug 2026 02:45:49 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="hdJifLS/"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0AD0F10E2E5; Fri, 7 Aug 2026 02:45:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1786070749; x=1817606749; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=vd+RFUd9IzYz4uUS7+1DDdo64Zbn66/EnYIoVbYg060=; b=hdJifLS/dpGK9mwLliE8hJ8mUpnxd0DEsamjnaBsrarOVgvJr2Umxuxf v2AnfdccKlpxp8ZloybS1Ud3xAgo4y0S4AoUwBrZ+gbvo2jDW3dGchURW VEqUnwJ9h7Sl4BwgUDCYeohCpbjA/XxnSBSykqsxW6LlfSq0ficGyDwk3 NPqC4Q8S7NQKTAuFbI8JqPqwj5XfQYKsf8o9FPRGI6w52JfLOcpU00qx/ EHoBmCr+xZlEANwPzegkToq+HEMhXGtgKG/XanSU+tmBzgJDPhgRbKKKN +LWbsezM22ai5ARxrapaXbjpXzwmGhOR/mhLIagP5fXP6vzHY1sxDfx+l A==; X-CSE-ConnectionGUID: JBAUtUUoR5mMr4D8/XDDaA== X-CSE-MsgGUID: qcUimYXbTLGtbHUakU5vcA== X-IronPort-AV: E=McAfee;i="6800,10657,11867"; a="109468370" X-IronPort-AV: E=Sophos;i="6.25,209,1779174000"; d="scan'208";a="109468370" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Aug 2026 19:45:48 -0700 X-CSE-ConnectionGUID: 2gTfiBloRmGq52oDIKHeDQ== X-CSE-MsgGUID: uZdvgqyGQbmwIhkj3UaWtw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,209,1779174000"; d="scan'208";a="265748483" Received: from kandpal-x299-ud4-pro.iind.intel.com ([10.190.239.10]) by orviesa003.jf.intel.com with ESMTP; 06 Aug 2026 19:45:47 -0700 From: Suraj Kandpal To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: ankit.k.nautiyal@intel.com, jani.nikula@intel.com, chaitanya.kumar.borah@intel.com, Suraj Kandpal Subject: [PATCH v3] drm/i915/dp: Use array size for intersect_rates() bound Date: Fri, 7 Aug 2026 08:15:40 +0530 Message-Id: <20260807024539.1579080-1-suraj.kandpal@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260804105549.1435154-1-suraj.kandpal@intel.com> References: <20260804105549.1435154-1-suraj.kandpal@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Take an explicit common_len parameter and pass ARRAY_SIZE(intel_dp->common_rates) at the call site, so the bound is tied to the destination array. Signed-off-by: Suraj Kandpal --- v1 -> v2: -Use latest baseline (Jani) v2 -> v3: -Remove fixes tag (Chaitanya) drivers/gpu/drm/i915/display/intel_dp.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 437b9e7bb864..157ed9b86e5b 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -625,13 +625,13 @@ intel_dp_set_source_rates(struct intel_dp *intel_dp) static int intersect_rates(const int *source_rates, int source_len, const int *sink_rates, int sink_len, - int *common_rates) + int *common_rates, int common_len) { int i = 0, j = 0, k = 0; while (i < source_len && j < sink_len) { if (source_rates[i] == sink_rates[j]) { - if (WARN_ON(k >= DP_MAX_SUPPORTED_RATES)) + if (WARN_ON(k >= common_len)) return k; common_rates[k] = source_rates[i]; ++k; @@ -660,6 +660,7 @@ int intel_dp_rate_index(const int *rates, int len, int rate) static void intel_dp_get_common_rates(struct intel_dp *intel_dp, int common_rates[DP_MAX_SUPPORTED_RATES], + int common_len, int *num_common_rates) { struct intel_display *display = to_intel_display(intel_dp); @@ -671,7 +672,8 @@ static void intel_dp_get_common_rates(struct intel_dp *intel_dp, intel_dp->num_source_rates, intel_dp->sink_rates, intel_dp->num_sink_rates, - common_rates); + common_rates, + common_len); /* Paranoia, there should always be something in common. */ if (drm_WARN_ON(display->drm, *num_common_rates == 0)) { @@ -687,7 +689,8 @@ static bool intel_dp_set_common_link_params(struct intel_dp *intel_dp) int common_rates[DP_MAX_SUPPORTED_RATES]; bool params_changed = false; - intel_dp_get_common_rates(intel_dp, common_rates, &num_common_rates); + intel_dp_get_common_rates(intel_dp, common_rates, ARRAY_SIZE(common_rates), + &num_common_rates); if (intel_dp_link_caps_update(intel_dp->link.caps, common_rates, num_common_rates, intel_dp_get_max_common_lane_count(intel_dp), -- 2.34.1