From: Sairaj Kodilkar <sarunkod@amd.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
Alejandro Jimenez <alejandro.j.jimenez@oracle.com>,
Ani Sinha <anisinha@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
Sairaj Kodilkar <sarunkod@amd.com>, <qemu-devel@nongnu.org>
Cc: <vasant.hegde@amd.com>, <suravee.suthikulpanit@amd.com>
Subject: [PATCH v2 6/7] amd_iommu: acpi-build: Remove unsupported PPR and HE feature
Date: Fri, 7 Aug 2026 11:42:49 +0530 [thread overview]
Message-ID: <20260807061250.27739-7-sarunkod@amd.com> (raw)
In-Reply-To: <20260807061250.27739-1-sarunkod@amd.com>
AMD IOMMU does not support ppr and hardware error registers. Hence do not
publish these features to guest through extended feature MMIO register
and IVHD 10h flags field.
Signed-off-by: Sairaj Kodilkar <sarunkod@amd.com>
---
hw/i386/acpi-build.c | 3 +--
hw/i386/amd_iommu.h | 5 ++---
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 656a693e661f..749a1fe0d27e 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -1935,8 +1935,7 @@ build_amd_iommu(GArray *table_data, BIOSLinker *linker, const char *oem_id,
build_append_int_noprefix(table_data,
(1UL << 0) | /* HtTunEn */
(1UL << 4) | /* iotblSup */
- (1UL << 6) | /* PrefSup */
- (1UL << 7), /* PPRSup */
+ (1UL << 6), /* PrefSup */
1);
/* IVHD length */
diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h
index 319db1861820..c5b346cc356c 100644
--- a/hw/i386/amd_iommu.h
+++ b/hw/i386/amd_iommu.h
@@ -227,9 +227,8 @@
/* default extended feature */
#define AMDVI_DEFAULT_EXT_FEATURES \
- (AMDVI_FEATURE_PREFETCH | AMDVI_FEATURE_PPR | \
- AMDVI_FEATURE_IA | AMDVI_FEATURE_GT | AMDVI_FEATURE_HE | \
- AMDVI_GATS_MODE | AMDVI_HATS_MODE | AMDVI_FEATURE_GA)
+ (AMDVI_FEATURE_PREFETCH | AMDVI_FEATURE_IA | AMDVI_FEATURE_GT | \
+ AMDVI_GATS_MODE | AMDVI_HATS_MODE | AMDVI_FEATURE_GA)
/* capabilities header */
#define AMDVI_CAPAB_FEATURES (AMDVI_CAPAB_FLAT_EXT | \
--
2.34.1
next prev parent reply other threads:[~2026-08-07 6:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 6:12 [PATCH v2 0/7] acpi_build: Refactor and cleanup AMD IVRS build Sairaj Kodilkar
2026-08-07 6:12 ` [PATCH v2 1/7] amd_iommu: Return empty efr for stub call Sairaj Kodilkar
2026-08-07 6:12 ` [PATCH v2 2/7] tests/acpi: x86: Allow IVRS acpi table changes Sairaj Kodilkar
2026-08-07 6:12 ` [PATCH v2 3/7] amd_iommu: acpi-build: update PA, GVA and VA size macros Sairaj Kodilkar
2026-08-07 6:12 ` [PATCH v2 4/7] acpi_build: Use IOMMU pci device to build IOMMU DeviceID Sairaj Kodilkar
2026-08-07 6:12 ` [PATCH v2 5/7] acpi_build: Build IVRS feature report using extended feature register Sairaj Kodilkar
2026-08-07 6:12 ` Sairaj Kodilkar [this message]
2026-08-07 6:12 ` [PATCH v2 7/7] tests/acpi: x86: update golden masters for IVRS Sairaj Kodilkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260807061250.27739-7-sarunkod@amd.com \
--to=sarunkod@amd.com \
--cc=alejandro.j.jimenez@oracle.com \
--cc=anisinha@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=vasant.hegde@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.