All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boqun Feng <boqun@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Ingo Molnar" <mingo@kernel.org>, "Will Deacon" <will@kernel.org>,
	"Boqun Feng" <boqun@kernel.org>,
	"Waiman Long" <longman@redhat.com>, "Gary Guo" <gary@garyguo.net>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Lyude Paul" <lyude@redhat.com>,
	"Daniel Almeida" <daniel.almeida@collabora.com>,
	"Onur Özkan" <work@onurozkan.dev>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Danilo Krummrich" <dakr@kernel.org>,
	linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
	"Shrikanth Hegde" <sshegde@linux.ibm.com>,
	"Madhavan Srinivasan" <maddy@linux.ibm.com>,
	"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>
Subject: [PATCH v5 06/18] irq: Add KUnit test for refcounted interrupt enable/disable
Date: Fri,  7 Aug 2026 00:02:03 -0700	[thread overview]
Message-ID: <20260807070218.27144-7-boqun@kernel.org> (raw)
In-Reply-To: <20260807070218.27144-1-boqun@kernel.org>

From: Lyude Paul <lyude@redhat.com>

While making changes to the refcounted interrupt patch series, at some
point on my local branch I broke something and ended up writing some kunit
tests for testing refcounted interrupts as a result. So, let's include
these tests now that we have refcounted interrupts.

Signed-off-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Boqun Feng <boqun@kernel.org>
---
 kernel/irq/Makefile                  |   1 +
 kernel/irq/refcount_interrupt_test.c | 109 +++++++++++++++++++++++++++
 2 files changed, 110 insertions(+)
 create mode 100644 kernel/irq/refcount_interrupt_test.c

diff --git a/kernel/irq/Makefile b/kernel/irq/Makefile
index 86a2e5ae08f9..44c4d6fc502a 100644
--- a/kernel/irq/Makefile
+++ b/kernel/irq/Makefile
@@ -16,3 +16,4 @@ obj-$(CONFIG_SMP) += affinity.o
 obj-$(CONFIG_GENERIC_IRQ_DEBUGFS) += debugfs.o
 obj-$(CONFIG_GENERIC_IRQ_MATRIX_ALLOCATOR) += matrix.o
 obj-$(CONFIG_IRQ_KUNIT_TEST) += irq_test.o
+obj-$(CONFIG_KUNIT) += refcount_interrupt_test.o
diff --git a/kernel/irq/refcount_interrupt_test.c b/kernel/irq/refcount_interrupt_test.c
new file mode 100644
index 000000000000..ca904dba24b9
--- /dev/null
+++ b/kernel/irq/refcount_interrupt_test.c
@@ -0,0 +1,109 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * KUnit test for refcounted interrupt enable/disables.
+ */
+
+#include <kunit/test.h>
+#include <linux/interrupt_rc.h>
+
+#define TEST_IRQ_ON() KUNIT_EXPECT_FALSE(test, irqs_disabled())
+#define TEST_IRQ_OFF() KUNIT_EXPECT_TRUE(test, irqs_disabled())
+
+/* ===== Test cases ===== */
+static void test_single_irq_change(struct kunit *test)
+{
+	local_interrupt_disable();
+	TEST_IRQ_OFF();
+	local_interrupt_enable();
+}
+
+static void test_nested_irq_change(struct kunit *test)
+{
+	local_interrupt_disable();
+	TEST_IRQ_OFF();
+	local_interrupt_disable();
+	TEST_IRQ_OFF();
+	local_interrupt_disable();
+	TEST_IRQ_OFF();
+
+	local_interrupt_enable();
+	TEST_IRQ_OFF();
+	local_interrupt_enable();
+	TEST_IRQ_OFF();
+	local_interrupt_enable();
+	TEST_IRQ_ON();
+}
+
+static void test_multiple_irq_change(struct kunit *test)
+{
+	local_interrupt_disable();
+	TEST_IRQ_OFF();
+	local_interrupt_disable();
+	TEST_IRQ_OFF();
+
+	local_interrupt_enable();
+	TEST_IRQ_OFF();
+	local_interrupt_enable();
+	TEST_IRQ_ON();
+
+	local_interrupt_disable();
+	TEST_IRQ_OFF();
+	local_interrupt_enable();
+	TEST_IRQ_ON();
+}
+
+static void test_irq_save(struct kunit *test)
+{
+	unsigned long flags;
+
+	local_irq_save(flags);
+	TEST_IRQ_OFF();
+	local_interrupt_disable();
+	TEST_IRQ_OFF();
+	local_interrupt_enable();
+	TEST_IRQ_OFF();
+	local_irq_restore(flags);
+	TEST_IRQ_ON();
+
+	local_interrupt_disable();
+	TEST_IRQ_OFF();
+	local_irq_save(flags);
+	TEST_IRQ_OFF();
+	local_irq_restore(flags);
+	TEST_IRQ_OFF();
+	local_interrupt_enable();
+	TEST_IRQ_ON();
+}
+
+static struct kunit_case test_cases[] = {
+	KUNIT_CASE(test_single_irq_change),
+	KUNIT_CASE(test_nested_irq_change),
+	KUNIT_CASE(test_multiple_irq_change),
+	KUNIT_CASE(test_irq_save),
+	{},
+};
+
+/* init and exit are the same. */
+static int test_init(struct kunit *test)
+{
+	TEST_IRQ_ON();
+
+	return 0;
+}
+
+static void test_exit(struct kunit *test)
+{
+	TEST_IRQ_ON();
+}
+
+static struct kunit_suite refcount_interrupt_test_suite = {
+	.name = "refcount_interrupt",
+	.test_cases = test_cases,
+	.init = test_init,
+	.exit = test_exit,
+};
+
+kunit_test_suite(refcount_interrupt_test_suite);
+MODULE_AUTHOR("Lyude Paul <lyude@redhat.com>");
+MODULE_DESCRIPTION("Refcounted interrupt unit test suite");
+MODULE_LICENSE("GPL");
-- 
2.50.1 (Apple Git-155)


  parent reply	other threads:[~2026-08-07  7:02 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-07  7:01 [PATCH v5 00/18] Refcounted interrupt disable and SpinLockIrq for Rust Boqun Feng
2026-08-07  7:01 ` [PATCH v5 01/18] preempt: Track NMI nesting to separate per-CPU counter Boqun Feng
2026-08-07  7:01 ` [PATCH v5 02/18] preempt: Introduce HARDIRQ_DISABLE_BITS Boqun Feng
2026-08-07  7:02 ` [PATCH v5 03/18] preempt: Introduce __preempt_count_{sub,add}_return() Boqun Feng
2026-08-07  7:02 ` [PATCH v5 04/18] openrisc: Include <linux/cpumask.h> in smp.h Boqun Feng
2026-08-07  7:02 ` [PATCH v5 05/18] irq & spin_lock: Add counted interrupt disabling/enabling Boqun Feng
2026-08-07  7:02 ` Boqun Feng [this message]
2026-08-07  7:02 ` [PATCH v5 07/18] irq: Add max local_interrupt_disable() nesting level kunit test case Boqun Feng
2026-08-07  7:02 ` [PATCH v5 08/18] locking: Switch to _irq_{disable,enable}() variants in cleanup guards Boqun Feng
2026-08-07  7:02 ` [PATCH v5 09/18] sched: Remove the unused preempt_offset parameter of __cant_sleep() Boqun Feng
2026-08-07  7:02 ` [PATCH v5 10/18] sched: Avoid signed comparison of preempt_count() in __cant_migrate() Boqun Feng
2026-08-07  7:02 ` [PATCH v5 11/18] preempt: Introduce HAS_SEPARATE_PREEMPT_RESCHED_BITS Boqun Feng
2026-08-07  7:02 ` [PATCH v5 12/18] arm64: sched/preempt: Enable HAS_SEPARATE_PREEMPT_RESCHED_BITS Boqun Feng
2026-08-07  7:02 ` [PATCH v5 13/18] s390/preempt: " Boqun Feng
2026-08-07  7:02 ` [PATCH v5 14/18] rust: Introduce interrupt module Boqun Feng
2026-08-10  8:57   ` Peter Zijlstra
2026-08-10 13:28     ` Boqun Feng
2026-08-07  7:02 ` [PATCH v5 15/18] rust: helper: Add spin_{un,}lock_irq_{enable,disable}() helpers Boqun Feng
2026-08-07  7:02 ` [PATCH v5 16/18] rust: sync: Use super::* in spinlock.rs Boqun Feng
2026-08-07  7:02 ` [PATCH v5 17/18] rust: sync: Add SpinLockIrq Boqun Feng
2026-08-10  9:02   ` Peter Zijlstra
2026-08-10 13:21     ` Boqun Feng
2026-08-07  7:02 ` [PATCH v5 18/18] rust: sync: Introduce SpinLockIrq::lock_with() and friends Boqun Feng
2026-08-10  8:52 ` [PATCH v5 00/18] Refcounted interrupt disable and SpinLockIrq for Rust Peter Zijlstra
2026-08-10  8:53   ` Peter Zijlstra
2026-08-10  9:30     ` Peter Zijlstra
2026-08-10 10:38       ` Gary Guo
2026-08-10 10:49         ` Peter Zijlstra
2026-08-11  4:17   ` [PATCH 0/4] Improvements on SpinLockIrq patch series Boqun Feng
2026-08-11  4:17     ` [PATCH 1/4] irq: Add {over,under}flow detection for local_interrupt_{enable,disable} Boqun Feng
2026-08-11  4:17     ` [PATCH 2/4] selftests/bpf: Use the new NMI_BITS definition Boqun Feng
2026-08-11  4:17     ` [PATCH 3/4] irq: Explain better on NMI_MASK overflow condition Boqun Feng
2026-08-11  4:17     ` [PATCH 4/4] irq: Add max local_interrupt_disable() nesting level kunit test case Boqun Feng
2026-08-11 10:09     ` [PATCH 0/4] Improvements on SpinLockIrq patch series Shrikanth Hegde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260807070218.27144-7-boqun@kernel.org \
    --to=boqun@kernel.org \
    --cc=aliceryhl@google.com \
    --cc=chleroy@kernel.org \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=lyude@redhat.com \
    --cc=maddy@linux.ibm.com \
    --cc=mingo@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=sshegde@linux.ibm.com \
    --cc=will@kernel.org \
    --cc=work@onurozkan.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.