All of lore.kernel.org
 help / color / mirror / Atom feed
From: linuxtestproject.agent@gmail.com
To: Wake Liu <wakel@google.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] inode01: Use uint64_t to prevent inode truncation on 32-bit
Date: Fri,  7 Aug 2026 11:04:12 +0000	[thread overview]
Message-ID: <20260807110412.3995-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260807105634.2837348-1-wakel@google.com>

Hi Wake,

On Fri, 07 Aug 2026, Wake Liu wrote:
> inode01: Use uint64_t to prevent inode truncation on 32-bit

> struct inode_info {
> -	ino_t ino;
> +	uint64_t ino;
> 	char path[PATH_MAX];
> };
>
> static void record_inode(struct inode_info *inodes, unsigned int idx,
> 			 const char *path, ino_t ino)

Could the record_inode() parameter also be changed to uint64_t? Every inode
collected by verify_tree() passes through this parameter, so on the 32-bit
ABI described in the commit message the value is still truncated before it
is assigned to the new uint64_t field.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2026-08-07 11:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-07 10:56 [LTP] [PATCH] inode01: Use uint64_t to prevent inode truncation on 32-bit Wake Liu via ltp
2026-08-07 11:04 ` linuxtestproject.agent [this message]
2026-08-07 23:17 ` [LTP] [PATCH v2] " Wake Liu via ltp
2026-08-07 23:36   ` [LTP] " linuxtestproject.agent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260807110412.3995-1-linuxtestproject.agent@gmail.com \
    --to=linuxtestproject.agent@gmail.com \
    --cc=ltp@lists.linux.it \
    --cc=wakel@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.