From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: "Nuno Sá" <nuno.sa@analog.com>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
linux-iio@vger.kernel.org, linux@analog.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] iio: adc: ade9000: request interrupts after powering the device
Date: Fri, 7 Aug 2026 12:37:42 +0200 [thread overview]
Message-ID: <20260807123742.00006d8e@gmail.com> (raw)
In-Reply-To: <20260807085643.5502-2-antoniu.miclaus@analog.com>
On Fri, 7 Aug 2026 11:56:41 +0300
Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:
> The IRQ handlers do SPI register accesses, but the interrupts were
> requested before the vdd regulator was enabled. An interrupt arriving
> while the chip is unpowered runs a handler against a dead chip, causing
> SPI errors or garbage reads.
>
> Request the interrupts after enabling the regulator. This keeps irq1
> registered before ade9000_reset(), which waits on it, and lets devm free
> the interrupts before the regulator is disabled.
>
> Fixes: 81de7b4619fc ("iio: adc: add ade9000 support")
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
LGTM.
Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
--
Kind regards,
Joshua Crofts
next prev parent reply other threads:[~2026-08-07 10:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 8:56 [PATCH 0/3] iio: adc: ade9000: series of probe and channel fixes Antoniu Miclaus
2026-08-07 8:56 ` [PATCH 1/3] iio: adc: ade9000: request interrupts after powering the device Antoniu Miclaus
2026-08-07 10:37 ` Joshua Crofts [this message]
2026-08-07 8:56 ` [PATCH 2/3] iio: adc: ade9000: fix overlapping scan_index for current and voltage channels Antoniu Miclaus
2026-08-07 8:56 ` [PATCH 3/3] iio: adc: ade9000: handle Phase C dip events in IRQ1 handler Antoniu Miclaus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260807123742.00006d8e@gmail.com \
--to=joshua.crofts1@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=antoniu.miclaus@analog.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@analog.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.