From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Elson Serrao <elson.serrao@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Peter Chen <peter.chen@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/9] dt-bindings: soc: qcom: eud: Add per-path child nodes for UTMI routing
Date: Fri, 7 Aug 2026 08:52:39 -0500 [thread overview]
Message-ID: <20260807135239.GA48030-robh@kernel.org> (raw)
In-Reply-To: <20260807-shrewd-white-mayfly-a8bfea@quoll>
On Fri, Aug 07, 2026 at 09:20:26AM +0200, Krzysztof Kozlowski wrote:
> On Sun, Aug 02, 2026 at 08:15:26PM -0700, Elson Serrao wrote:
> > The Qualcomm Embedded USB Debugger (EUD) can intercept one or two
> > High-Speed UTMI paths depending on the SoC. For example, SC7280 supports
> > EUD on the primary UTMI path only, while SM8350 supports EUD on both
> > primary and secondary UTMI paths.
> >
> > Each UTMI path connects an independent USB controller/connector pair and
> > forms its own role-switch domain. EUD routes traffic based on USB role.
> > In device role the debug hub is inserted, while in host role it is
> > bypassed.
> >
> > The existing binding models EUD using a flattened ports representation.
> > While sufficient for fixed device-role configurations, it cannot naturally
> > associate a controller, connector, and role switch with a specific
> > EUD-routable path. This is problematic for role-switch capable ports and
> > becomes more pronounced on SoCs with multiple paths. In such cases, each
> > path forms an independent role-switch domain and requires per-path role
> > awareness.
> >
> > Model each UTMI path as a separate child node with its own OF graph. Add
> > an SM8350 compatible for dual-path EUD topologies while retaining the
> > legacy ports representation for backward compatibility.
> >
> > Signed-off-by: Elson Serrao <elson.serrao@oss.qualcomm.com>
> > ---
> > .../bindings/soc/qcom/qcom,eud.yaml | 128 +++++++++++++++++-
> > 1 file changed, 127 insertions(+), 1 deletion(-)
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
sashiko correctly points out the oneOf logic is flawed.
next prev parent reply other threads:[~2026-08-07 13:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 3:15 [PATCH v5 0/9] Improve Qualcomm EUD driver and platform support Elson Serrao
2026-08-03 3:15 ` [PATCH v5 1/9] dt-bindings: soc: qcom: eud: Add per-path child nodes for UTMI routing Elson Serrao
2026-08-03 3:23 ` sashiko-bot
2026-08-07 7:20 ` Krzysztof Kozlowski
2026-08-07 13:52 ` Rob Herring [this message]
2026-08-10 19:23 ` Elson Serrao
2026-08-03 3:15 ` [PATCH v5 2/9] usb: misc: qcom_eud: add sysfs attribute for port selection Elson Serrao
2026-08-03 3:25 ` sashiko-bot
2026-08-03 3:15 ` [PATCH v5 3/9] usb: misc: qcom_eud: add per-path High-Speed PHY control Elson Serrao
2026-08-03 3:28 ` sashiko-bot
2026-08-03 3:15 ` [PATCH v5 4/9] usb: misc: qcom_eud: add per-path role switch support Elson Serrao
2026-08-03 3:30 ` sashiko-bot
2026-08-03 9:37 ` Peter Chen
2026-08-03 3:15 ` [PATCH v5 5/9] usb: misc: qcom_eud: improve enable_store API Elson Serrao
2026-08-03 3:25 ` sashiko-bot
2026-08-03 3:15 ` [PATCH v5 6/9] usb: misc: qcom_eud: add role-based EUD control Elson Serrao
2026-08-03 3:27 ` sashiko-bot
2026-08-03 9:50 ` Peter Chen
2026-08-03 3:15 ` [PATCH v5 7/9] usb: misc: qcom_eud: fix virtual attach/detach event handling Elson Serrao
2026-08-03 3:26 ` sashiko-bot
2026-08-03 3:15 ` [PATCH v5 8/9] arm64: dts: qcom: kodiak: Describe EUD UTMI path using child node Elson Serrao
2026-08-03 3:54 ` sashiko-bot
2026-08-07 6:31 ` Krzysztof Kozlowski
2026-08-03 3:15 ` [PATCH v5 9/9] arm64: dts: qcom: Map USB connector to EUD on Kodiak boards Elson Serrao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260807135239.GA48030-robh@kernel.org \
--to=robh@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=elson.serrao@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.