From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F709C5AC7A for ; Fri, 7 Aug 2026 14:28:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AAE5F10F506; Fri, 7 Aug 2026 14:28:41 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="dlvgansR"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1376710F506 for ; Fri, 7 Aug 2026 14:28:40 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id BD55A429DB; Fri, 7 Aug 2026 14:28:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 532871F000E9; Fri, 7 Aug 2026 14:28:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786112919; bh=mvnMQ7kxsmhsyzGe7TSEzwqf6FnQTVS/mXGaI+rDH4I=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=dlvgansRzP1CA/TuE/q4xZtGNHvkv98NA+gHT6i0RXbVXhxqYYjtfHuvs7nwZTqOx 0KZxvjzKfLIPIwsAeFKUSMeorlZYDuQv2fJD/bFdr0k+SXLPUIgVeOBi0kxOumgMUn 08+U9fZcOl2SATcZ7g6AefWCsT04YzgVs4C7m+eyApUcGiUfITUJL7FxLvlyZzVkzQ 5V/LOtSszLm/Lj6qi+ytYLSuynSk/YcuAtyr3OepcmpdrUMANOca8H9obp/6jID9to 1h6QssRmEiTQJmWdw/scPz9UPGGPoNi8kPrZzWT7o3MFrQrxiwXCGjDs2Qxqn4okGZ 79mmFAXw/sLwg== From: sashiko-bot@kernel.org Subject: Re: [PATCH 1/3] dt-bindings: display: add Chipwealth CH1115 OLED controller To: =?utf-8?b?Tmljb2zDoXMgQW50aW5vcmk=?= Cc: robh@kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, conor+dt@kernel.org In-Reply-To: References: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 07 Aug 2026 14:28:38 +0000 Message-Id: <20260807142839.532871F000E9@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] The device tree schema is structurally unsatisfiable and introdu= ces hardware-specific properties without vendor prefixes. `first-page` is m= andated by the `required` list but is not defined in the `properties` block= . Because `additionalProperties: false` is used, any device tree node inclu= ding `first-page` is rejected, while any node omitting it fails the `requir= ed` check. Additionally, `contrast` is used in the `examples` but missing f= rom `properties`. Finally, `invert`, `first-page`, and `contrast` are custo= m properties that must include a vendor prefix (e.g., `chipwealth,invert`) = to avoid polluting the global namespace. -- --- Patch [1]: [PATCH 1/3] dt-bindings: display: add Chipwealth CH1115 OLED= controller --- commit 77e215ca91e888007e7e74fb225f1cb55be392a1 Author: Nicol=C3=A1s Antinori dt-bindings: display: add Chipwealth CH1115 OLED controller This commit adds the device tree binding for the Chipwealth CH1115 monochro= me dot matrix OLED panel controller. > diff --git a/Documentation/devicetree/bindings/display/chipwealth,ch1115.= yaml b/Documentation/devicetree/bindings/display/chipwealth,ch1115.yaml > new file mode 100644 > index 0000000000000..29d55da85d219 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/chipwealth,ch1115.yaml [ ... ] > +properties: > + compatible: > + const: chipwealth,ch1115 > + > + reg: > + maxItems: 1 > + > + invert: > + type: boolean > + description: > + Display pixels are inverted, i.e. 0 is white and 1 is black. [Severity: Medium] Should this property have a vendor prefix (e.g., chipwealth,invert)? Custom hardware-specific properties typically require vendor prefixes to avoid polluting the global namespace. > + > + width-mm: true > + height-mm: true > + panel-timing: true > + > +required: > + - compatible > + - reg > + - width-mm > + - height-mm > + - panel-timing > + - first-page > + > +additionalProperties: false [Severity: Medium] Is first-page missing from the properties block? Because it is explicitly mandated by the required list but not defined in properties, additionalProperties: false will forbid it, making the schema unsatisfiable for any device tree node. > + > +examples: > + - | > + i2c { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + status =3D "okay"; > + > + display@3c { > + compatible =3D "chipwealth,ch1115"; > + reg =3D <0x3c>; > + width-mm =3D <12>; > + height-mm =3D <8>; > + contrast =3D <127>; > + first-page =3D <1>; [Severity: Medium] Are contrast and first-page intended to be defined in this schema? They are used here in the example but missing from the properties block, which will cause dt_binding_check to fail. As with invert, do these custom properties need vendor prefixes? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/cover.1786110720.gi= t.nico.antinori.7@gmail.com?part=3D1