From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0433C41D138; Fri, 7 Aug 2026 15:33:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786116821; cv=none; b=bYQimSPEDctafXrsBgvw0xsdUZ/6l6eM5IiC1/6bXBil2kqa7qYfVTFKqUGge4oXs792mNjzEWnXhEbv7omWRnzIt0V2JSx33R4POfLYCiYCnCL9BRMFmjgS2o4t9XOyTjGxuUHA1j80LOKsWrfItfae8o3uQRR2xt5cZCo6EuI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786116821; c=relaxed/simple; bh=XNOxpOsLc3oT94HvBBfbSxf3gky1HjsxwkIK6APvC0I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QWMtIzilYeLVm3TxDI9DHhmNf94Z4hvvNThrIqukDg9wJuN6ZnnKC7qr0zYlJ2einNybqjxSAG1wlqjtXF7mcIzW2EquTC856fngV/l0P76YaHdswZakM7X1LcSGVGzt9fLo4D0rs6fo+0/ryfffCuY0alb19oAu3iGjPtHabOo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=DzhizSoK; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="DzhizSoK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51DCD1F000E9; Fri, 7 Aug 2026 15:33:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1786116819; bh=YXmD0EmclnX7+YMvlLjW2suCcoyYig/su/hxp7hLeaI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=DzhizSoKJpQhC5/XKaQGrH+q04r1Wlw44HZCa8KFs9RD6P5kiSPIRklUVxHz7ef2z t+VxMGM+Jn3LIPq81HV3PaGhled1TB6zpYMQedQ0jBA0WwAnuQeThcCy9CdhBOMYOJ ODCnCIWHrY79IuHtlurH9UTAzayamtn8e4yvU/ik= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Chenguang Zhao , Vadim Fedorenko , Zhu Yanjun , Jakub Kicinski , Sasha Levin Subject: [PATCH 7.1 101/438] forcedeth: fix UAF of txrx_stats in nv_remove Date: Fri, 7 Aug 2026 16:34:57 +0200 Message-ID: <20260807143430.142419678@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260807143428.008222056@linuxfoundation.org> References: <20260807143428.008222056@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Chenguang Zhao [ Upstream commit 22666ba1420164753d7b0f5a841986b25ace5435 ] nv_remove() frees the per-CPU txrx_stats before unregister_netdev(). Until unregister completes, ndo_get_stats64, the NAPI/xmit data path, and nv_close()/drain may still access txrx_stats, leading to a use-after-free. Free the stats only after unregister_netdev(). Fixes: f4b633b911fd ("forcedeth: use per cpu to collect xmit/recv statistics") Signed-off-by: Chenguang Zhao Reviewed-by: Vadim Fedorenko Reviewed-by: Zhu Yanjun Link: https://patch.msgid.link/20260723092637.2135095-1-chenguang.zhao@linux.dev Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/nvidia/forcedeth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/nvidia/forcedeth.c b/drivers/net/ethernet/nvidia/forcedeth.c index 5b0435d7bc395..58d3e55def486 100644 --- a/drivers/net/ethernet/nvidia/forcedeth.c +++ b/drivers/net/ethernet/nvidia/forcedeth.c @@ -6187,10 +6187,10 @@ static void nv_remove(struct pci_dev *pci_dev) struct net_device *dev = pci_get_drvdata(pci_dev); struct fe_priv *np = netdev_priv(dev); - free_percpu(np->txrx_stats); - unregister_netdev(dev); + free_percpu(np->txrx_stats); + nv_restore_mac_addr(pci_dev); /* restore any phy related changes */ -- 2.53.0