From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BC21380FFD; Fri, 7 Aug 2026 15:42:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786117328; cv=none; b=eotzuPBi26FjDkSApxOs2DsCnTvK8mm8kRwBL20X6zt0fYYDOfnDUsi/m9xqqXbyIuSyXO5hx1Q0dOSN/2owzmUMaGQzLqGOThRfsL/sUua4Vd2um6X8GedOM/ZSvn2h1xuQN60vrCMCDYbS2kfw7env9u741PDAHJVa42c7Dj8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786117328; c=relaxed/simple; bh=dkVrW2GntwJJBd1pm3iXafMrlBVrcWeKS10qOhM/i+w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YIpNR6CApRKD9NRkXqJyQ71UlhXBEotwaaJuuLLY/ArADrpQviK0IHSIkk8D9ndafJaxOXn4CuJ1LO5c5CE9GtajmfzA01Vmn6PNdhJjUS7wwx4LhEg8L15zNmejbxWgzs0K+SUhMHMJbPJbiiZ/K5a2Zrs6Q4xBwWiOcxJHHt0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=urNS0QkP; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="urNS0QkP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D25D91F000E9; Fri, 7 Aug 2026 15:42:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1786117327; bh=XGLr49j7CGXIIy4sG+kqGB5NNGd812ZsER0G0kWJytU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=urNS0QkP5F9TFr4jnPBZmi/GVyCuG8qs6Jrx/eCAZWfSUI8LzdMCsMzr2LKZNZABm gQy5rcTQqU758R7U+KBDmALsJggLbm43GCGgrp3rodGii1x5g6W1toZ/r39IYFqfCJ NTEv9zBPrAcl/GK1IXvnmt38yzXdQKlC+sB9SsWM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Xuanqiang Luo , Mahanta Jambigi , Paolo Abeni Subject: [PATCH 7.1 280/438] net/smc: fix socket use-after-free during link group termination Date: Fri, 7 Aug 2026 16:37:56 +0200 Message-ID: <20260807143433.949830987@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260807143428.008222056@linuxfoundation.org> References: <20260807143428.008222056@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Xuanqiang Luo commit f621d6ebeebb6374342571e4ddf45fdbc420f6cd upstream. __smc_lgr_terminate() drops conns_lock after finding a connection in lgr->conns_all, but before taking a reference on its socket. The connection is embedded in the socket, and its registration reference protects it only while the connection remains in the tree. A concurrent close can unregister the connection and drop that reference, freeing the socket before the termination worker reaches sock_hold(). The race is reachable when close overlaps link group termination. Local stress testing reproduced the use-after-free and KASAN reported: BUG: KASAN: slab-use-after-free in __smc_lgr_terminate.part.0 [smc] Write of size 4 by task kworker/3:3 Workqueue: events smc_lgr_terminate_work [smc] __smc_lgr_terminate.part.0 [smc] The socket was allocated by smc_create(), freed through slab_free_after_rcu_debug(), and was followed by: refcount_t: addition on 0; use-after-free. __smc_lgr_terminate.part.0 [smc] Take the socket reference while conns_lock still protects the tree entry. The unregister path then cannot drop the last reference until termination has finished using the socket. Fixes: 69318b5215f2 ("net/smc: improve abnormal termination locking") Cc: stable@vger.kernel.org Signed-off-by: Xuanqiang Luo Reviewed-by: Mahanta Jambigi Link: https://patch.msgid.link/20260723105454.87016-1-xuanqiang.luo@linux.dev Signed-off-by: Paolo Abeni Signed-off-by: Greg Kroah-Hartman --- net/smc/smc_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/smc/smc_core.c +++ b/net/smc/smc_core.c @@ -1572,10 +1572,10 @@ static void __smc_lgr_terminate(struct s read_lock_bh(&lgr->conns_lock); node = rb_first(&lgr->conns_all); while (node) { - read_unlock_bh(&lgr->conns_lock); conn = rb_entry(node, struct smc_connection, alert_node); smc = container_of(conn, struct smc_sock, conn); sock_hold(&smc->sk); /* sock_put below */ + read_unlock_bh(&lgr->conns_lock); lock_sock(&smc->sk); smc_conn_kill(conn, soft); release_sock(&smc->sk);