From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21899C2A09B for ; Fri, 7 Aug 2026 16:06:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 32A1810F560; Fri, 7 Aug 2026 16:06:23 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="YwLIAp3T"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0E56410F560 for ; Fri, 7 Aug 2026 16:06:22 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 2EB3B600B0; Fri, 7 Aug 2026 16:06:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CFE61F000E9; Fri, 7 Aug 2026 16:06:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786118780; bh=Urc/6Q1Pe4+/ucRIjiP/K3/3xDvcTb6U0/VbrwDRbs0=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=YwLIAp3TgVpkr0iyEsu2H5eb41FD9ern1Adyv8B/iIV3tBQATY5vIuv//gYZ73rh0 1koW/rTfGurA9gJe6IIZamRPZ5dDJHA1aPvHWz6OTKF9MfjQrBCqRuNvNN/7WfVZIH T6JMgBkG9ZtNskMXx8thqfxBEcp8E3PxnW3PbrwakIxJHYMZfTC6xH0dTN2GUREE49 juq8b2y1BOaZMQyv7N0jMx6chzGIFyb4BM+h1bcpEdfzASgWxEUn8D0IM4V/gMFYzK B6p6R0aKfirO9iiGwKwJ8iH7Zbx29srdkD9HdBvuz8OF4ymsXER9z4v6CUwaIWTCLb o9CGQ2J9X7F4Q== From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 08/10] arm64: tegra: Add VPR placeholder node on Tegra234 To: "Thierry Reding" Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org, "Alexander Gordeev" , linux-s390@vger.kernel.org, "Heiko Carstens" , "Vasily Gorbik" , dri-devel@lists.freedesktop.org, media-ci@linuxtv.org In-Reply-To: <20260807-tegra-vpr-v4-8-5510d16af89e@nvidia.com> References: <20260807-tegra-vpr-v4-0-5510d16af89e@nvidia.com> <20260807-tegra-vpr-v4-8-5510d16af89e@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 07 Aug 2026 16:06:19 +0000 Message-Id: <20260807160620.4CFE61F000E9@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > From: Thierry Reding >=20 > This node contains two sets of properties, one for the case where the > VPR is resizable (in which case the VPR region will be dynamically > allocated at boot time) and another case where the VPR is fixed in size > and initialized by early firmware. >=20 > The firmware running on the device is responsible for updating the node > with the real physical address for the fixed VPR case and remove the > properties needed only for resizable VPR. Similarly, if the VPR is > resizable, the firmware should remove the "reg" property since it is no > longer needed. >=20 > Signed-off-by: Thierry Reding Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260807-tegra-vpr-= v4-0-5510d16af89e@nvidia.com?part=3D8