From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Diogo Ivo (Schneider Electric)" <diogo.ivo@bootlin.com>
Cc: Mark Brown <broonie@kernel.org>,
Matthew Gerlach <matthew.gerlach@altera.com>,
Khairul Anuar Romli <khairul.anuar.romli@altera.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
miquel.raynal@bootlin.com, thomas.petazzoni@bootlin.com,
Pascal EBERHARD <pascal.eberhard@se.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 6.12.y 0/2] spi: cadence-quadspi: fix probe error path and remove
Date: Fri, 7 Aug 2026 15:46:24 +0200 [thread overview]
Message-ID: <2026080717-payday-closable-07be@gregkh> (raw)
In-Reply-To: <20260807-cqspi-pm_runtime-v1-0-5973a0a208c4@bootlin.com>
On Fri, Aug 07, 2026 at 01:49:19PM +0200, Diogo Ivo (Schneider Electric) wrote:
> This series fixes two resource leaks in the cadence-quadspi driver's
> probe error path and remove callback.
>
> Patch 1 fixes an imbalanced pm_runtime_enable()/pm_runtime_disable()
> pair: when probe defers after cqspi_request_mmap_dma(),
> pm_runtime_disable() is called without a prior pm_runtime_enable().
> It also adds the missing pm_runtime_dont_use_autosuspend() in both
> the probe error path and the remove callback and a missing
> pm_runtime_put_noidle() in the probe error path. This consolidates
> fixes from upstream commits 5ff4d5d1af0c and 5e8bb0cc72f1.
>
> Patch 2 fixes a DMA channel leak: when spi_register_controller() fails,
> the channel acquired via cqspi_request_mmap_dma() is never released.
> A dedicated error label is added to release it before the runtime PM
> teardown. This fix is one part of upstream commit f18c8cfa4f1a.
>
> Signed-off-by: Diogo Ivo (Schneider Electric) <diogo.ivo@bootlin.com>
> ---
> Diogo Ivo (Schneider Electric) (2):
> spi: cadence-quadspi: fix runtime pm cleanup on probe failure/unbind
> spi: cadence-quadspi: release DMA channel on probe failure
>
> drivers/spi/spi-cadence-quadspi.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
> ---
> base-commit: 7351870f56cba79097a2ab57e609469719ea4f73
> change-id: 20260730-cqspi-pm_runtime-a8a1c6122944
>
> Best regards,
> --
> Diogo Ivo <diogo.ivo@bootlin.com>
>
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
prev parent reply other threads:[~2026-08-07 13:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 11:49 [PATCH 6.12.y 0/2] spi: cadence-quadspi: fix probe error path and remove Diogo Ivo (Schneider Electric)
2026-08-07 11:49 ` [PATCH 6.12.y 1/2] spi: cadence-quadspi: fix runtime pm cleanup on probe failure/unbind Diogo Ivo (Schneider Electric)
2026-08-07 19:06 ` Sasha Levin
2026-08-07 11:49 ` [PATCH 6.12.y 2/2] spi: cadence-quadspi: release DMA channel on probe failure Diogo Ivo (Schneider Electric)
2026-08-07 13:46 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026080717-payday-closable-07be@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=broonie@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=diogo.ivo@bootlin.com \
--cc=khairul.anuar.romli@altera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=matthew.gerlach@altera.com \
--cc=miquel.raynal@bootlin.com \
--cc=pascal.eberhard@se.com \
--cc=stable@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.