diff for duplicates of <202608072059.hZ2oY5u0-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index 23c2ee4..515ef0f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,29 +1,13 @@ -BCC: lkp@intel.com -CC: oe-kbuild-all@lists.linux.dev -In-Reply-To: <20260624123103.3523728-1-enachman@marvell.com> -References: <20260624123103.3523728-1-enachman@marvell.com> -TO: Elad Nachman <enachman@marvell.com> -TO: alexandre.belloni@bootlin.com -TO: linux-rtc@vger.kernel.org -TO: linux-kernel@vger.kernel.org -CC: enachman@marvell.com - Hi Elad, kernel test robot noticed the following build warnings: -[auto build test WARNING on abelloni/rtc-next] -[also build test WARNING on linus/master v7.2-rc6 next-20260806] -[If your patch is applied to the wrong git tree, kindly drop us a note. -And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Elad-Nachman/drivers-rtc-handle-OTF-clock-changes/20260806-231215 base: https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next patch link: https://lore.kernel.org/r/20260624123103.3523728-1-enachman%40marvell.com patch subject: [PATCH] drivers: rtc: handle OTF clock changes -:::::: branch date: 21 hours ago -:::::: commit date: 21 hours ago config: i386-randconfig-141 (https://download.01.org/0day-ci/archive/20260807/202608072059.hZ2oY5u0-lkp@intel.com/config) compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 smatch: v0.5.0-9187-g5189e3fb @@ -39,7 +23,6 @@ drivers/rtc/interface.c:163 rtc_set_time() warn: variable dereferenced before ch vim +/rtc +163 drivers/rtc/interface.c -0c86edc0d49706 Alessandro Zummo 2006-03-27 125 ab6a2d70d18edc David Brownell 2007-05-08 126 int rtc_set_time(struct rtc_device *rtc, struct rtc_time *tm) 0c86edc0d49706 Alessandro Zummo 2006-03-27 127 { 7e7c005b4b1f1f Alexandre Belloni 2019-10-21 128 int err, uie; @@ -78,6 +61,10 @@ cd9662094edf41 David Brownell 2007-05-08 159 err = rtc->ops->set_time(rtc bbccf83f6c4e1a Alessandro Zummo 2009-01-06 161 err = -EINVAL; 0c86edc0d49706 Alessandro Zummo 2006-03-27 162 37b82b16c5f104 Elad Nachman 2026-06-24 @163 if (rtc && rtc->ops && rtc->ops->read_time) { + ^^^ +There is no point in checking "rtc" after we have already dereferenced +it. + 37b82b16c5f104 Elad Nachman 2026-06-24 164 if (!rtc->ops->read_time(rtc->dev.parent, &new_tm)) { 37b82b16c5f104 Elad Nachman 2026-06-24 165 pr_debug("new rtc time secs %d mins %d hours %d mday %d mon %d year %d way %d yday %d dst %d\n", 37b82b16c5f104 Elad Nachman 2026-06-24 166 new_tm.tm_sec, new_tm.tm_min, @@ -102,8 +89,6 @@ bbccf83f6c4e1a Alessandro Zummo 2009-01-06 161 err = -EINVAL; 29a1f599c0cc37 Baolin Wang 2017-12-14 185 trace_rtc_set_time(rtc_tm_to_time64(tm), err); 0c86edc0d49706 Alessandro Zummo 2006-03-27 186 return err; 0c86edc0d49706 Alessandro Zummo 2006-03-27 187 } -0c86edc0d49706 Alessandro Zummo 2006-03-27 188 EXPORT_SYMBOL_GPL(rtc_set_time); -0c86edc0d49706 Alessandro Zummo 2006-03-27 189 -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N1/content_digest index 2aa088c..ab8b792 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,37 +1,27 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "ref\020260624123103.3523728-1-enachman@marvell.com\0" + "From\0Dan Carpenter <error27@gmail.com>\0" "Subject\0Re: [PATCH] drivers: rtc: handle OTF clock changes\0" - "Date\0Fri, 7 Aug 2026 20:35:16 +0800\0" - "To\0oe-kbuild@lists.linux.dev\0" + "Date\0Fri, 7 Aug 2026 16:05:43 +0300\0" + "To\0oe-kbuild@lists.linux.dev" + Elad Nachman <enachman@marvell.com> + alexandre.belloni@bootlin.com + linux-rtc@vger.kernel.org + " linux-kernel@vger.kernel.org\0" "Cc\0lkp@intel.com" - " Dan Carpenter <error27@gmail.com>\0" + oe-kbuild-all@lists.linux.dev + " enachman@marvell.com\0" "\00:1\0" "b\0" - "BCC: lkp@intel.com\n" - "CC: oe-kbuild-all@lists.linux.dev\n" - "In-Reply-To: <20260624123103.3523728-1-enachman@marvell.com>\n" - "References: <20260624123103.3523728-1-enachman@marvell.com>\n" - "TO: Elad Nachman <enachman@marvell.com>\n" - "TO: alexandre.belloni@bootlin.com\n" - "TO: linux-rtc@vger.kernel.org\n" - "TO: linux-kernel@vger.kernel.org\n" - "CC: enachman@marvell.com\n" - "\n" "Hi Elad,\n" "\n" "kernel test robot noticed the following build warnings:\n" "\n" - "[auto build test WARNING on abelloni/rtc-next]\n" - "[also build test WARNING on linus/master v7.2-rc6 next-20260806]\n" - "[If your patch is applied to the wrong git tree, kindly drop us a note.\n" - "And when submitting patch, we suggest to use '--base' as documented in\n" "https://git-scm.com/docs/git-format-patch#_base_tree_information]\n" "\n" "url: https://github.com/intel-lab-lkp/linux/commits/Elad-Nachman/drivers-rtc-handle-OTF-clock-changes/20260806-231215\n" "base: https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next\n" "patch link: https://lore.kernel.org/r/20260624123103.3523728-1-enachman%40marvell.com\n" "patch subject: [PATCH] drivers: rtc: handle OTF clock changes\n" - ":::::: branch date: 21 hours ago\n" - ":::::: commit date: 21 hours ago\n" "config: i386-randconfig-141 (https://download.01.org/0day-ci/archive/20260807/202608072059.hZ2oY5u0-lkp@intel.com/config)\n" "compiler: gcc-14 (Debian 14.2.0-19) 14.2.0\n" "smatch: v0.5.0-9187-g5189e3fb\n" @@ -47,7 +37,6 @@ "\n" "vim +/rtc +163 drivers/rtc/interface.c\n" "\n" - "0c86edc0d49706 Alessandro Zummo 2006-03-27 125 \n" "ab6a2d70d18edc David Brownell 2007-05-08 126 int rtc_set_time(struct rtc_device *rtc, struct rtc_time *tm)\n" "0c86edc0d49706 Alessandro Zummo 2006-03-27 127 {\n" "7e7c005b4b1f1f Alexandre Belloni 2019-10-21 128 \tint err, uie;\n" @@ -86,6 +75,10 @@ "bbccf83f6c4e1a Alessandro Zummo 2009-01-06 161 \t\terr = -EINVAL;\n" "0c86edc0d49706 Alessandro Zummo 2006-03-27 162 \n" "37b82b16c5f104 Elad Nachman 2026-06-24 @163 \tif (rtc && rtc->ops && rtc->ops->read_time) {\n" + " ^^^\n" + "There is no point in checking \"rtc\" after we have already dereferenced\n" + "it.\n" + "\n" "37b82b16c5f104 Elad Nachman 2026-06-24 164 \t\tif (!rtc->ops->read_time(rtc->dev.parent, &new_tm)) {\n" "37b82b16c5f104 Elad Nachman 2026-06-24 165 \t\t\tpr_debug(\"new rtc time secs %d mins %d hours %d mday %d mon %d year %d way %d yday %d dst %d\\n\",\n" "37b82b16c5f104 Elad Nachman 2026-06-24 166 \t\t\t\t\tnew_tm.tm_sec, new_tm.tm_min,\n" @@ -110,11 +103,9 @@ "29a1f599c0cc37 Baolin Wang 2017-12-14 185 \ttrace_rtc_set_time(rtc_tm_to_time64(tm), err);\n" "0c86edc0d49706 Alessandro Zummo 2006-03-27 186 \treturn err;\n" "0c86edc0d49706 Alessandro Zummo 2006-03-27 187 }\n" - "0c86edc0d49706 Alessandro Zummo 2006-03-27 188 EXPORT_SYMBOL_GPL(rtc_set_time);\n" - "0c86edc0d49706 Alessandro Zummo 2006-03-27 189 \n" "\n" "--\n" "0-DAY CI Kernel Test Service\n" https://github.com/intel/lkp-tests/wiki -4b6918c35cd14c1c25b9ddbdb13e68abd2ce2974bc4ed9f3c6d5b1e7c49bc9e4 +74e5a5cdc27a3442784d03e722b6e4fdf350a8903a9647bccd121a69782adf43
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.