From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c:862 amdgpu_gmc_fw_reg_write_reg_wait() error: buffer overflow 'adev->mes.ring' 16 <= u32max
Date: Fri, 07 Aug 2026 22:07:56 +0800 [thread overview]
Message-ID: <202608072130.cDZ61U1q-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Mukul Joshi <mukul.joshi@amd.com>
CC: Alex Deucher <alexander.deucher@amd.com>
CC: Alex Sierra <alex.sierra@amd.com>
CC: Michael Chen <michael.chen@amd.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 6c68fa601b49683ecb04eded993a71dfa8b2ba0b
commit: b7c4040d0d131de5014fb02bbdbe8fa2b9c5b0b0 drm/amdgpu: Use correct MES pipe in non-SPX mode on GFX 12.1
date: 7 months ago
:::::: branch date: 17 hours ago
:::::: commit date: 7 months ago
config: i386-randconfig-141-20260806 (https://download.01.org/0day-ci/archive/20260807/202608072130.cDZ61U1q-lkp@intel.com/config)
compiler: clang version 22.1.3 (https://github.com/llvm/llvm-project e9846648fd6183ee6d8cbdb4502213fcf902a211)
smatch: v0.5.0-9187-g5189e3fb
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: b7c4040d0d13 ("drm/amdgpu: Use correct MES pipe in non-SPX mode on GFX 12.1")
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202608072130.cDZ61U1q-lkp@intel.com/
smatch warnings:
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c:862 amdgpu_gmc_fw_reg_write_reg_wait() error: buffer overflow 'adev->mes.ring' 16 <= u32max
vim +862 drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
e7b90e99fa8fd6 Christian König 2023-09-04 850
26405ff4306a7b Alex Deucher 2023-12-14 851 void amdgpu_gmc_fw_reg_write_reg_wait(struct amdgpu_device *adev,
26405ff4306a7b Alex Deucher 2023-12-14 852 uint32_t reg0, uint32_t reg1,
26405ff4306a7b Alex Deucher 2023-12-14 853 uint32_t ref, uint32_t mask,
26405ff4306a7b Alex Deucher 2023-12-14 854 uint32_t xcc_inst)
26405ff4306a7b Alex Deucher 2023-12-14 855 {
26405ff4306a7b Alex Deucher 2023-12-14 856 struct amdgpu_kiq *kiq = &adev->gfx.kiq[xcc_inst];
26405ff4306a7b Alex Deucher 2023-12-14 857 struct amdgpu_ring *ring = &kiq->ring;
26405ff4306a7b Alex Deucher 2023-12-14 858 signed long r, cnt = 0;
26405ff4306a7b Alex Deucher 2023-12-14 859 unsigned long flags;
26405ff4306a7b Alex Deucher 2023-12-14 860 uint32_t seq;
26405ff4306a7b Alex Deucher 2023-12-14 861
b7c4040d0d131d Mukul Joshi 2025-08-07 @862 if (adev->mes.ring[MES_PIPE_INST(xcc_inst, 0)].sched.ready) {
26405ff4306a7b Alex Deucher 2023-12-14 863 amdgpu_mes_reg_write_reg_wait(adev, reg0, reg1,
d09c7e266c8cd5 Jack Xiao 2024-11-21 864 ref, mask, xcc_inst);
26405ff4306a7b Alex Deucher 2023-12-14 865 return;
26405ff4306a7b Alex Deucher 2023-12-14 866 }
26405ff4306a7b Alex Deucher 2023-12-14 867
26405ff4306a7b Alex Deucher 2023-12-14 868 spin_lock_irqsave(&kiq->ring_lock, flags);
26405ff4306a7b Alex Deucher 2023-12-14 869 amdgpu_ring_alloc(ring, 32);
26405ff4306a7b Alex Deucher 2023-12-14 870 amdgpu_ring_emit_reg_write_reg_wait(ring, reg0, reg1,
26405ff4306a7b Alex Deucher 2023-12-14 871 ref, mask);
26405ff4306a7b Alex Deucher 2023-12-14 872 r = amdgpu_fence_emit_polling(ring, &seq, MAX_KIQ_REG_WAIT);
26405ff4306a7b Alex Deucher 2023-12-14 873 if (r)
26405ff4306a7b Alex Deucher 2023-12-14 874 goto failed_undo;
26405ff4306a7b Alex Deucher 2023-12-14 875
26405ff4306a7b Alex Deucher 2023-12-14 876 amdgpu_ring_commit(ring);
26405ff4306a7b Alex Deucher 2023-12-14 877 spin_unlock_irqrestore(&kiq->ring_lock, flags);
26405ff4306a7b Alex Deucher 2023-12-14 878
26405ff4306a7b Alex Deucher 2023-12-14 879 r = amdgpu_fence_wait_polling(ring, seq, MAX_KIQ_REG_WAIT);
26405ff4306a7b Alex Deucher 2023-12-14 880
26405ff4306a7b Alex Deucher 2023-12-14 881 /* don't wait anymore for IRQ context */
26405ff4306a7b Alex Deucher 2023-12-14 882 if (r < 1 && in_interrupt())
26405ff4306a7b Alex Deucher 2023-12-14 883 goto failed_kiq;
26405ff4306a7b Alex Deucher 2023-12-14 884
26405ff4306a7b Alex Deucher 2023-12-14 885 might_sleep();
19cff16559a4f2 Victor Skvortsov 2024-08-02 886 while (r < 1 && cnt++ < MAX_KIQ_REG_TRY &&
19cff16559a4f2 Victor Skvortsov 2024-08-02 887 !amdgpu_reset_pending(adev->reset_domain)) {
26405ff4306a7b Alex Deucher 2023-12-14 888
26405ff4306a7b Alex Deucher 2023-12-14 889 msleep(MAX_KIQ_REG_BAILOUT_INTERVAL);
26405ff4306a7b Alex Deucher 2023-12-14 890 r = amdgpu_fence_wait_polling(ring, seq, MAX_KIQ_REG_WAIT);
26405ff4306a7b Alex Deucher 2023-12-14 891 }
26405ff4306a7b Alex Deucher 2023-12-14 892
26405ff4306a7b Alex Deucher 2023-12-14 893 if (cnt > MAX_KIQ_REG_TRY)
26405ff4306a7b Alex Deucher 2023-12-14 894 goto failed_kiq;
26405ff4306a7b Alex Deucher 2023-12-14 895
26405ff4306a7b Alex Deucher 2023-12-14 896 return;
26405ff4306a7b Alex Deucher 2023-12-14 897
26405ff4306a7b Alex Deucher 2023-12-14 898 failed_undo:
26405ff4306a7b Alex Deucher 2023-12-14 899 amdgpu_ring_undo(ring);
26405ff4306a7b Alex Deucher 2023-12-14 900 spin_unlock_irqrestore(&kiq->ring_lock, flags);
26405ff4306a7b Alex Deucher 2023-12-14 901 failed_kiq:
26405ff4306a7b Alex Deucher 2023-12-14 902 dev_err(adev->dev, "failed to write reg %x wait reg %x\n", reg0, reg1);
26405ff4306a7b Alex Deucher 2023-12-14 903 }
26405ff4306a7b Alex Deucher 2023-12-14 904
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2026-08-07 14:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 14:07 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-08-09 4:26 drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c:862 amdgpu_gmc_fw_reg_write_reg_wait() error: buffer overflow 'adev->mes.ring' 16 <= u32max kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202608072130.cDZ61U1q-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.