All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: david@ixit.cz
Cc: Jakub Kicinski <kuba@kernel.org>,
	bongsu.jeon@samsung.com, shuah@kernel.org,
	oe-linux-nfc@lists.linux.dev, linux-kselftest@vger.kernel.org
Subject: [PATCH nfc] selftests/nci: increase t4t_tag_read timeout for debug kernels
Date: Fri,  7 Aug 2026 15:16:22 -0700	[thread overview]
Message-ID: <20260807221622.1727540-1-kuba@kernel.org> (raw)

The t4t_tag_read test occasionally exceeds the default 30-second
TEST_TIMEOUT_DEFAULT, triggering flaky "Test terminated by timeout"
failures (~4% rate on slow CI systems with debug configs).

TBH this is potentially papering over a real issue. The test usually
takes 7sec to finish, with this fix it sometimes takes 37s. What
happens when it needs extra time I do not know. But the upshot is
that it used to flake 4% of the time in NIPA and now it passes
(200 clean runs). So unless someone has time to really dig into this,
let's silence it?

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: bongsu.jeon@samsung.com
CC: david@ixit.cz
CC: shuah@kernel.org
CC: oe-linux-nfc@lists.linux.dev
CC: linux-kselftest@vger.kernel.org
---
 tools/testing/selftests/nci/nci_dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/nci/nci_dev.c b/tools/testing/selftests/nci/nci_dev.c
index 312f84ee0444..77344227dd7f 100644
--- a/tools/testing/selftests/nci/nci_dev.c
+++ b/tools/testing/selftests/nci/nci_dev.c
@@ -836,7 +836,7 @@ int disconnect_tag(int nfc_sock, int virtual_fd)
 	return status;
 }
 
-TEST_F(NCI, t4t_tag_read)
+TEST_F_TIMEOUT(NCI, t4t_tag_read, 120)
 {
 	int nfc_sock;
 	int status;
-- 
2.55.0


                 reply	other threads:[~2026-08-07 22:16 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260807221622.1727540-1-kuba@kernel.org \
    --to=kuba@kernel.org \
    --cc=bongsu.jeon@samsung.com \
    --cc=david@ixit.cz \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=oe-linux-nfc@lists.linux.dev \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.