diff for duplicates of <202608072246.Ee6OOcT6-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index 6ec3619..e04136b 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,14 +1,6 @@ -BCC: lkp@intel.com -CC: oe-kbuild-all@lists.linux.dev -TO: Eli Billauer <eli.billauer@gmail.com> -CC: 0day robot <lkp@intel.com> - tree: https://github.com/intel-lab-lkp/linux/commits/Eli-Billauer/char-xillybus-Improve-control-of-execution-flow-with-mutexes/20260806-033404 head: d05c024c9354aabd2ea64be46e6fccbf24ba33cd commit: 16edb90c39a5645b3803be32b2b77476efae2402 char: xillybus: Add defensive sanity checks -date: 2 days ago -:::::: branch date: 2 days ago -:::::: commit date: 2 days ago config: i386-randconfig-141 (https://download.01.org/0day-ci/archive/20260807/202608072246.Ee6OOcT6-lkp@intel.com/config) compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 smatch: v0.5.0-9187-g5189e3fb @@ -24,40 +16,25 @@ drivers/char/xillybus/xillybus_class.c:230 xillybus_find_inode() warn: variable vim +/inode +230 drivers/char/xillybus/xillybus_class.c -8cb5d216ab3365 Eli Billauer 2021-05-26 222 8cb5d216ab3365 Eli Billauer 2021-05-26 223 int xillybus_find_inode(struct inode *inode, 8cb5d216ab3365 Eli Billauer 2021-05-26 224 void **private_data, int *index) 8cb5d216ab3365 Eli Billauer 2021-05-26 225 { 8cb5d216ab3365 Eli Billauer 2021-05-26 @226 int minor = iminor(inode); 8cb5d216ab3365 Eli Billauer 2021-05-26 227 int major = imajor(inode); + ^^^^^ +Unchecked dereferences + 4834f9898c7301 Jakob Koschel 2022-03-24 228 struct xilly_unit *unit = NULL, *iter; 8cb5d216ab3365 Eli Billauer 2021-05-26 229 16edb90c39a564 Eli Billauer 2026-06-30 @230 if (!inode || !private_data || !index) + ^^^^^^ +Checked too late. + 16edb90c39a564 Eli Billauer 2026-06-30 231 return -ENODEV; 16edb90c39a564 Eli Billauer 2026-06-30 232 8cb5d216ab3365 Eli Billauer 2021-05-26 233 mutex_lock(&unit_mutex); 8cb5d216ab3365 Eli Billauer 2021-05-26 234 4834f9898c7301 Jakob Koschel 2022-03-24 235 list_for_each_entry(iter, &unit_list, list_entry) -4834f9898c7301 Jakob Koschel 2022-03-24 236 if (iter->major == major && -4834f9898c7301 Jakob Koschel 2022-03-24 237 minor >= iter->lowest_minor && -4834f9898c7301 Jakob Koschel 2022-03-24 238 minor < (iter->lowest_minor + iter->num_nodes)) { -4834f9898c7301 Jakob Koschel 2022-03-24 239 unit = iter; -8cb5d216ab3365 Eli Billauer 2021-05-26 240 break; -8cb5d216ab3365 Eli Billauer 2021-05-26 241 } -8cb5d216ab3365 Eli Billauer 2021-05-26 242 -c002f04c0bc79e Eli Billauer 2022-11-17 243 if (!unit) { -8cb5d216ab3365 Eli Billauer 2021-05-26 244 mutex_unlock(&unit_mutex); -8cb5d216ab3365 Eli Billauer 2021-05-26 245 return -ENODEV; -c002f04c0bc79e Eli Billauer 2022-11-17 246 } -8cb5d216ab3365 Eli Billauer 2021-05-26 247 -8cb5d216ab3365 Eli Billauer 2021-05-26 248 *private_data = unit->private_data; -8cb5d216ab3365 Eli Billauer 2021-05-26 249 *index = minor - unit->lowest_minor; -8cb5d216ab3365 Eli Billauer 2021-05-26 250 -c002f04c0bc79e Eli Billauer 2022-11-17 251 mutex_unlock(&unit_mutex); -8cb5d216ab3365 Eli Billauer 2021-05-26 252 return 0; -8cb5d216ab3365 Eli Billauer 2021-05-26 253 } -8cb5d216ab3365 Eli Billauer 2021-05-26 254 EXPORT_SYMBOL(xillybus_find_inode); -8cb5d216ab3365 Eli Billauer 2021-05-26 255 -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N1/content_digest index 176bf57..a48fa60 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,22 +1,15 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "From\0Dan Carpenter <error27@gmail.com>\0" "Subject\0drivers/char/xillybus/xillybus_class.c:230 xillybus_find_inode() warn: variable dereferenced before check 'inode' (see line 226)\0" - "Date\0Fri, 07 Aug 2026 22:39:57 +0800\0" - "To\0oe-kbuild@lists.linux.dev\0" + "Date\0Fri, 7 Aug 2026 19:55:02 +0300\0" + "To\0oe-kbuild@lists.linux.dev" + " Eli Billauer <eli.billauer@gmail.com>\0" "Cc\0lkp@intel.com" - " Dan Carpenter <error27@gmail.com>\0" + " oe-kbuild-all@lists.linux.dev\0" "\00:1\0" "b\0" - "BCC: lkp@intel.com\n" - "CC: oe-kbuild-all@lists.linux.dev\n" - "TO: Eli Billauer <eli.billauer@gmail.com>\n" - "CC: 0day robot <lkp@intel.com>\n" - "\n" "tree: https://github.com/intel-lab-lkp/linux/commits/Eli-Billauer/char-xillybus-Improve-control-of-execution-flow-with-mutexes/20260806-033404\n" "head: d05c024c9354aabd2ea64be46e6fccbf24ba33cd\n" "commit: 16edb90c39a5645b3803be32b2b77476efae2402 char: xillybus: Add defensive sanity checks\n" - "date: 2 days ago\n" - ":::::: branch date: 2 days ago\n" - ":::::: commit date: 2 days ago\n" "config: i386-randconfig-141 (https://download.01.org/0day-ci/archive/20260807/202608072246.Ee6OOcT6-lkp@intel.com/config)\n" "compiler: gcc-14 (Debian 14.2.0-19) 14.2.0\n" "smatch: v0.5.0-9187-g5189e3fb\n" @@ -32,43 +25,28 @@ "\n" "vim +/inode +230 drivers/char/xillybus/xillybus_class.c\n" "\n" - "8cb5d216ab3365 Eli Billauer 2021-05-26 222 \n" "8cb5d216ab3365 Eli Billauer 2021-05-26 223 int xillybus_find_inode(struct inode *inode,\n" "8cb5d216ab3365 Eli Billauer 2021-05-26 224 \t\t\tvoid **private_data, int *index)\n" "8cb5d216ab3365 Eli Billauer 2021-05-26 225 {\n" "8cb5d216ab3365 Eli Billauer 2021-05-26 @226 \tint minor = iminor(inode);\n" "8cb5d216ab3365 Eli Billauer 2021-05-26 227 \tint major = imajor(inode);\n" + " ^^^^^\n" + "Unchecked dereferences\n" + "\n" "4834f9898c7301 Jakob Koschel 2022-03-24 228 \tstruct xilly_unit *unit = NULL, *iter;\n" "8cb5d216ab3365 Eli Billauer 2021-05-26 229 \n" "16edb90c39a564 Eli Billauer 2026-06-30 @230 \tif (!inode || !private_data || !index)\n" + " ^^^^^^\n" + "Checked too late.\n" + "\n" "16edb90c39a564 Eli Billauer 2026-06-30 231 \t\treturn -ENODEV;\n" "16edb90c39a564 Eli Billauer 2026-06-30 232 \n" "8cb5d216ab3365 Eli Billauer 2021-05-26 233 \tmutex_lock(&unit_mutex);\n" "8cb5d216ab3365 Eli Billauer 2021-05-26 234 \n" "4834f9898c7301 Jakob Koschel 2022-03-24 235 \tlist_for_each_entry(iter, &unit_list, list_entry)\n" - "4834f9898c7301 Jakob Koschel 2022-03-24 236 \t\tif (iter->major == major &&\n" - "4834f9898c7301 Jakob Koschel 2022-03-24 237 \t\t minor >= iter->lowest_minor &&\n" - "4834f9898c7301 Jakob Koschel 2022-03-24 238 \t\t minor < (iter->lowest_minor + iter->num_nodes)) {\n" - "4834f9898c7301 Jakob Koschel 2022-03-24 239 \t\t\tunit = iter;\n" - "8cb5d216ab3365 Eli Billauer 2021-05-26 240 \t\t\tbreak;\n" - "8cb5d216ab3365 Eli Billauer 2021-05-26 241 \t\t}\n" - "8cb5d216ab3365 Eli Billauer 2021-05-26 242 \n" - "c002f04c0bc79e Eli Billauer 2022-11-17 243 \tif (!unit) {\n" - "8cb5d216ab3365 Eli Billauer 2021-05-26 244 \t\tmutex_unlock(&unit_mutex);\n" - "8cb5d216ab3365 Eli Billauer 2021-05-26 245 \t\treturn -ENODEV;\n" - "c002f04c0bc79e Eli Billauer 2022-11-17 246 \t}\n" - "8cb5d216ab3365 Eli Billauer 2021-05-26 247 \n" - "8cb5d216ab3365 Eli Billauer 2021-05-26 248 \t*private_data = unit->private_data;\n" - "8cb5d216ab3365 Eli Billauer 2021-05-26 249 \t*index = minor - unit->lowest_minor;\n" - "8cb5d216ab3365 Eli Billauer 2021-05-26 250 \n" - "c002f04c0bc79e Eli Billauer 2022-11-17 251 \tmutex_unlock(&unit_mutex);\n" - "8cb5d216ab3365 Eli Billauer 2021-05-26 252 \treturn 0;\n" - "8cb5d216ab3365 Eli Billauer 2021-05-26 253 }\n" - "8cb5d216ab3365 Eli Billauer 2021-05-26 254 EXPORT_SYMBOL(xillybus_find_inode);\n" - "8cb5d216ab3365 Eli Billauer 2021-05-26 255 \n" "\n" "--\n" "0-DAY CI Kernel Test Service\n" https://github.com/intel/lkp-tests/wiki -b25ce0af4b6f67673b25b29911e255ee1caa330308b4334a59153d73a13699c9 +ead5396959a7880b3f33ce65a77d22e6a6b86b865c806a0b41944d04b7834fea
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.