From: Avinash Duduskar <avinash.duduskar@gmail.com>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org, Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH nft] datatype: accept a numeric cgroupsv2 id on input
Date: Sat, 8 Aug 2026 06:57:56 +0530 [thread overview]
Message-ID: <20260808012756.2757796-1-avinash.duduskar@gmail.com> (raw)
In-Reply-To: <amnGEhXHD5175bxC@orbyte.nwl.cc>
On Wed, Jul 29, 2026 at 11:21:22AM +0200, Phil Sutter wrote:
> So maybe only do it if you don't break a leg over it: Use jq or awk to
> eliminate the metainfo object and write a simple test which asserts its
> presence in output.
Two shapes work and the second is much smaller, so I'd rather you pick
before I post.
1. Filter in json-pretty.sh and regenerate the dumps. 433 files, 260K.
2. Same filter, plus run the stored dump through json_pretty in
test-wrapper.sh before the diff. 2 files, 8 lines, no regeneration.
The 430 dumps keep a metainfo object nothing reads until they are next
regenerated.
Both survive a json_schema_version bump. I checked by setting a stored
dump to schema 2: passes either way, fails without the change. Suite is
green as root on both, and either way there is a new
tests/shell/testcases/json/metainfo asserting nft still emits it.
Which do you prefer?
Thanks,
Avinash
next prev parent reply other threads:[~2026-08-08 1:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 8:24 [PATCH nft] datatype: accept a numeric cgroupsv2 id on input Avinash Duduskar
2026-07-28 16:19 ` Phil Sutter
2026-07-28 19:16 ` Pablo Neira Ayuso
2026-07-28 20:19 ` Avinash Duduskar
2026-07-28 20:31 ` Pablo Neira Ayuso
2026-07-28 20:55 ` Avinash Duduskar
2026-07-29 9:21 ` Phil Sutter
2026-08-08 1:27 ` Avinash Duduskar [this message]
2026-07-29 9:13 ` Phil Sutter
2026-07-29 10:03 ` Avinash Duduskar
2026-07-29 11:43 ` Pablo Neira Ayuso
2026-07-29 14:19 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260808012756.2757796-1-avinash.duduskar@gmail.com \
--to=avinash.duduskar@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.