From: Steven Rostedt <rostedt@goodmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: Pekka Paalanen <ppaalanen@gmail.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] tracing/mmiotrace: Clean up coding style and redundant debug logs
Date: Sat, 8 Aug 2026 09:12:19 -0400 [thread overview]
Message-ID: <20260808091219.76d3c382@robin> (raw)
In-Reply-To: <20260808131634.4dafadc203a58e9f5b0e7613@kernel.org>
On Sat, 8 Aug 2026 13:16:34 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
> Yeah, this is somewhat machinary fix against the checkpatch.pl.
> Or, maybe it is better to just pass mmio_trace_array directly?
checkpatch.pl isn't for existing code. It is for new patches. And is
also more of a guideline than a rule.
Those two functions don't need to be changed to satisfy checkpatch.
They are fine as is.
-- Steve
prev parent reply other threads:[~2026-08-08 13:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 12:49 [PATCH 0/4] tracing/mmiotrace: Fix some bugs in mmiotrace Masami Hiramatsu (Google)
2026-07-28 12:49 ` [PATCH 1/4] tracing/mmiotrace: Reset dropped_count in mmio_reset_data() Masami Hiramatsu (Google)
2026-07-28 12:50 ` [PATCH 2/4] tracing/mmiotrace: Add NULL check for mmio_trace_array in logging functions Masami Hiramatsu (Google)
2026-07-28 12:50 ` [PATCH 3/4] tracing/mmiotrace: Use trace_assign_type() in mmio_print_mark() Masami Hiramatsu (Google)
2026-07-28 12:50 ` [PATCH 4/4] tracing/mmiotrace: Clean up coding style and redundant debug logs Masami Hiramatsu (Google)
2026-08-08 0:50 ` Steven Rostedt
2026-08-08 4:16 ` Masami Hiramatsu
2026-08-08 13:12 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260808091219.76d3c382@robin \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=ppaalanen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.