From: Mohit Mishra <mishraloopmohit@gmail.com>
To: Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Mohit Mishra <mishraloopmohit@gmail.com>
Subject: [PATCH] staging: greybus: gbphy: use sysfs_emit() instead of sprintf()
Date: Sat, 8 Aug 2026 22:43:02 +0530 [thread overview]
Message-ID: <20260808171302.72231-1-mishraloopmohit@gmail.com> (raw)
protocol_id_show() uses sprintf() to format sysfs output into the page
buffer. Convert it to sysfs_emit(), which is the preferred helper for
sysfs show() callbacks as it enforces page boundary checks.
Similar conversions have already been made elsewhere in this subsystem
(e.g. loopback.c, arche-platform.c).
Signed-off-by: Mohit Mishra <mishraloopmohit@gmail.com>
---
drivers/staging/greybus/gbphy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbphy.c
index bdb0f5164a6f..bb9a5b538e6e 100644
--- a/drivers/staging/greybus/gbphy.c
+++ b/drivers/staging/greybus/gbphy.c
@@ -31,7 +31,7 @@ static ssize_t protocol_id_show(struct device *dev,
{
struct gbphy_device *gbphy_dev = to_gbphy_dev(dev);
- return sprintf(buf, "0x%02x\n", gbphy_dev->cport_desc->protocol_id);
+ return sysfs_emit(buf, "0x%02x\n", gbphy_dev->cport_desc->protocol_id);
}
static DEVICE_ATTR_RO(protocol_id);
--
2.43.0
next reply other threads:[~2026-08-08 17:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-08 17:13 Mohit Mishra [this message]
2026-09-01 9:48 ` [PATCH] staging: greybus: gbphy: use sysfs_emit() instead of sprintf() Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260808171302.72231-1-mishraloopmohit@gmail.com \
--to=mishraloopmohit@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.