All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Aaron Kling" <webgeek1234@gmail.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] dt-bindings: display: panel: add Ilitek ILI7836A OLED driver
Date: Sat, 08 Aug 2026 19:06:57 +0000	[thread overview]
Message-ID: <20260808190657.ED1911F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260808-ili7836a-v1-1-07a7becc5636@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The vendor prefix `retroidpocket` used in the new compatible string is not documented in `vendor-prefixes.yaml`.
--

--- Patch [1]: [PATCH 1/2] dt-bindings: display: panel: add Ilitek ILI7836A OLED driver ---
commit aacb89a0d4e50af14a474c3071ac0dce394b199e
Author: Aaron Kling <webgeek1234@gmail.com>

dt-bindings: display: panel: add Ilitek ILI7836A OLED driver
    
This commit introduces a new device tree binding for the Ilitek ILI7836A
OLED driver. It documents the properties and compatible strings required 
for the MIPI-DSI display used on the Retroid Pocket Nova.

> diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili7836a.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili7836a.yaml
> new file mode 100644
> index 0000000000000..962cf257ed8d3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili7836a.yaml
[ ... ]
> +properties:
> +  compatible:
> +    items:
> +      - const: retroidpocket,nova-panel

[Severity: Low]
Is the retroidpocket vendor prefix documented in vendor-prefixes.yaml?
Adding a compatible string with an undocumented vendor prefix will cause a
build warning when running make dt_binding_check.

> +      - const: ilitek,ili7836a
> +
> +  reg:
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260808-ili7836a-v1-0-07a7becc5636@gmail.com?part=1

  reply	other threads:[~2026-08-08 19:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-08 19:01 [PATCH 0/2] drm/panel: add Ilitek ILI7836A panel driver Aaron Kling via B4 Relay
2026-08-08 19:01 ` Aaron Kling
2026-08-08 19:01 ` [PATCH 1/2] dt-bindings: display: panel: add Ilitek ILI7836A OLED driver Aaron Kling via B4 Relay
2026-08-08 19:01   ` Aaron Kling
2026-08-08 19:06   ` sashiko-bot [this message]
2026-08-08 19:01 ` [PATCH 2/2] drm/panel: add Ilitek ILI7836A panel driver Aaron Kling via B4 Relay
2026-08-08 19:01   ` Aaron Kling
2026-08-08 19:16   ` sashiko-bot
2026-08-10  9:58   ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260808190657.ED1911F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=webgeek1234@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.