From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2A552B9BA for ; Sun, 9 Aug 2026 04:06:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786248400; cv=none; b=WE3aFSLifxp4faSYsyhDdFvq38g6O3vylCniS9COToZAtksshSX2InwOKCQvnzEBKEDaqdo6G2iTUj+/ELmvYNSYUDr9DlaYFSKKa39hBZbPwOnHG+VapxIcfYmdRwOOJjUhgBfNV6SJ1XkUokPkghp8RuMWf6pEJZa3b25+2RQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786248400; c=relaxed/simple; bh=4ixdLs0c1oBF5qGMiXD9Shl1pl/8YOexLJkDMeNJ9mY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=TlId0sWj4gSRTJpL8O+TL9p0xw1aBHsTRfVs6sqLx9st7KaaZXnhWoe3ZF+wY1bYU/psfLAkw58zaovqSeSQSrNEBDMsKtQd6IpEbKeFWvBLJuKVKgIDlQx5ZoSMBoTj4EOUQWErc0wL4+wbjGwURT9NLtsilDVeHYQ7qgxV9tQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PGXIjS3g; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PGXIjS3g" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-ca957432c7fso766440a12.1 for ; Sat, 08 Aug 2026 21:06:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786248398; x=1786853198; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ZiwJ3psFmwCDlAOlTSr72jl+HTRZJgSpJDka32BYsbM=; b=PGXIjS3gYxbcqjqhweJkxGcOHH4vc6FKNGvVfAss7XG52jI3mhJZr3WdySkc6OgF/l ZahF/3Rv6uBBRH7dauQfTNifM/tNOdmh/tK/qfFcRNr/lcVLdc6ES3oXmlsGlpSKPZc+ TGb7wMpcOInfncUCrLVNzE+qkq6zOsMYsepkDoSpH8oYuxJ3Be1DJEf7NQflgnyQ5wco 6vyAafAYr2oY3HTU8mrl/Rvn5lHVehs6wx/5bZW+btzmhlQFA0FxQ+Lx0MbebW1MsZFx SKDYte/vFmb81l9Of8Y32Rp2eYMuV3IOdOV6LsRJmPvo1QMzza9NXkK9gEgCQW9QPHcK ft+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786248398; x=1786853198; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZiwJ3psFmwCDlAOlTSr72jl+HTRZJgSpJDka32BYsbM=; b=bzVX2bNPtmrHVkVqBjGyQV1RG5XJLsm/K5PPcuWRdgonP16SI1eZCp3nJDX4nNJ57F ZHuWKdVVqxuSQCCZV4Ob006MPfHPLP2012xCWs3T3Xv/RHE/pJS6Wev+yqkqQ3rEln0/ o3quI/g4WGkOo31/bCtVbRQJPHl3RnFX6qEV/G0AkiTMOfm4DIJeAic3xdjVe4jQnTdQ Q4+7iU9IqoAWxWijV/67BOXfasVzBMyNBk5pOu4u2uxxewHZcK7do7i0/E6QrtZeEbgx D+Hh/8afQOiDfa5cT3c57GOP0B4ZAJGVyeiN9cvHgz7hzB7VJS2YNvde8KcXFRP5/TpH aNKw== X-Forwarded-Encrypted: i=1; AHgh+Rq2eHpkTKffM2lFZrWeNJU4QIKhMrjBDi9LqTiJskU9azn40vVYINjURO4Pg8KwAnMx/eW9TOXGps6JUuo=@vger.kernel.org X-Gm-Message-State: AOJu0YxUbpOcN9CuxNTK1s2Wsr72bBAQM14Ya5ZNte9WRYOB4rpIlJn5 tNTif8JJ95TRJsPr5c66111hvYFBu4WOM9fGNT7v4cJmhjtfQcRnHk7H X-Gm-Gg: AR+sD13Oq7roh3hdSmLAp8ndmKj6dbRxdf4ONWQQ5uX643HRoR995N6NRYyZ6UmPI2b O8mx2qeakvwKNXEAMMQwvxBFBVFRFaDYYl2qpqAXpX8k5dLy5/EdPFEXdV6/VYrqjw+Rgr2G9bO DvfbzJKfDDiWelAdYBYOepogEGsukH4YBDcWrp1GwcJNpkgTXODlV/N70CjNMv05bU1sAOKIdW2 Ro0nhA8skJv8cZmjvBRAQbAuqbiQK5v7feQ2aKYfedFPOtWf6EwtfbzVBpfe2CDquGwdPDzV07Q BrmFqrAU78jI1byJ1z6FOepairk4r5SIfcPv5bS9b0nmwQosaKBsCnEJbCnGGV2b4KsWv1eUUjb qUJVfk4MRPsSta5sFhO54CbsznIlgZ5E3QOQ4Q+4jUpN4DeB1LkDh7h7uFIN648pUILCM3wSeQT wKaHvYPUFfuNgwLmGx9i/mMIKUOzxFhYrwh1TsE+2uI0aBGVwQnjN9M9CNl3sY/bwK0foA7sn2S D9e1xLq3LGWIC3v9xaq4EiyWRpXc3Uod65TAdH0kndf X-Received: by 2002:a05:6300:6bce:20b0:3cb:d5f7:301e with SMTP id adf61e73a8af0-3cbd5f76787mr6226446637.38.1786248397953; Sat, 08 Aug 2026 21:06:37 -0700 (PDT) Received: from deepanshu-kernel-hacker.. ([2405:201:682f:383f:746c:8928:e990:23a8]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-141019a0528sm22608997c88.1.2026.08.08.21.06.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 21:06:36 -0700 (PDT) From: Deepanshu Kartikey To: jikos@kernel.org, bentiss@kernel.org Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Deepanshu Kartikey , syzbot+a942efa43c928a1e3daa@syzkaller.appspotmail.com Subject: [PATCH] HID: core: check field offset before dumping input Date: Sun, 9 Aug 2026 09:36:29 +0530 Message-ID: <20260809040629.12666-1-kartikey406@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit hid_set_field() passes field->usage + offset to hid_dump_input() before validating offset against field->report_count. field->usage is allocated with exactly report_count entries, so a larger offset is read out of bounds before the existing check rejects it: BUG: KASAN: slab-out-of-bounds in hid_dump_input+0xcb/0xd0 Read of size 4 at addr ffff88802ab28fc0 by task kworker/1:2/48 Move the bounds check above the hid_dump_input() call so the function returns before the dereference. Reported-by: syzbot+a942efa43c928a1e3daa@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=a942efa43c928a1e3daa Tested-by: syzbot+a942efa43c928a1e3daa@syzkaller.appspotmail.com Signed-off-by: Deepanshu Kartikey --- drivers/hid/hid-core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index cf123347a2af..7ea1fb62b9d4 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -1933,13 +1933,14 @@ int hid_set_field(struct hid_field *field, unsigned offset, __s32 value) size = field->report_size; - hid_dump_input(field->report->device, field->usage + offset, value); - if (offset >= field->report_count) { hid_err(field->report->device, "offset (%d) exceeds report_count (%d)\n", offset, field->report_count); return -1; } + + hid_dump_input(field->report->device, field->usage + offset, value); + if (field->logical_minimum < 0) { if (value != snto32(s32ton(value, size), size)) { hid_err(field->report->device, "value %d is out of range\n", value); -- 2.43.0