From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F30037A840 for ; Sun, 9 Aug 2026 05:13:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786252395; cv=none; b=qetonFTL8hQb5UYQL+xBF0D/acDDPwv+ZngwPNvX1w/cNcj0MzNsBFd1ixR1PxvRyQL+3bi9y3ZOag8HP5Nvtdtw1E8OEE27OgDz4dE67BX2ryAENVmvIO/EGYtFj11yfRW90TQSdDfBETJprPv+qnJfOUkwPSQk5eKcDhkDtnQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786252395; c=relaxed/simple; bh=weRrChkTJgmtJ7e7uWxoKD+8+f+Z6NRdCPQ7Z7d8o5s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=akborF99LgO5mOTQ/HuZuMyOHa56GPkEzicPAL7fHHADMbP3NEa5OAt9xt/dTswnRpirAX77NbgjdpA2rhtbK7BN0WcAjk2/Oeqx3D8x8A5VaFWKg6VkkI9WcrbzHmsTQM+KiZAUTxWdjry9x05U6lCVrvtZGmtFmcNq+DqlMJk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G73NUjDz; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G73NUjDz" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2cacb8416a1so7718675ad.1 for ; Sat, 08 Aug 2026 22:13:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786252393; x=1786857193; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=deoqn41jn4hqxaXBU0LER8gLC0cAyHmrQg56bcVPpQA=; b=G73NUjDzAM+8ywqX0G1L+oyuZkMG7BRm3WhiC6ifrJUVoHi/atM3M4ijSk7g7qBmhu klI+2DijRnwNKqUUf6Yjr4oYZrCken8EgCmzV8HdmNZ059WJ9VMlDfJPRgJl2v69r+/I 3sRPNZSclWCGogohEqlisc5TD3fGwPQXZtdG96s5tEpzNczGSEoHU3oOB9RKOx7Uugc4 El2VeyT7fjbsonx6JfTiYHsIyHxqL+72F2V++BrdlgjTjQ5TL6K7oTzREecYe56vEt6N 4dXyM1Z6XVSPwn4u4Yp8lEFoKd773idQm7LijgTq0v2XrRDJdUhqwTmoW5DTvMCN3K1x 0ZaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786252393; x=1786857193; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=deoqn41jn4hqxaXBU0LER8gLC0cAyHmrQg56bcVPpQA=; b=J9EmDdsgWl3RqG+eAXyeO18iHafzoD6tWIBq6VBYAB3+sn41DQoVeKgM8uXQA+LBYK VJE/Nl4qQB0i7FcbPQOaQSX4y4zg93bHCyy3HLIJ9BzcJ8DsY35gvF7GPNZLzrRyn60O MMPvb3FDNs8iXrdIgLgSQgQUxVQE56gDAGoTrSi7ED10UmNSTPQsYbnwlJVC7kNlQ4LN vNL8M/o4zj+c46R8doF1s1qxAWNXh6FjXvOh3TUN9GFgQVTxBBud8FENaFr++fdFiZVA ZbuCick6ALrZTOOj1EDw3e2VCIe6KNMWSiB9QuF/7g40D1GCMuGm1rRx6c6c0alLSEhX pQHQ== X-Forwarded-Encrypted: i=1; AHgh+RpcWJNInNstpKe7+igLV0ShHevigdi/ZRuOWoG1S7xUCSg5uBS8rKbO8AhnJVzVIAqW8UL0uoBMI7fp/OM=@vger.kernel.org X-Gm-Message-State: AOJu0YzGrVi6GAXXLZkO2liiHmkxmyTgQ1MdHG7bT/Z4m7MBz1s1e5lP G2yeDsEW0gmEMNaF0l/F/ccNLL8jejuVvKqcqHav/EHUPHjdyOHOe3Yr X-Gm-Gg: AR+sD12olzA4wU+iHBCXQpcji4Ed+ELPx+WnNA4pp132AslAAFwLXk8SBKVxVYATDvc MSlCoGAeevkKbcIfkAK48Rvwks0z06g6EK51zJ5TwTUIdcF1kGLi4X0CwQrT5jVRtXXtL5D2/8w 1uJBPxLMCF8g7xg1mUcW1k5k1u0tR80FQRsmJRjIF73O4WkRhKzBYPHT28BkSvjyy8X4ZO4Qqzr CGZv2PbZ0gvPPVkqZgYWQU8m9+KikfGFop0ozuSyrDLXIqSyPSEyRb1enZwe+bWUEjqx3UlAF4R DHDmdqvm9g2LfTz7Ke1q6TJWgBTj3LmS7hDrRx4HI4YS2fV6f7AlNSLKjEy8tDUhhB2UFkf3hp0 PTWhgZQM2rUXhNECGcf0zlzBgFFU80xlhuytLd3QKPcE3Vm04/iXBZf+8lfvWbf50iIyGJ69DtA X0n3wQ6iRKcVCn2Bmhq26xeVumeFeUUQA7u5RgSWvKD58IVtB8ehlqQ1BluXwwfMvUjlQ6YaqFZ Qi0LKvusfE64F+dZcGX2ynI X-Received: by 2002:a17:902:f608:b0:2ce:d957:59c4 with SMTP id d9443c01a7336-2d2a8692dfamr135589535ad.6.1786252393509; Sat, 08 Aug 2026 22:13:13 -0700 (PDT) Received: from localhost.localdomain ([103.178.204.108]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315be8a7395sm27095702eec.9.2026.08.08.22.13.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 22:13:13 -0700 (PDT) From: Sreeraj S Kurup To: alexander.deucher@amd.com, christian.koenig@amd.com Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, airlied@gmail.com, simona@ffwll.ch, Sreeraj S Kurup Subject: [PATCH v3 2/6] drm/amdgpu/aca: Add upper bounds check in aca_bank_hwip_is_matched Date: Sun, 9 Aug 2026 05:11:56 +0000 Message-ID: <20260809051200.3276-3-sreekuttan2156239@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260809051200.3276-1-sreekuttan2156239@gmail.com> References: <20260809051200.3276-1-sreekuttan2156239@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In aca_bank_hwip_is_matched(), the 'type' parameter is used directly as an array index into aca_hwid_mcatypes[]. The function previously checked whether 'type' was equal to ACA_HWIP_TYPE_UNKNOW, but did not validate whether 'type' was less than ACA_HWIP_TYPE_COUNT or negative. If an invalid or out-of-bounds enum value is passed, an out-of-bounds memory read occurs on the aca_hwid_mcatypes array. Fix this by validating that 'type' is strictly greater than ACA_HWIP_TYPE_UNKNOW and less than ACA_HWIP_TYPE_COUNT before performing the array lookup. Signed-off-by: Sreeraj S Kurup --- drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c index d0d473082431..c76664af9902 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c @@ -138,7 +138,7 @@ static bool aca_bank_hwip_is_matched(struct aca_bank *bank, enum aca_hwip_type t int hwid, mcatype; u64 ipid; - if (!bank || type == ACA_HWIP_TYPE_UNKNOW) + if (!bank || type <= ACA_HWIP_TYPE_UNKNOW || type >= ACA_HWIP_TYPE_COUNT) return false; hwip = &aca_hwid_mcatypes[type]; -- 2.54.0