From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CF8B37AA96 for ; Sun, 9 Aug 2026 05:13:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786252412; cv=none; b=uKsdtK0YsNNyB+YYqrD46A19TYXK50xxS5CZOuAZhHpZxxtH7Ozjw2l/V1WgplA4dGzAVl5tX1pw328UTVTPvX4rw9M3JAGEnLDp1UZMYxORwObZyOBVdAp6NyXjlASZJDu0uyVIuyo60acfhdnfpWcdkqKzTZnrAtbdnfn8WmE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786252412; c=relaxed/simple; bh=HM3bIsBWx6Kxbvo0xciiKgwouz3z/aGaJ1b7nxjummU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ukRhp9Z3imn8ezenyAGk3MDHo5d+74JAHg56FgorRgpun4nh1G1+f34EpLsgAgykE9jdrLbspXNCAT5prPHwsgMew/Q/iIHZWCTi75tLy9gdhv0ZPmZUYrTriAqnis7NpzwojU8Bmn1qWDko869GWGGDGH4ESmY4quEBRCkHqnA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Dy6xakmR; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Dy6xakmR" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-84862b0d5f8so566711b3a.3 for ; Sat, 08 Aug 2026 22:13:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786252410; x=1786857210; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=C8on5LBVsYqwWr9ndoV0oVFp6EULFueLmmkrZV0DJAg=; b=Dy6xakmRHOSMoWoFNK9h4rs/t+bs8l2w1LBko7Q7uttcTCcSHJE1PdQR5eY+XFibc1 lAaC5ZEufV030Sk7jMy95gOkVyvP7YK4n+a/Y05AG5m3eb3Xfv+8wHxROsPnARzkCLJb eeG5EF80Rqpu/sRnD4UwZ9trc71ZDbQ4l8nwHgbA3cZoOB86kzBqyXgAOxhg6ESjT9QD XgSTNSMELULqoVVwrOZYXU655aWB3oS7bIwjUQf8h1QiZNjtegGjJBShSM/VmW8KrMhO 7vbLZBX2/HZkNhPme1DxJO2uEV32l57h+xdWbj6jJ5XBrWs36o4xEpzLAYfeX7sTHGhj AxyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786252410; x=1786857210; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=C8on5LBVsYqwWr9ndoV0oVFp6EULFueLmmkrZV0DJAg=; b=mPPgb5v1axMiB2MYsAxJE2yOI3foMjl/38wGTS6cE1YpoyMcNhNDF/a3o+KoWVeoTi 4a+5E7XO1LOVscxkdSUdwwfJFIKLE6AqXhog9JZiyZSlZ8/6vHhyLu6kU+zxwfgjm3uL NCQcKJWrtyu+ETnE1ETuFgQuFs2ddeFlEnOiIkSgZG0zvV0AQT+o8aRw4w/3nadjLWNY 01JlXJZ6nWrozvWpQ4L59+ycgO8HcaMo+lD/M0pOqPetS+QmKZLRG6R7/acykWuEEwkM Ncrk0RR27gPDpImzwJtOaUI+3U4fUhdevXKUtzCh46KeT6CSJgeyyOga6u3dZ9jtYdl7 OOog== X-Forwarded-Encrypted: i=1; AHgh+RqvbxuJ4JTHexZQKeT8GwrMxSm+MJnPi2MLnuUwbQycA4CaTYr6DUtHEntpah8cAeNg/nR76r4ShOotz9g=@vger.kernel.org X-Gm-Message-State: AOJu0Yzlbi/ihvF6yryita1zhYC+Q2Tqt/FfFXUzMpmUn6dUcR0dozp1 bvt6vgnyq+1aGtJEF8FrnNSj4DDg6QJRkaEa0zIRQk2bGOJOtS6s1CYUtXabgn2d X-Gm-Gg: AR+sD133kRn/iyAmc6CUF1nAZLJqozg4736c/Qx2TQsoO5OI6hDvxZPfk3ej04Y7BG3 +JLTI2ipndgqagePLEBqEr+Fnw917L5jQy4/2Da4n6UqU+Gf0tPyIxy+9wGovnbCA5DWnlmqjNZ panozqsBx8tgyLPHCaR6YBSadCOpNMFqZCZFARiTBemCuwZJhnLtlmTOv9UyksIUh/0oqsKh8H7 5HqAXibPwJj4WS8HtM+bwpXh6gWORroBq53V0BpEo5dpFwP6NBO+j1x2ehxXkj8XGITnZoGdybD 2zKRs1P9ilvqxx3BaMSAT3jEOhOfViUMd75IlnddipYnXuk0KWUEu7/3myPzRXvK/ptqbbcQlui aIz5s6qFbd9uTdVoZmBrdojGQ6kmuBmYFE6pGnLrgtEpqbowk/wScc1o9oLeZREhd5IS1ZfHmBB KXCM5BzWrIU2kpuytX3s9r6n7RoF9kjnqP6vN+x6RtSdrJAPZZulNQ3303d62sp7Qq+TuywdHlY o/ELBSB0oh4 X-Received: by 2002:a05:6a21:3117:b0:3b5:489c:7bb5 with SMTP id adf61e73a8af0-3cbadc97c22mr27425139637.28.1786252410244; Sat, 08 Aug 2026 22:13:30 -0700 (PDT) Received: from localhost.localdomain ([103.178.204.108]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315be8a7395sm27095702eec.9.2026.08.08.22.13.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 22:13:29 -0700 (PDT) From: Sreeraj S Kurup To: alexander.deucher@amd.com, christian.koenig@amd.com Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, airlied@gmail.com, simona@ffwll.ch, Sreeraj S Kurup Subject: [PATCH v3 4/6] drm/amdgpu/aca: Add missing NULL check for banks parameter in aca_banks_add_bank Date: Sun, 9 Aug 2026 05:11:58 +0000 Message-ID: <20260809051200.3276-5-sreekuttan2156239@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260809051200.3276-1-sreekuttan2156239@gmail.com> References: <20260809051200.3276-1-sreekuttan2156239@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit aca_banks_add_bank() verified that the 'bank' parameter was non-NULL, but passed 'banks' directly into list_add_tail(&node->node, &banks->list) and incremented 'banks->nr_banks' without validating whether 'banks' was NULL. Add a NULL check for 'banks' to prevent a kernel NULL pointer dereference if an invalid pointer is passed by a caller. Signed-off-by: Sreeraj S Kurup --- drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c index 06cb3ad1ce62..79326389d75c 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c @@ -49,7 +49,7 @@ static int aca_banks_add_bank(struct aca_banks *banks, struct aca_bank *bank) { struct aca_bank_node *node; - if (!bank) + if (!banks || !bank) return -EINVAL; node = kvzalloc_obj(*node); -- 2.54.0