From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EE5812B94 for ; Sun, 9 Aug 2026 08:49:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786265378; cv=none; b=SQn9QN88g5uBm5B+laZJDRQhowYQS1m3yKWS7m/56adxkGB7CV8a2LE2/rtExxydSeBwkK8OqVtw5/JQP7ZaZK3afF+uH34lG/4E4ksIkUHUDfzE26itd2+3AGa1e/EmEsliOl9HLzoC1xHrrMbfYYl6ucuVYKUMtPFJkZ1GWyo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786265378; c=relaxed/simple; bh=weRrChkTJgmtJ7e7uWxoKD+8+f+Z6NRdCPQ7Z7d8o5s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fFNy7VxZ9ey1aC1Dwgt+web9KjQg5t6bwiZw0KHjhruzVjk0kSe/heWmN4Zt64U8GS6Oh9RUKLXUXRNIwm9VvWl+nhOdNRgr6DBGKvSuoZ+eZBBHNI97QixnzJYqdchQdLyJCcnrMldb/os5L0SkAk4dpH+od49Wm0T6qfAMY3Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gp0yyGzc; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gp0yyGzc" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2caed617615so10848445ad.3 for ; Sun, 09 Aug 2026 01:49:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786265377; x=1786870177; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=deoqn41jn4hqxaXBU0LER8gLC0cAyHmrQg56bcVPpQA=; b=gp0yyGzcwPkxCiqRqFyuJf8wQbqTQbFlox/4Iei4pxSOC5xYGzrwH474bMf9Ngwi/V sQJNktOFt9P/WH16wemjKnNxWKc2vmEsNzOQYB+Upri5po/VaIAZP3yv9wzmcVX4XH6d NT+T6+OHhH3njo+fjsSyuAFMAKKfn4M4OV3iTLbi/74GV65IYUbaMVI6gv+qB6uRJDO4 cV74t6qSEBefS7596hELdeNsUJOZC1rfaVPeCAex5Toyhk8epeLd6RnEr5IK9QwJDoMa dQTeH65SeGBxoKq4rnEVGkQB7MJ1DUlDV4MZJisbrGXWZ/PCpcfhUWKRBX6FWz7AtYok k+AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786265377; x=1786870177; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=deoqn41jn4hqxaXBU0LER8gLC0cAyHmrQg56bcVPpQA=; b=BHMqu72A4ldm3yzPcNwUbrdHmsQXkl5dKgMu8gRczlKXEkOFjyy0Z488l+S3CX3P3Z cuaC/iUuxY0d4XLFjCojaXekvLO5Dju3SVlv1qa+jrmVw+Ecz6NYysFqfY8Wt+C+jaWY kcn/b59HsfqJLs6ZtqW6mZqGma5xLAnw1ifHe2AiVJRTi8sIuqh2Z8MoQE7YK4xJlWPF fJYHoE6E5kz2l1s6eznfZac6spv2iOBcFn1Nvpse03OCltVM2D5ZqJWJaeC+oVkIkth/ lDjCRhunmYZKx931cFumOLdkXvPPMm6we9hoLTb2nDO4vztIa7J9hVvNFvIfEqUjpgmx SuXA== X-Forwarded-Encrypted: i=1; AHgh+RrXCk3a+SS92iCYM7XGFHMPKrYTz8/ifZMdydfTfR/nelxA//+Zbi4kaGRAmlmu/4gtbbi5yRy3BwAxVWo=@vger.kernel.org X-Gm-Message-State: AOJu0YzZEkVFVm1TAE5GsXmsMYmfl0mk8BLtSt1khtxLFGMQhDyNUya7 vtnxRTm3gZmmZQFN7wOm6mVj3vGciEG71Tmo6+97WiB88Lcdk4YBruOZ X-Gm-Gg: AR+sD11SYFM2p2aYWSCf8OsFU3LkR8S4glotkk0QhcUJvs/l9K32dX3hKZ9Z+2E2l5e hO2bqiuBs+yX/nVVaXGV18BxEXNZOalx7CcXsoDLh6Dcn2ULqAQxcRWTNTO8reFG7LUMrLmaKbJ P2kybsckk1EiUDIY0SpTcBA0J5Auua5XLb/aJzBBsxuj+VTQCamgKmsteWOAqrZtzXkJ0D+U75X y8/KQAWBqHv55cySFdMTD9rqbWqakmix4IQVOivYx4J9hk7f3swk/tc3hNX0lEBKQ9S+T9iQGFd YadhN4G1JwHkptR6I/igTwRFPZoKD5GfKiHudcCaoqBZMAxVkffQBheQA4F+6xzNXBldQSPznVz /iOhVJxPfL/8EMwqsXwieRqz7Dxwn58E/q8CGNQWMQyHhQz2YvYGCOnKWMe8tcO5PnBm/E5+oFu FTz0Uj4LUV47DNK7o6tZ3sF/Y+9rFSOBqMaF3iBeE2ImyM1s+4Vrk8ZKm0kGM2ZQqKf2iMoGnjU bsL5aQkRDCIJ8HE38eAiA== X-Received: by 2002:a17:903:46c7:b0:2c9:b48c:fdec with SMTP id d9443c01a7336-2d0ca75d2admr449178665ad.12.1786265376710; Sun, 09 Aug 2026 01:49:36 -0700 (PDT) Received: from localhost.localdomain ([103.178.205.91]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315be86fc7bsm28800025eec.1.2026.08.09.01.49.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Aug 2026 01:49:36 -0700 (PDT) From: Sreeraj S Kurup To: alexander.deucher@amd.com, christian.koenig@amd.com Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, airlied@gmail.com, simona@ffwll.ch, Sreeraj S Kurup Subject: [PATCH v4 2/6] drm/amdgpu/aca: Add upper bounds check in aca_bank_hwip_is_matched Date: Sun, 9 Aug 2026 08:47:31 +0000 Message-ID: <20260809084735.9743-3-sreekuttan2156239@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260809084735.9743-1-sreekuttan2156239@gmail.com> References: <20260809084735.9743-1-sreekuttan2156239@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In aca_bank_hwip_is_matched(), the 'type' parameter is used directly as an array index into aca_hwid_mcatypes[]. The function previously checked whether 'type' was equal to ACA_HWIP_TYPE_UNKNOW, but did not validate whether 'type' was less than ACA_HWIP_TYPE_COUNT or negative. If an invalid or out-of-bounds enum value is passed, an out-of-bounds memory read occurs on the aca_hwid_mcatypes array. Fix this by validating that 'type' is strictly greater than ACA_HWIP_TYPE_UNKNOW and less than ACA_HWIP_TYPE_COUNT before performing the array lookup. Signed-off-by: Sreeraj S Kurup --- drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c index d0d473082431..c76664af9902 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c @@ -138,7 +138,7 @@ static bool aca_bank_hwip_is_matched(struct aca_bank *bank, enum aca_hwip_type t int hwid, mcatype; u64 ipid; - if (!bank || type == ACA_HWIP_TYPE_UNKNOW) + if (!bank || type <= ACA_HWIP_TYPE_UNKNOW || type >= ACA_HWIP_TYPE_COUNT) return false; hwip = &aca_hwid_mcatypes[type]; -- 2.54.0