From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 199EE72621 for ; Sun, 9 Aug 2026 08:49:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786265394; cv=none; b=Bdc+9pQHhF7E8epT0kh2rZNlvAavSIUKwEa3ZNHcMXUzd+S4PGQ/4FvmGlVbf+U0hO7zKoN3aW7edIhKCfwiqO6MOZ536WQNfGywQmd5Eaemg8k66edfTzhrW0cXeKccCUA0yId0BrIHvFuGQf5zas2RLk73LL4fKtRJcEKJCEc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786265394; c=relaxed/simple; bh=AqxQ50uRgfqSVhDzNOAr9tvvTNsoXCcljj0EkkQ8A3g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cL/l0Sv2tPy/yCfZ1Vkq74M01D9kQGQHaylBxNagu5FUGHlgesyh1wgS2Mb+t5BKu0z/NN4mh7KgjEXyPVTGAg2Xh3xd4C0q/oAU+VAgfQXmG5rZOu0bchW7dEKiGytVmtMT/owqIpyl1Fzh/KOvk564miQmEFlasaAoWEPS6x0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TtOuSM1t; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TtOuSM1t" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-381c51fde6bso1053387a91.2 for ; Sun, 09 Aug 2026 01:49:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786265392; x=1786870192; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=yOuPd/8nIM02AL24kWbQs53dFhNPEGw5UKtvK4sm+fI=; b=TtOuSM1tgFXj33o8mc6VOXr5eghtYsUaAIZbQTg8TayM37WvbcUux+05K8Lj1LzsVl E4VtXg6YwbmCa+1KZym4nWEBalpo/f6xzEL6mVFfeiIfBnPSif9Pbt9sTTrbPr30frCX Xr97NAYW1Sx/7KzX50ZFSYnr8o6I/c46W6GiyvFo/nVbzKEya/g/JAZ+XOGg64I8T6kX w6nq0+DHk4xRlIBYDl8JZRvH8PwLaMDqCRXecW6AkCEX3TWDZz9dS5rDqlAdghcm+bCP ccIMlnYJtbwZ+Shl+OdLGFBd/FaV+kJY8L5lfnjUHSl+bHu+GJeyPE1NRQkNyHqsV9f0 w+qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786265392; x=1786870192; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=yOuPd/8nIM02AL24kWbQs53dFhNPEGw5UKtvK4sm+fI=; b=eb+0/g4Boywgf3T8/NhfEoONZZfxk0r+9r6OgI+md9pNRS0hHnaoalkag49bHVTJWt 2WLU+X+mr6Sqbc71HWasfjrB/db1+FIFbU9prdZCBmdkbKA5OtJ5B2lbRQvhvhAc0FZe AnwhJhwHTKBfkkwi6xpXV2AoDcOW6QU0DRdowsEmurNw5oaCU7FXa/KGXcJ1rb1vRGk3 iyICx+JO/uabYj85HMqfu7EPcjZ5kiCBNmMGbOD8kpE/LOhMO+d6ZZOK0za2cFf7Z1gi OV9A3lhCABN6O2L/OLF74oRO7fzGYQszLs8XJNulHUtg6yd/iD0AE93/0pElTNRGaUon j5yg== X-Forwarded-Encrypted: i=1; AHgh+Rp5XQvUHe5YCf2LsV55kn0tXwiAG5tBbZLoiUY/YAxPciRLMtsoNVnSTYFk9V0ghZml4zIosYShvPPGync=@vger.kernel.org X-Gm-Message-State: AOJu0YxEaLUmpTAjXL8Rb8z8w2P1Q5g2pyxgUTMwiWRshVMnLDE4UsHq q/eq4N6KOsC2j2lSQR6WTjHzilRYx+SzzIa4eKPWH1hOBl6UbgIeL/Ne9xbxng== X-Gm-Gg: AR+sD10vmuGepnjcQK/5ayGDG5zbWuD3RD1l7hS1UdDvVra29D2cKFnYgvxT6ppO0sl zzII25Op0n0uzjWe+d2i/GVhRrlGomMH618F3w+EMSinoJ4oJUMG2PlD6f2FNJlmN84u8l7x1lu FB1l0irbA8pwY7V6Rajl+YvhRm3ad+j+7oXJKNzVIzrasLbvhtHyy1m4hkom0WB9vfC7VUiUXgx 0npreqrUREx0jN+10iDuqaVB8hHhMpkgnyZtSHU+CygBUpbC/8S+cYt+SbItInEozQHZBrOls2J cUs4s0+tqmN4mj023t5BoJCoeZGO9Loy5g6hlDnp7Y89QY/Tnm9UydTRDc+oS4WYcXn7Z4FrmGY fm4rchTYG8dxON/Kb3Has8IaWhWcjx0bOLemKH3sv2iSntjyc2/CM2k/H276xqtqnVpgruzkqRD BUU2yCCvMk/BSO5wz1JNZxWGhs69R5l3aTRNU2bCU8RRgrHn9aeddTW/JtYXMQ2ftoWOZbfkqX0 IRnKuqV8Gs= X-Received: by 2002:a05:6a20:1602:b0:3b1:cce5:9140 with SMTP id adf61e73a8af0-3cbce98a610mr14359456637.33.1786265392386; Sun, 09 Aug 2026 01:49:52 -0700 (PDT) Received: from localhost.localdomain ([103.178.205.91]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315be86fc7bsm28800025eec.1.2026.08.09.01.49.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Aug 2026 01:49:51 -0700 (PDT) From: Sreeraj S Kurup To: alexander.deucher@amd.com, christian.koenig@amd.com Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, airlied@gmail.com, simona@ffwll.ch, Sreeraj S Kurup Subject: [PATCH v4 4/6] drm/amdgpu/aca: Add missing NULL check for banks parameter in aca_banks_add_bank Date: Sun, 9 Aug 2026 08:47:33 +0000 Message-ID: <20260809084735.9743-5-sreekuttan2156239@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260809084735.9743-1-sreekuttan2156239@gmail.com> References: <20260809084735.9743-1-sreekuttan2156239@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit aca_banks_add_bank() verified that the 'bank' parameter was non-NULL, but passed 'banks' directly into list_add_tail(&node->node, &banks->list) and incremented 'banks->nr_banks' without validating whether 'banks' was NULL. Add a NULL check for 'banks' to prevent a kernel NULL pointer dereference if an invalid pointer is passed by a caller. Signed-off-by: Sreeraj S Kurup --- drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c index c35f6be2ef77..dcddeb381628 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c @@ -49,7 +49,7 @@ static int aca_banks_add_bank(struct aca_banks *banks, struct aca_bank *bank) { struct aca_bank_node *node; - if (!bank) + if (!banks || !bank) return -EINVAL; node = kvzalloc_obj(*node); -- 2.54.0