From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC37C264A97 for ; Sun, 9 Aug 2026 14:46:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786286807; cv=none; b=StEE7+uwXld4Dk6zUoAfW7GW/fisga5zYB1D2jC46iDs/UL6jOl1pABTEKiq5t7p3PpkagbrCBmM1MgDeU8jKcYnog8O7+hxnfQhQnt86pkEINmIUOuU48nbNnfxm9UP38uZuAk8OoLGd4LSYHzKIDUw/uxVsxZWlnsVLLY45Mg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786286807; c=relaxed/simple; bh=weRrChkTJgmtJ7e7uWxoKD+8+f+Z6NRdCPQ7Z7d8o5s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QTQJTNyEl98NI5q0hy6AJukBmYTjo9VUjIPbx9ivfpZj5XOl4A0aIDZl21S7gIoXC+i5aD5T+Lnp3zs8dDC/rWhUM2MjGTRgabVpsSFwHQXMVWFxHeHx4Hhj6/JKD5FJuT0UlJRYBRb8dSg77HnbdpuuMk4fg0G0/3e2fToZWqo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BdlfavfA; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BdlfavfA" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-38dc69c74b8so965165a91.0 for ; Sun, 09 Aug 2026 07:46:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786286805; x=1786891605; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=deoqn41jn4hqxaXBU0LER8gLC0cAyHmrQg56bcVPpQA=; b=BdlfavfAr5Q/EoL1nnX4pnzSVWlt+JSLfL7tjJa7sQgWVUKcUf6KJUGqcNUG1J8LJE RV/KEy2iTqdvSN+VvZObZ8uhfKsGP2ruydvtd1J/74tIZtuv6zBgu7ZLUulOIAbDUVr6 aWmwenfsB9GZVHDEPFxvDGrtbyKpg3iKxQ8/bIGVpQ7a+7DPDxHU5OxNuvhizxgqzqMT WOlEddDYLBOLPo1qREsfB2C2Dkx01JIlpKXufimAz2S+zG8zQH64dJNxshcelGiI6Rm0 7CUd14I5HOk/qG/TnanhNehUg6ZyedSQ4I9x3cehsuhJCUqGlNpFTfTZdqL4chdIwKH3 E15A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786286805; x=1786891605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=deoqn41jn4hqxaXBU0LER8gLC0cAyHmrQg56bcVPpQA=; b=FKVyCx9rCF5rS5reYwWz5/W/4Ohg+v/mJRcUtuRW9wojQEQ/3ODkcVF6Mz0a+PWof+ Z0shtsto7ozlt1uQlt8fGHz6/UbABCpRn5Yux02d4hYnkIl4lf2qTeFWqFeLrHHp9ydn WEr69uQw+uKV6aCm97SXmoQKY5PzsT1eymKXmS0uK3BMgyaDlDSYECFbz37TQWnqMC2V mb20fqjaUnkX8m31Ukq/5YJ9nUbGmvHWQvWlwa/cBnhHv43dgkbka2iX3UMxffD5VeGS NKwFMxoy/Njey2knu9jHKl6ywzsnC8xtep+UN2XBALJm1NudXSbE44Qzn+jbtgbGvgMG 0sEg== X-Forwarded-Encrypted: i=1; AHgh+RpN1yWndaEKUDRSExhvjMRhiMtqxR1TPVZfE5Hb/v27MXo8fvV9HzPZdFBDSD7BhGCsPKn2dX8u3OgJ33o=@vger.kernel.org X-Gm-Message-State: AOJu0YxsZ//tRVGOfTvAmzb9Uz9m2IgSOeDqPFQitUxT3rgGk3VMcrD1 SRFnZMPPDFzgboQ3gfYc3pz/sqtrP3fbxe5EXqf+qZjwTZXmWMmGAKBA X-Gm-Gg: AR+sD10QjK8ttaafOwg2y9zzHZMaRP6bSMHKrOamhOfIHPwjqr8+X/DI+4tPUK6WuoW WKj4lZK3dXT7W6qbbmpuyV62QuwciQq7/2Eh0FY5EXEGDAEdEo7ZGk6OOBJa10Vd5VE+YMsAiR5 3cXzObNDixujHkK27Q3jH1UEPLV/q3zD1t7ozyvzli9VmgkrkbPKmdPoLqKQ4X9mDw5NMpnzMq5 UC11tk8oBoDRN3atwOoZ1aYeDTuNSwYwtAMRmL0IN1CQng1hVnCL8pE2z5LEAOSvL2PJFDGTNv5 26R+Jj8V9XNFAuUZRR0FK1+lbKCc7f4gte20PA/+3wljJysPpnYe+QGUwtHc6ri4vkB4Y0ZsOdn 6EUqZD+lADKTjwCpdruMJVt9VMnwQoj3yswqBoNOmWXQetWJo9ZSZUm/UdP2uSX4fh3AxAIryOu 8X0N2rpYZudmhLfuOb2Ctk25ii4/GxM+yGJ1ZM9qUztX16xGVwFlodklPmWj2GFdpV13Vnpf4JD DqbFWgKdAjqXKy1QChrHg== X-Received: by 2002:a17:90a:d010:b0:38d:eaec:4396 with SMTP id 98e67ed59e1d1-3903c58bdd2mr36617260a91.11.1786286805186; Sun, 09 Aug 2026 07:46:45 -0700 (PDT) Received: from localhost.localdomain ([103.178.205.91]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-14101b7ad29sm25911224c88.13.2026.08.09.07.46.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Aug 2026 07:46:44 -0700 (PDT) From: Sreeraj S Kurup To: alexander.deucher@amd.com, christian.koenig@amd.com Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, airlied@gmail.com, simona@ffwll.ch, Sreeraj S Kurup Subject: [PATCH v5 2/4] drm/amdgpu/aca: Add upper bounds check in aca_bank_hwip_is_matched Date: Sun, 9 Aug 2026 14:44:49 +0000 Message-ID: <20260809144451.35431-3-sreekuttan2156239@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260809144451.35431-1-sreekuttan2156239@gmail.com> References: <20260809144451.35431-1-sreekuttan2156239@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In aca_bank_hwip_is_matched(), the 'type' parameter is used directly as an array index into aca_hwid_mcatypes[]. The function previously checked whether 'type' was equal to ACA_HWIP_TYPE_UNKNOW, but did not validate whether 'type' was less than ACA_HWIP_TYPE_COUNT or negative. If an invalid or out-of-bounds enum value is passed, an out-of-bounds memory read occurs on the aca_hwid_mcatypes array. Fix this by validating that 'type' is strictly greater than ACA_HWIP_TYPE_UNKNOW and less than ACA_HWIP_TYPE_COUNT before performing the array lookup. Signed-off-by: Sreeraj S Kurup --- drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c index d0d473082431..c76664af9902 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c @@ -138,7 +138,7 @@ static bool aca_bank_hwip_is_matched(struct aca_bank *bank, enum aca_hwip_type t int hwid, mcatype; u64 ipid; - if (!bank || type == ACA_HWIP_TYPE_UNKNOW) + if (!bank || type <= ACA_HWIP_TYPE_UNKNOW || type >= ACA_HWIP_TYPE_COUNT) return false; hwip = &aca_hwid_mcatypes[type]; -- 2.54.0