Re: [PATCH 1/2] dt-bindings: arm: qcom: Add Xiaomi Mi 8 family compatibles

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The compatible string `xiaomi,dipper` is added to two mutually exclusive schema blocks with conflicting constraints, allowing incomplete compatible lists to silently pass validation.
--

--- Patch [1]: [PATCH 1/2] dt-bindings: arm: qcom: Add Xiaomi Mi 8 family compatibles ---
commit 303d802416f225c92da471f33c7f3f2a3dcb2b9c
Author: David Heidelberg <david@ixit.cz>
dt-bindings: arm: qcom: Add Xiaomi Mi 8 family compatibles

This commit adds device tree binding compatibles for the Xiaomi Mi 8 smartphone
family, codenamed dipper, and documents variants such as ursa and equuleus.

> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index ff8a35df7862d..6309f8ab02fba 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -950,6 +950,15 @@ properties:
>            - const: google,bonito
>            - const: qcom,sdm670
>  
> +      - description: Xiaomi Mi 8 family
> +        items:
> +          - enum:
> +              - xiaomi,dipper
> +              - xiaomi,equuleus
> +              - xiaomi,ursa
> +          - const: xiaomi,dipper-common
> +          - const: qcom,sdm845
> +

[ ... ]

> @@ -976,6 +985,7 @@ properties:
>                - sony,akatsuki-row
>                - sony,apollo-row
>                - thundercomm,db845c
> +              - xiaomi,dipper
>                - xiaomi,polaris
>            - const: qcom,sdm845

[Severity: Medium]
Was xiaomi,dipper mistakenly added to this 2-element block as well?

Since xiaomi,dipper is already defined in the 3-element Xiaomi Mi 8 family
block above, adding it here introduces a regression in schema validation.
A device tree using an incomplete compatible array like 
["xiaomi,dipper", "qcom,sdm845"] will pass schema validation by matching this
block, completely bypassing the requirement for the "xiaomi,dipper-common"
fallback string.

Would removing it from this generic list ensure the intermediate fallback is
properly enforced for the dipper board?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260809-dipper-v1-0-eb4d501e85df@ixit.cz?part=1