All of lore.kernel.org
 help / color / mirror / Atom feed
From: phucduc.bui@gmail.com
To: Eric Piel <eric.piel@tremplin-utc.net>,
	Hans de Goede <hansg@kernel.org>,
	ilpo.jarvinen@linux.intel.com, Zha Qipeng <qipeng.zha@intel.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
	Andy Shevchenko <andy@kernel.org>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	bui duc phuc <phucduc.bui@gmail.com>
Subject: [PATCH 2/3] platform/x86: intel: punit_ipc: Propagate errors from optional IRQ lookup
Date: Mon, 10 Aug 2026 12:26:24 +0700	[thread overview]
Message-ID: <20260810052625.27614-2-phucduc.bui@gmail.com> (raw)
In-Reply-To: <20260810052625.27614-1-phucduc.bui@gmail.com>

From: bui duc phuc <phucduc.bui@gmail.com>

platform_get_irq_optional() returns a positive IRQ number on success or
a negative error code on failure. For an optional IRQ, -ENXIO indicates
that no optional IRQ is available and the driver can fall back to polling
mode. Other errors should be propagated so that the caller can handle
them appropriately.

Treat -ENXIO as the only case where the driver falls back to polling
mode, and propagate all other errors returned by
platform_get_irq_optional().

Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
 drivers/platform/x86/intel/punit_ipc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/platform/x86/intel/punit_ipc.c b/drivers/platform/x86/intel/punit_ipc.c
index 6d770b950dfb..590b145fd5ca 100644
--- a/drivers/platform/x86/intel/punit_ipc.c
+++ b/drivers/platform/x86/intel/punit_ipc.c
@@ -245,6 +245,8 @@ static int intel_punit_ipc_probe(struct platform_device *pdev)
 
 	irq = platform_get_irq_optional(pdev, 0);
 	if (irq < 0) {
+		if (irq != -ENXIO)
+			return irq;
 		dev_warn(&pdev->dev, "Invalid IRQ, using polling mode\n");
 	} else {
 		ret = devm_request_irq(&pdev->dev, irq, intel_punit_ioc,
-- 
2.43.0


  reply	other threads:[~2026-08-10  5:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-10  5:26 [PATCH 1/3] platform/x86: hp: hp_accel: Propagate errors from optional IRQ lookup phucduc.bui
2026-08-10  5:26 ` phucduc.bui [this message]
2026-08-10  7:00   ` [PATCH 2/3] platform/x86: intel: punit_ipc: " Andy Shevchenko
2026-08-11  3:30     ` Bui Duc Phuc
2026-08-12  6:18       ` Andy Shevchenko
2026-08-10  5:26 ` [PATCH 3/3] platform/x86: intel_scu_ipc: Handle " phucduc.bui
2026-08-10  7:04   ` Andy Shevchenko
2026-08-10  6:50 ` [PATCH 1/3] platform/x86: hp: hp_accel: Propagate " Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260810052625.27614-2-phucduc.bui@gmail.com \
    --to=phucduc.bui@gmail.com \
    --cc=andy@kernel.org \
    --cc=eric.piel@tremplin-utc.net \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=qipeng.zha@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.