Re: [PATCH v4 3/7] dt-bindings: iio: light: ltr501: Add ltr329 compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The schema allows the `interrupts` and `proximity-near-level` properties for `liteon,ltr329`, despite the hardware lacking support for both.
--

--- Patch [3]: [PATCH v4 3/7] dt-bindings: iio: light: ltr501: Add ltr329 compatible ---
commit 886ebb6ac5c09271398d18cea2c0a6d6d1bb9043
Author: Esben Haabendal <esben@geanix.com>

dt-bindings: iio: light: ltr501: Add ltr329 compatible

This commit adds a new compatible string for the LTR-329ALS-01 ambient
light sensor. The commit message notes that it is similar to LTR-303ALS-01
but without interrupt support.

> diff --git a/Documentation/devicetree/bindings/iio/light/liteon,ltr501.yaml b/Documentation/devicetree/bindings/iio/light/liteon,ltr501.yaml
> index 6234e2eaec2e4..8c9d6cee55b49 100644
> --- a/Documentation/devicetree/bindings/iio/light/liteon,ltr501.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/liteon,ltr501.yaml
> @@ -17,6 +17,7 @@ properties:
>      enum:
>        - liteon,ltr301
>        - liteon,ltr303
> +      - liteon,ltr329

[Severity: Medium]
Since the commit message explicitly states that the LTR-329ALS-01 does not
have interrupt support, should the schema actively disallow the interrupts
property for this specific compatible string?

Currently, because interrupts and proximity-near-level are defined globally
in this schema, validation will silently pass if a device tree node for
liteon,ltr329 incorrectly includes them.

Could an allOf rule be added to restrict these unsupported properties?

  allOf:
    - if:
        properties:
          compatible:
            contains:
              const: liteon,ltr329
      then:
        properties:
          interrupts: false
          proximity-near-level: false

>        - liteon,ltr501
>        - liteon,ltr559

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260810-liteon-ltr329-v4-0-8bd3dfd15280@geanix.com?part=3