From: Vladimir Oltean <olteanv@gmail.com>
To: Jonas Gorski <jonas.gorski@gmail.com>
Cc: Semih Baskan <strst.gs@gmail.com>,
florian.fainelli@broadcom.com, andrew@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, vladimir.oltean@nxp.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: dsa: b53: be VLAN unaware when not filtering
Date: Mon, 10 Aug 2026 15:04:42 +0300 [thread overview]
Message-ID: <20260810120442.255nahzmurjhi5jn@skbuf> (raw)
In-Reply-To: <CAOiHx=kqmZSM2Vzusc_bcpJfTjJC=jYPgU3wnz_xX+_nnuiNtw@mail.gmail.com>
On Thu, Aug 06, 2026 at 01:09:03PM +0200, Jonas Gorski wrote:
> > static int b53_arl_rw_op(struct b53_device *dev, unsigned int op)
> > {
> > u8 reg;
> >
> > if (op > ARLTBL_RW)
> > return -EINVAL;
> >
> > b53_read8(dev, B53_ARLIO_PAGE, B53_ARLTBL_RW_CTRL, ®);
> > reg |= ARLTBL_START_DONE;
> > if (op)
> > reg |= ARLTBL_RW;
> > else
> > reg &= ~ARLTBL_RW;
> > if (dev->vlan_enabled)
> > reg &= ~ARLTBL_IVL_SVL_SELECT;
> > else
> > reg |= ARLTBL_IVL_SVL_SELECT;
>
> This ARLTBL_IVL_SVL_SELECT bit is only implemented for a small subset
> of switches (bcm5302x / bcm58* and bcm53134). Additionally, according
> to the register description, this also requires enabling "per port
> IVL/SVL" mode, which is not enable by b53. The description of that
> also says that the VIDs used in SVL ports must not be used in IVL
> ports. No idea what the consequences are if they do.
What does enabling per port IVL/SVL mode do?
next prev parent reply other threads:[~2026-08-10 12:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 7:26 [PATCH net] net: dsa: b53: be VLAN unaware when not filtering Semih Baskan
2026-08-05 7:44 ` Jonas Gorski
2026-08-05 9:50 ` Semih Baskan
2026-08-06 10:23 ` Vladimir Oltean
2026-08-06 11:08 ` Semih Baskan
2026-08-06 11:09 ` Jonas Gorski
2026-08-10 12:04 ` Vladimir Oltean [this message]
2026-08-11 8:06 ` Jonas Gorski
2026-08-11 16:13 ` Florian Fainelli
2026-08-12 20:50 ` Vladimir Oltean
2026-08-12 22:06 ` Vladimir Oltean
2026-08-12 22:28 ` Florian Fainelli
2026-08-13 7:08 ` Jonas Gorski
2026-08-13 10:39 ` Semih Baskan
2026-08-13 11:34 ` Semih Baskan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260810120442.255nahzmurjhi5jn@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=jonas.gorski@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=strst.gs@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.