From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F717C5AC82 for ; Mon, 10 Aug 2026 12:07:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6pKJKDrY0ff3wzabgjd8FXrZcsAQ5SdSxfaUjszD+xQ=; b=H6VrUDuiBJDhau +MimggMqkfamP1AaykmyVA5sZbgj53EeXKZMksbUmjOkYYBGEGmLn09k/GFKmaxSBjkk+U1vzy6vx gmSLb6ITNc7jErVF4/yfAZuMCOk6UEix07p33kZgwMT6tufWHKDKVr7nrLfPF1kr50U0qGQspoAY+ upnTMfDDNG8I8sIbWIVZPr7qJtRzw7eeLVPk/7CxS6hVcLr1W/iAy5h+fAMVoJQJZ3nYPRXyS3vm5 uq9k6uDWBq/611uGrytuTcQqzjuys9VRv44xJd8UQS4H9M6jeeK4zxEOwxV9+/VUvkkQIy6EAbcWE dj741B9dZmn9Epu5gh2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wtOmo-0000000Bgsn-3Vh2; Mon, 10 Aug 2026 12:07:22 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wtOmn-0000000Bgsd-06FS for linux-phy@lists.infradead.org; Mon, 10 Aug 2026 12:07:21 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 443B9600DA; Mon, 10 Aug 2026 12:07:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3AD161F00A3A; Mon, 10 Aug 2026 12:07:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786363639; bh=YRHPFMgdaA0yiUbbK8fEIq4YxUNO4dVldMnmHB8GPGU=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=V7Skn+yotrckp+a0sTthvv3EhH3kYOIhz7IjmBJQ3qQnWkxmOyq+j9p7/P5Ugmad6 tqiZjC7vyyrGBMgot7ExPA7aAcrG0RW33BoukRJAO9PZs6wzeFL32tPmFyIrMm+QN7 7rq71ozSCPVG2lL4fuEx8D+KyNnGrlozBOpiHuGqWJK9PaMs/tCSV3yVbtpRKyk7M/ 9GrV98LcLEgP6ipRQMuEoTwV7Zc9PmgiAzAc9UJk7o4rimUGFKVXpIjSEIKgNxFnke br29Xc8j5fRmKNnaRzLzZ/vUJAHUgUPjciKnqH/8x7PyZhPluFJvsfNEgmjkHj+Fay RkHIeAK+Yhx5Q== From: sashiko-bot@kernel.org Subject: Re: [PATCH 10/10] ARM: dts: qcom: apq8074-dragonboard: enable the USB3 host To: "Dmitry Baryshkov" Cc: vkoul@kernel.org, neil.armstrong@linaro.org, robh@kernel.org, linux-phy@lists.infradead.org, olteanv@gmail.com, devicetree@vger.kernel.org, conor+dt@kernel.org In-Reply-To: <20260810-msm8974-usb3-v1-10-1a47e1185524@oss.qualcomm.com> References: <20260810-msm8974-usb3-v1-0-1a47e1185524@oss.qualcomm.com> <20260810-msm8974-usb3-v1-10-1a47e1185524@oss.qualcomm.com> Date: Mon, 10 Aug 2026 12:07:17 +0000 Message-Id: <20260810120718.3AD161F00A3A@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg NCBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIFRoZSBgcmVzZXQtZ3Bp b3NgIGFuZCBgdmRkLXN1cHBseWAgcHJvcGVydGllcyBmb3IgdGhlIFVTQiBodWJzIGFuZCBwZXJp cGhlcmFscyB3aWxsIGJlIGNvbXBsZXRlbHkgaWdub3JlZCBiZWNhdXNlIHRoZWlyIGNvbXBhdGli bGUgc3RyaW5ncyBhcmUgbm90IHN1cHBvcnRlZCBieSB0aGUga2VybmVsJ3Mgb25ib2FyZCBVU0Ig ZGV2IGRyaXZlci4KLSBbSGlnaF0gYHFjb21faXBxODA2eF91c2JfaHNfcGh5X2luaXQoKWAgb3Zl cndyaXRlcyB0aGUgZW50aXJlIGBIU1VTQl9QSFlfQ1RSTF9SRUdgLCBkZXN0cm95aW5nIGJvb3Rs b2FkZXItY29uZmlndXJlZCBmcmVxdWVuY3kgc3RyYXBzIGZvciBNU004OTc0LgotIFtIaWdoXSBT dXBlclNwZWVkIFVTQiBkZXZpY2VzIChBWDg4MTc5IGFuZCBQTDI3NzUpIGFyZSBpbmNvcnJlY3Rs eSBuZXN0ZWQgdW5kZXIgdGhlIEhpZ2hTcGVlZCBodWIgKGBodWJfMl8wYCkgaW5zdGVhZCBvZiB0 aGUgU3VwZXJTcGVlZCBodWIgKGBodWJfM18wYCkuCi0gW0hpZ2hdIFRoZSBTdXBlclNwZWVkIGh1 YiAoYGh1Yl8zXzBgKSBpcyBhc3NpZ25lZCBhbiBpbnZhbGlkIHBvcnQgYWRkcmVzcyAoYHJlZyA9 IDwyPmApLCBicmVha2luZyBEVCBub2RlIG1hcHBpbmcgZm9yIGJvdGggcm9vdCBodWJzLgotLQoK LS0tIFBhdGNoIFsxMF06IFtQQVRDSCAxMC8xMF0gQVJNOiBkdHM6IHFjb206IGFwcTgwNzQtZHJh Z29uYm9hcmQ6IGVuYWJsZSB0aGUgVVNCMyBob3N0IC0tLQpjb21taXQgMzE2YjhiMWJiZmQyY2Fi ZTY2ZmUwMjkzZjllZDYxZTNhNDhlYzE5NwpBdXRob3I6IERtaXRyeSBCYXJ5c2hrb3YgPGRtaXRy eS5iYXJ5c2hrb3ZAb3NzLnF1YWxjb21tLmNvbT4KCkFSTTogZHRzOiBxY29tOiBhcHE4MDc0LWRy YWdvbmJvYXJkOiBlbmFibGUgdGhlIFVTQjMgaG9zdAoKVGhlIFVTQjMgcG9ydCBvZiB0aGUgZHJh Z29uYm9hcmQgZHJpdmVzIHRoZSBvbmJvYXJkIFRVU0I4MDQwQSBodWIgd2l0aAp0aGUgQVg4ODE3 OSBHYkUgY29udHJvbGxlciBhbmQgdGhlIFBMMjc3NSBVU0ItU0FUQSBicmlkZ2UgYmVoaW5kIGl0 LgpUaGlzIGNvbW1pdCBlbmFibGVzIHRoZSBEV0MzIGNvbnRyb2xsZXIgaW4gaG9zdCBtb2RlIGFs b25nIHdpdGggaXRzIFBIWXMKYW5kIGRlc2NyaWJlcyB0aGUgb25ib2FyZCBjaGFpbiBhcyBkZXZp Y2Ugbm9kZXMgdW5kZXIgdGhlIGNvbnRyb2xsZXIuCgo+IGRpZmYgLS1naXQgYS9hcmNoL2FybS9i b290L2R0cy9xY29tL3Fjb20tYXBxODA3NC1kcmFnb25ib2FyZC5kdHMgYi9hcmNoL2FybS9ib290 L2R0cy9xY29tL3Fjb20tYXBxODA3NC1kcmFnb25ib2FyZC5kdHMKPiAtLS0gYS9hcmNoL2FybS9i b290L2R0cy9xY29tL3Fjb20tYXBxODA3NC1kcmFnb25ib2FyZC5kdHMKPiArKysgYi9hcmNoL2Fy bS9ib290L2R0cy9xY29tL3Fjb20tYXBxODA3NC1kcmFnb25ib2FyZC5kdHMKClsgLi4uIF0KCj4g KwkvKiBUSSBUVVNCODA0MEEgZm91ciBwb3J0IGh1YiAqLwo+ICsJaHViXzJfMDogaHViQDEgewo+ ICsJCWNvbXBhdGlibGUgPSAidXNiNDUxLDgwNDMiOwoKW1NldmVyaXR5OiBIaWdoXQpXaWxsIHRo ZSByZXNldC1ncGlvcyBhbmQgdmRkLXN1cHBseSBwcm9wZXJ0aWVzIGJlIGlnbm9yZWQgaGVyZT8K ClRoZSBuZXcgY29tcGF0aWJsZSBzdHJpbmdzICh1c2I0NTEsODA0MywgdXNiNDUxLDgwNDEsIHVz YjY3YiwyNzc1LAp1c2JiOTUsMTc5MCkgZG8gbm90IGFwcGVhciB0byBiZSBzdXBwb3J0ZWQgYnkg dGhlIG9uYm9hcmRfdXNiX2RldiBkcml2ZXIncwpvbmJvYXJkX2Rldl9tYXRjaCBhcnJheS4gVGhl IGdlbmVyaWMgVVNCIGNvcmUgcGFyc2VzIHRoZXNlIG5vZGVzIGJ1dCBkb2VzCm5vdCBuYXRpdmVs eSBoYW5kbGUgcmVzZXQtZ3Bpb3MuCgpDb3VsZCB0aGlzIGNhdXNlIHRoZSByZXNldCBsaW5lcyB0 byBmbG9hdCBhbmQgcG93ZXIgc2VxdWVuY2luZyB0byBiZQp1bm1hbmFnZWQsIHByZXZlbnRpbmcg cHJvcGVyIGVudW1lcmF0aW9uPwoKPiArCQlyZWcgPSA8MT47Cj4gKwkJcGVlci1odWIgPSA8Jmh1 Yl8zXzA+Owo+ICsJCXJlc2V0LWdwaW9zID0gPCZwbTg5NDFfZ3Bpb3MgNiBHUElPX0FDVElWRV9M T1c+Owo+ICsJCXZkZC1zdXBwbHkgPSA8JnB3cl9jXzNwMz47Cj4gKwkJI2FkZHJlc3MtY2VsbHMg PSA8MT47Cj4gKwkJI3NpemUtY2VsbHMgPSA8MD47Cj4gKwo+ICsJCS8qIFByb2xpZmljIFBMMjc3 NSBVU0ItU0FUQSBicmlkZ2Ugb24gdGhlIEROMCBwb3J0ICovCj4gKwkJZGV2aWNlQDEgewo+ICsJ CQljb21wYXRpYmxlID0gInVzYjY3YiwyNzc1IjsKCltTZXZlcml0eTogSGlnaF0KQXJlIHRoZSBT dXBlclNwZWVkIFVTQiBkZXZpY2VzIChBWDg4MTc5IGFuZCBQTDI3NzUpIG5lc3RlZCB1bmRlciB0 aGUKaW5jb3JyZWN0IGh1YiBoZXJlPwoKU2luY2UgdGhlc2UgYXJlIFN1cGVyU3BlZWQgY2FwYWJs ZSBkZXZpY2VzLCB0aGV5IHdpbGwgZW51bWVyYXRlIG9uIHRoZQpTdXBlclNwZWVkIGJ1cy4gQnkg cGxhY2luZyB0aGVtIHVuZGVyIHRoZSBIaWdoU3BlZWQgaHViIChodWJfMl8wKSBpbnN0ZWFkCm9m IHRoZSBTdXBlclNwZWVkIGh1YiAoaHViXzNfMCksIHRoZSBVU0IgY29yZSB3b24ndCBiZSBhYmxl IHRvIG1hdGNoIHRoZQplbnVtZXJhdGVkIGRldmljZSB0byBhIERUIGNoaWxkLgoKV2lsbCB0aGlz IGNhdXNlIGRldmljZS1zcGVjaWZpYyBEVCBwcm9wZXJ0aWVzIGxpa2UgcmVzZXQtZ3Bpb3MgdG8g YmUKc2lsZW50bHkgaWdub3JlZCBkdXJpbmcgVVNCIGVudW1lcmF0aW9uPwoKPiArCQkJcmVnID0g PDE+Owo+ICsJCQlyZXNldC1ncGlvcyA9IDwmcG04OTQxX2dwaW9zIDEwIEdQSU9fQUNUSVZFX0xP Vz47Cj4gKwkJCXZkZC1zdXBwbHkgPSA8JnB3cl9jXzNwMz47Cj4gKwkJfTsKPiArCj4gKwkJLyog QVNJWCBBWDg4MTc5IFVTQi1HYkUgY29udHJvbGxlciBvbiB0aGUgRE4yIHBvcnQgKi8KPiArCQll dGhlcm5ldEAzIHsKPiArCQkJY29tcGF0aWJsZSA9ICJ1c2JiOTUsMTc5MCI7Cj4gKwkJCXJlZyA9 IDwzPjsKPiArCQkJcmVzZXQtZ3Bpb3MgPSA8JnBtODk0MV9ncGlvcyA5IEdQSU9fQUNUSVZFX0xP Vz47Cj4gKwkJCXZkZC1zdXBwbHkgPSA8JnB3cl9jXzNwMz47Cj4gKwkJfTsKPiArCX07Cj4gKwo+ ICsJaHViXzNfMDogaHViQDIgewo+ICsJCWNvbXBhdGlibGUgPSAidXNiNDUxLDgwNDEiOwo+ICsJ CXJlZyA9IDwyPjsKCltTZXZlcml0eTogSGlnaF0KSXMgdGhpcyBwb3J0IGFkZHJlc3MgdmFsaWQg Zm9yIHRoZSBTdXBlclNwZWVkIGh1Yj8KClRoZSBBUFE4MDc0IERXQzMgY29udHJvbGxlciBoYXMg YSBzaW5nbGUgcGh5c2ljYWwgcG9ydCwgbWVhbmluZyBib3RoIHJvb3QgaHVicwpzaG91bGQgZXhw b3NlIGV4YWN0bHkgb25lIHBvcnQgKHBvcnQgMSkuIEJlY2F1c2UgdGhpcyB1c2VzIHJlZyA9IDwy PiwgdGhlClVTQiAzLjAgcm9vdCBodWIgd2lsbCBsb29rIGZvciBwb3J0IDEgYW5kIGluc3RlYWQg ZmluZCBodWJfMl8wICh3aGljaCBoYXMKcmVnID0gPDE+KS4KCkRvZXMgdGhpcyBsZWF2ZSBodWJf M18wIG9ycGhhbmVkIGFuZCBicmVhayBEVCBub2RlIG1hcHBpbmc/Cgo+ICsJCXBlZXItaHViID0g PCZodWJfMl8wPjsKPiArCQlyZXNldC1ncGlvcyA9IDwmcG04OTQxX2dwaW9zIDYgR1BJT19BQ1RJ VkVfTE9XPjsKPiArCQl2ZGQtc3VwcGx5ID0gPCZwd3JfY18zcDM+Owo+ICsJfTsKPiArfTsKCkEg cmVsYXRlZCBpc3N1ZSBhcHBlYXJzIHRvIGV4aXN0IGluIHRoZSBQSFkgaW5pdGlhbGl6YXRpb24g c2VxdWVuY2UgZm9yIHRoaXMKaGFyZHdhcmU6Cgpkcml2ZXJzL3BoeS9xdWFsY29tbS9waHktcWNv bS1pcHE4MDZ4LXVzYi5jOnFjb21faXBxODA2eF91c2JfaHNfcGh5X2luaXQoKSB7CiAgICAuLi4K ICAgIHdyaXRlbCh2YWwsIHBoeV9kd2MzLT5iYXNlICsgSFNVU0JfUEhZX0NUUkxfUkVHKTsKICAg IC4uLgp9CgpbU2V2ZXJpdHk6IEhpZ2hdCkRvZXMgcWNvbV9pcHE4MDZ4X3VzYl9oc19waHlfaW5p dCgpIG92ZXJ3cml0ZSB0aGUgZW50aXJlIEhTVVNCX1BIWV9DVFJMX1JFRz8KCklmIHRoZSBNU004 OTc0IEhTIFBIWSBwcm9iZSByZXVzZXMgdGhpcyBmdW5jdGlvbiwgY2FsbGluZyB3cml0ZWwoKSB3 aXRob3V0IGEKcHJpb3IgcmVhZGwoKSB3aWxsIGRlc3Ryb3kgdGhlIGJvb3Rsb2FkZXItY29uZmln dXJlZCByZWZlcmVuY2UgZnJlcXVlbmN5CnN0cmFwcy4gVGhpcyBzZWVtcyB0byBjb250cmFkaWN0 IHRoZSByZXF1aXJlbWVudCB0byBwcmVzZXJ2ZSB0aGVzZSBzdHJhcApiaXRzLgoKLS0gClNhc2hp a28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MDgxMC1t c204OTc0LXVzYjMtdjEtMC0xYTQ3ZTExODU1MjRAb3NzLnF1YWxjb21tLmNvbT9wYXJ0PTEwCgot LSAKbGludXgtcGh5IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwczovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1waHkK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E0253CC7CD for ; Mon, 10 Aug 2026 12:07:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786363640; cv=none; b=cl+uzQNtlsquBT5zAT9kz1X4pDAJ2Fomvf/KZmeP5Rzp21A5iXKywXLZvd0RriUSvzx3KAmArsvtX3c3MqEf+yb+Pl3rxxmPjfseoTzA3uIs63JBrVCMbVD//AmPEQ8j1+wglAqUiH4kdmN/YJPLyJR6M1e3ir7zOeHNaUBrye4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786363640; c=relaxed/simple; bh=iYlzfa+JJZguDfn5xK1/k+uRZV6TGUwEuRvb8RZMyOE=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=JH2a8QpzKip58917qCkwTZ5LwCJ7Y9WC8MYNI5IR/WfmfwfX4qoslFCPq+yg2hD36ESztLy3qN3k6nup72Pk8jeSsOy8WyKlSAG9Uu63EqP98ERotfzKlnlpVMMyn3gJYbUEYP5vAO3cLz39ITsfNVjY912bGZLwY/KCv2otHp0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=V7Skn+yo; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="V7Skn+yo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3AD161F00A3A; Mon, 10 Aug 2026 12:07:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786363639; bh=YRHPFMgdaA0yiUbbK8fEIq4YxUNO4dVldMnmHB8GPGU=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=V7Skn+yotrckp+a0sTthvv3EhH3kYOIhz7IjmBJQ3qQnWkxmOyq+j9p7/P5Ugmad6 tqiZjC7vyyrGBMgot7ExPA7aAcrG0RW33BoukRJAO9PZs6wzeFL32tPmFyIrMm+QN7 7rq71ozSCPVG2lL4fuEx8D+KyNnGrlozBOpiHuGqWJK9PaMs/tCSV3yVbtpRKyk7M/ 9GrV98LcLEgP6ipRQMuEoTwV7Zc9PmgiAzAc9UJk7o4rimUGFKVXpIjSEIKgNxFnke br29Xc8j5fRmKNnaRzLzZ/vUJAHUgUPjciKnqH/8x7PyZhPluFJvsfNEgmjkHj+Fay RkHIeAK+Yhx5Q== From: sashiko-bot@kernel.org Subject: Re: [PATCH 10/10] ARM: dts: qcom: apq8074-dragonboard: enable the USB3 host Reply-To: sashiko-reviews@lists.linux.dev To: "Dmitry Baryshkov" Cc: vkoul@kernel.org, neil.armstrong@linaro.org, robh@kernel.org, linux-phy@lists.infradead.org, olteanv@gmail.com, devicetree@vger.kernel.org, conor+dt@kernel.org In-Reply-To: <20260810-msm8974-usb3-v1-10-1a47e1185524@oss.qualcomm.com> References: <20260810-msm8974-usb3-v1-0-1a47e1185524@oss.qualcomm.com> <20260810-msm8974-usb3-v1-10-1a47e1185524@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 10 Aug 2026 12:07:17 +0000 Message-Id: <20260810120718.3AD161F00A3A@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 4 potential issue(= s) to consider: - [High] The `reset-gpios` and `vdd-supply` properties for the USB hubs and= peripherals will be completely ignored because their compatible strings ar= e not supported by the kernel's onboard USB dev driver. - [High] `qcom_ipq806x_usb_hs_phy_init()` overwrites the entire `HSUSB_PHY_= CTRL_REG`, destroying bootloader-configured frequency straps for MSM8974. - [High] SuperSpeed USB devices (AX88179 and PL2775) are incorrectly nested= under the HighSpeed hub (`hub_2_0`) instead of the SuperSpeed hub (`hub_3_= 0`). - [High] The SuperSpeed hub (`hub_3_0`) is assigned an invalid port address= (`reg =3D <2>`), breaking DT node mapping for both root hubs. -- --- Patch [10]: [PATCH 10/10] ARM: dts: qcom: apq8074-dragonboard: enable t= he USB3 host --- commit 316b8b1bbfd2cabe66fe0293f9ed61e3a48ec197 Author: Dmitry Baryshkov ARM: dts: qcom: apq8074-dragonboard: enable the USB3 host The USB3 port of the dragonboard drives the onboard TUSB8040A hub with the AX88179 GbE controller and the PL2775 USB-SATA bridge behind it. This commit enables the DWC3 controller in host mode along with its PHYs and describes the onboard chain as device nodes under the controller. > diff --git a/arch/arm/boot/dts/qcom/qcom-apq8074-dragonboard.dts b/arch/a= rm/boot/dts/qcom/qcom-apq8074-dragonboard.dts > --- a/arch/arm/boot/dts/qcom/qcom-apq8074-dragonboard.dts > +++ b/arch/arm/boot/dts/qcom/qcom-apq8074-dragonboard.dts [ ... ] > + /* TI TUSB8040A four port hub */ > + hub_2_0: hub@1 { > + compatible =3D "usb451,8043"; [Severity: High] Will the reset-gpios and vdd-supply properties be ignored here? The new compatible strings (usb451,8043, usb451,8041, usb67b,2775, usbb95,1790) do not appear to be supported by the onboard_usb_dev driver's onboard_dev_match array. The generic USB core parses these nodes but does not natively handle reset-gpios. Could this cause the reset lines to float and power sequencing to be unmanaged, preventing proper enumeration? > + reg =3D <1>; > + peer-hub =3D <&hub_3_0>; > + reset-gpios =3D <&pm8941_gpios 6 GPIO_ACTIVE_LOW>; > + vdd-supply =3D <&pwr_c_3p3>; > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + /* Prolific PL2775 USB-SATA bridge on the DN0 port */ > + device@1 { > + compatible =3D "usb67b,2775"; [Severity: High] Are the SuperSpeed USB devices (AX88179 and PL2775) nested under the incorrect hub here? Since these are SuperSpeed capable devices, they will enumerate on the SuperSpeed bus. By placing them under the HighSpeed hub (hub_2_0) instead of the SuperSpeed hub (hub_3_0), the USB core won't be able to match the enumerated device to a DT child. Will this cause device-specific DT properties like reset-gpios to be silently ignored during USB enumeration? > + reg =3D <1>; > + reset-gpios =3D <&pm8941_gpios 10 GPIO_ACTIVE_LOW>; > + vdd-supply =3D <&pwr_c_3p3>; > + }; > + > + /* ASIX AX88179 USB-GbE controller on the DN2 port */ > + ethernet@3 { > + compatible =3D "usbb95,1790"; > + reg =3D <3>; > + reset-gpios =3D <&pm8941_gpios 9 GPIO_ACTIVE_LOW>; > + vdd-supply =3D <&pwr_c_3p3>; > + }; > + }; > + > + hub_3_0: hub@2 { > + compatible =3D "usb451,8041"; > + reg =3D <2>; [Severity: High] Is this port address valid for the SuperSpeed hub? The APQ8074 DWC3 controller has a single physical port, meaning both root h= ubs should expose exactly one port (port 1). Because this uses reg =3D <2>, the USB 3.0 root hub will look for port 1 and instead find hub_2_0 (which has reg =3D <1>). Does this leave hub_3_0 orphaned and break DT node mapping? > + peer-hub =3D <&hub_2_0>; > + reset-gpios =3D <&pm8941_gpios 6 GPIO_ACTIVE_LOW>; > + vdd-supply =3D <&pwr_c_3p3>; > + }; > +}; A related issue appears to exist in the PHY initialization sequence for this hardware: drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:qcom_ipq806x_usb_hs_phy_init() { ... writel(val, phy_dwc3->base + HSUSB_PHY_CTRL_REG); ... } [Severity: High] Does qcom_ipq806x_usb_hs_phy_init() overwrite the entire HSUSB_PHY_CTRL_REG? If the MSM8974 HS PHY probe reuses this function, calling writel() without a prior readl() will destroy the bootloader-configured reference frequency straps. This seems to contradict the requirement to preserve these strap bits. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260810-msm8974-us= b3-v1-0-1a47e1185524@oss.qualcomm.com?part=3D10