From: sashiko-bot@kernel.org
To: "Vladimir Oltean" <vladimir.oltean@nxp.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH v9 2/3] PCI: Add missing headers transitively included by <linux/phy/phy.h>
Date: Mon, 10 Aug 2026 12:46:53 +0000 [thread overview]
Message-ID: <20260810124654.4DEF01F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260810124315.433448-3-vladimir.oltean@nxp.com>
> The tegra as well as a few dwc PCI controller drivers uses PM runtime
> operations without including the required <linux/pm_runtime.h> header.
>
> Similarly, pcie-rockchip-host, pcie-starfive as well as a few dwc PCI
> controllers use the regulator consumer API without including
> <linux/regulator/consumer.h>.
>
> pcie-spacemit-k1.c uses of_get_next_available_child() and of_node_put()
> without including <linux/of.h>.
>
> It seems these function prototypes were indirectly provided by
> <linux/phy/phy.h>, mostly by mistake (none of the functions it exports
> need it).
>
> Before the PHY header can drop the unnecessary includes, make sure the
> PCI controller drivers include what they use.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260810124315.433448-1-vladimir.oltean@nxp.com?part=2
next prev parent reply other threads:[~2026-08-10 12:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 12:43 [PATCH v9 0/3] PCI prerequisites for PHY consumer/provider split Vladimir Oltean
2026-08-10 12:43 ` Vladimir Oltean
2026-08-10 12:43 ` Vladimir Oltean
2026-08-10 12:43 ` [PATCH v9 1/3] PCI: cadence: Preserve all error codes in cdns_plat_pcie_probe() Vladimir Oltean
2026-08-10 12:43 ` Vladimir Oltean
2026-08-10 12:43 ` Vladimir Oltean
2026-08-10 12:56 ` sashiko-bot
2026-08-10 12:43 ` [PATCH v9 2/3] PCI: Add missing headers transitively included by <linux/phy/phy.h> Vladimir Oltean
2026-08-10 12:43 ` Vladimir Oltean
2026-08-10 12:43 ` Vladimir Oltean
2026-08-10 12:46 ` sashiko-bot [this message]
2026-08-10 12:43 ` [PATCH v9 3/3] PCI: Remove device links to PHY Vladimir Oltean
2026-08-10 12:43 ` Vladimir Oltean
2026-08-10 12:43 ` Vladimir Oltean
2026-08-10 12:58 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260810124654.4DEF01F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.