All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ziran Zhang <zhangcoder@yeah.net>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	Simon Horman <horms@kernel.org>, Jakub Kicinski <kuba@kernel.org>,
	Kuniyuki Iwashima <kuniyu@google.com>,
	linux-kernel@vger.kernel.org,
	Neal Cardwell <ncardwell@google.com>,
	netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
	Ziran Zhang <zhangcoder@yeah.net>
Subject: Re: [PATCH net-next] tcp: use likely() for srtt check in tcp_rtt_estimator()
Date: Mon, 10 Aug 2026 21:25:15 +0800	[thread overview]
Message-ID: <20260810132515.6576-1-zhangcoder@yeah.net> (raw)
In-Reply-To: <CANn89iK8KSx+EfuANe6JuP=K0DrgTAiToPDH5L0chOj+uO9NUA@mail.gmail.com>

On Mon, 10 Aug 2026 14:51:09 +0200, Eric Dumazet wrote:
> Many flows are short lived, unfortunately.
> 
> I would suggest not adding a likely() here, and let FDO/LTO decide
> here on a case by case.

Hi Eric,

Thank you for your review.

I didn't fully take into account the large number of short-lived flows 
in real-world networks. I agree with your assessment, so I will drop this patch.

Thanks,
Ziran Zhang


      reply	other threads:[~2026-08-10 13:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-08 11:00 [PATCH net-next] tcp: use likely() for srtt check in tcp_rtt_estimator() Ziran Zhang
2026-08-10 12:51 ` Eric Dumazet
2026-08-10 13:25   ` Ziran Zhang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260810132515.6576-1-zhangcoder@yeah.net \
    --to=zhangcoder@yeah.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kuniyu@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.