Re: [PATCH v2 10/12] gpu: nova-core: mm: Add GpuMm centralized memory manager

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `pramin_mut` method in `GpuMm` is missing the `pub(crate)` visibility modifier, despite the commit message claiming it is exposed for follow-on patches.
--

--- Patch [10]: [PATCH v2 10/12] gpu: nova-core: mm: Add GpuMm centralized memory manager ---
commit 454fed327c5dab971b01225656d96fa09a0fc921
Author: Joel Fernandes <joelagnelf@nvidia.com>

gpu: nova-core: mm: Add GpuMm centralized memory manager

Introduce GpuMm as the centralized GPU memory manager. At this point in
the series, GpuMm only owns the PRAMIN window for direct VRAM access. This
provides a clean ownership model where GpuMm provides accessor methods for
its components.

> diff --git a/drivers/gpu/nova-core/mm.rs b/drivers/gpu/nova-core/mm.rs
> index ef5b1cad56c31..58dce211a3373 100644
> --- a/drivers/gpu/nova-core/mm.rs
> +++ b/drivers/gpu/nova-core/mm.rs

[ ... ]

> +
> +    /// Access the [`pramin::Pramin`].
> +    fn pramin_mut(&mut self) -> &mut pramin::Pramin<'gpu> {
> +        &mut self.pramin
> +    }
> +}

[Severity: Medium]
The commit message mentions this provides accessor methods so that follow-on
patches can reference pramin_mut() cleanly. However, GpuMm::pramin_mut() is
defined without the pub(crate) visibility modifier, making it strictly private
to the mm module.

Will this prevent cross-subsystem access from gpu.rs or external tests as
intended by the commit message?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260810-pramin-split-v2-0-65a00b3c7309@nvidia.com?part=10